[LU-8561] Redundant check in osd_mount

Wed, 5 Oct 2016 11:56:33 +0000

smatch reports that:

1030	1030	 err:
1031	1031	 »       if (rc) {
1032	1032	 »       »       if (o->od_os)
Misc Code Checks Robot (Gatekeeper helper)	warn: osd_mount():variable dereferenced before check 'o->od_os' (see line …

Basically the problem here is o->od_os is always true.

While it's possible to convert this to LASSERT, I wonder if we should just drop it altogether since there'd be crash either way.

This was exposed by landing of ~~LU-4865~~ patch, even though the problem actually was there before it

Whamcloud Community JIRA

[LU-8561] Redundant check in osd_mount