https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8603 Lustre <p>Currently, there are no sub-tests in metadata-updates.sh, which causes test failure logs are not gathered with proper names that can be imported by Maloo. Such as:<br/> <a href="https://testing.hpdd.intel.com/test_sets/12cab8e0-2c5c-11e6-a0ce-5254006e85c2" class="external-link" target="_blank" rel="nofollow noopener">https://testing.hpdd.intel.com/test_sets/12cab8e0-2c5c-11e6-a0ce-5254006e85c2</a></p> <p>We need improve metadata-updates.sh to wrap the tests with test_x().</p> LU-8603

improve metadata-updates.sh with sub-tests

Bug Minor Resolved Fixed Saurabh Tandan Jian Yu Mon, 12 Sep 2016 15:41:06 +0000 Wed, 19 Apr 2017 12:29:08 +0000 Wed, 19 Apr 2017 12:29:08 +0000 Lustre 2.9.0 Lustre 2.10.0 0 4 <p>Debug marker needs be made at the begining of each test case (operation), that'll be helpful for reading the debug log. For example:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">do_change_timestamps () { echo <span class="code-quote">"Changing atime, mtime ..."</span> do_nodes $NODES_TO_USE " set $TRACE; TESTFILE=$TESTDIR/\\\$(hostname)/$FILE; touch -c --date=\\\<span class="code-quote">"$NEW_ATIME\\\"</span> -a \\\$TESTFILE; touch -c --date=\\\<span class="code-quote">"$NEW_MTIME\\\"</span> -m \\\$TESTFILE " || <span class="code-keyword">return</span> ${PIPESTATUS[0]} <span class="code-keyword">return</span> 0 } </pre> </div></div> <p>Besides this "echo", a debug marker will be helpful. </p> <p>James Nunez (james.a.nunez@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/24450" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24450</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8603" title="improve metadata-updates.sh with sub-tests" class="issue-link" data-issue-key="LU-8603"><del>LU-8603</del></a> test: Separate tests in metadata_updates<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ec5d2a24c1cf9287e9884d240215bdd25d68a7f5</p> <p>Niu - The patch to break up the subtest of metadata-updates is failing with </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>trevis-35vm1: /mnt/lustre/d0.metadata-updates/trevis-35vm1.trevis.hpdd.intel.com/testfile [ uid gid size mode ] expected : root root 0 0644 ; got : root root 0 0222 trevis-35vm1: Wrong file attributes trevis-35vm2: /mnt/lustre/d0.metadata-updates/trevis-35vm1.trevis.hpdd.intel.com/testfile [ uid gid size mode ] expected : root root 0 0644 ; got : root root 0 0222 trevis-35vm2: Wrong file attributes metadata-updates test_3: @@@@@@ FAIL: wrong attributes after truncate </pre> </div></div> <p>Logs are at <a href="https://testing.hpdd.intel.com/test_sets/21227fca-c7c7-11e6-9e78-5254006e85c2" class="external-link" target="_blank" rel="nofollow noopener">https://testing.hpdd.intel.com/test_sets/21227fca-c7c7-11e6-9e78-5254006e85c2</a>.</p> <p>Previously, the call to get_stat to check the file attributes after truncate was not a fatal error, but a "error_noexit". So, we never failed the test if the attributes were incorrect after truncate. </p> <p>Should we error out if the attributes are not correct or is there a reason to ignore the new attributes if they do not match what is expected?</p> <p>The original script will update CURRENT_MODE (0644) to NEW_MODE (0222) in do_chmod() of 2nd test case, but looks it failed to update the value now when you moved them into sub tests.</p> <p>Another problem is that all test cases are depended each other, none of them can be executed individually (except the first one), so it doesn't make much sense to separate them into sub-tests.</p> <p>Rather than moving them into separate sub-tests, I think probably just use debug marker (lctl mark ...) to make the test cases distinguishable in debug log is good enough? (and replace most 'echo' with 'log' to make sure the important messages saved in test log).</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/24450/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24450/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8603" title="improve metadata-updates.sh with sub-tests" class="issue-link" data-issue-key="LU-8603"><del>LU-8603</del></a> test: Separate tests in metadata_updates<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d5fbf74a2f4fbd796a4009bf8d10dcdeb029b44b</p> <p>Landed for 2.10</p> Related LU-8446 Development Rank 1|hzyo0n: Rank (Obsolete) 9223372036854775807 Severity