<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 02:19:14 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-8632] Address of function &apos;page_count&apos; is used instead of a local variable</title>
                <link>https://jira.whamcloud.com/browse/LU-8632</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;In the following commit&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;commit 7f2aae8d80a73de7408668bbe569d5f4d8553efe
Author: Jinshan Xiong &amp;lt;jinshan.xiong@intel.com&amp;gt;
Date:   Mon Sep 12 11:17:10 2016 -0700

    LU-8135 osc: limits the number of chunks in write RPC
    
    OSC has to make sure that it won&apos;t issue write RPCs with too many
    chunks otherwise it will casue ZFS to create transactions much
    bigger than DMU_MAX_ACCESS in size, which will end up with write
    failure.
    
    Signed-off-by: Jinshan Xiong &amp;lt;jinshan.xiong@intel.com&amp;gt;
    Change-Id: Ib68b09afca35c253ef0a6b569f64f555e08bd11b
    Reviewed-on: http://review.whamcloud.com/22369
    Tested-by: Jenkins
    Reviewed-by: Andreas Dilger &amp;lt;andreas.dilger@intel.com&amp;gt;
    Reviewed-by: Patrick Farrell &amp;lt;paf@cray.com&amp;gt;
    Tested-by: Maloo &amp;lt;hpdd-maloo@intel.com&amp;gt;
    Reviewed-by: Oleg Drokin &amp;lt;oleg.drokin@intel.com&amp;gt;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;the local variable &apos;page_count&apos; in osc_send_read_rpc() was removed:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;-       unsigned &lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt; page_count = 0;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;but ASSERT with this variable was not:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;2171:	LASSERT(page_count &amp;gt; 0);
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="39962">LU-8632</key>
            <summary>Address of function &apos;page_count&apos; is used instead of a local variable</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.whamcloud.com/images/icons/priorities/minor.svg">Minor</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="dmiter">Dmitry Eremin</assignee>
                                    <reporter username="dmiter">Dmitry Eremin</reporter>
                        <labels>
                            <label>kw</label>
                    </labels>
                <created>Wed, 21 Sep 2016 11:25:26 +0000</created>
                <updated>Thu, 29 Sep 2016 16:10:51 +0000</updated>
                            <resolved>Thu, 29 Sep 2016 16:10:51 +0000</resolved>
                                                    <fixVersion>Lustre 2.9.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                            <comments>
                            <comment id="166696" author="gerrit" created="Wed, 21 Sep 2016 11:33:50 +0000"  >&lt;p&gt;Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: &lt;a href=&quot;http://review.whamcloud.com/22654&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/22654&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-8632&quot; title=&quot;Address of function &amp;#39;page_count&amp;#39; is used instead of a local variable&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-8632&quot;&gt;&lt;del&gt;LU-8632&lt;/del&gt;&lt;/a&gt; osc: remove of usage removed &apos;page_count&apos; local variable&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 41818fd9249b3807de74ffe80dca715479d82e71&lt;/p&gt;</comment>
                            <comment id="166721" author="jay" created="Wed, 21 Sep 2016 15:55:55 +0000"  >&lt;p&gt;Interesting - why wasn&apos;t this issue caught by compiler?&lt;/p&gt;</comment>
                            <comment id="166770" author="green" created="Wed, 21 Sep 2016 18:53:18 +0000"  >&lt;p&gt;the&apos;res a kernel function named page_count(), that checks the count of a page, so I guess it became unaliased now and we make sure it&apos;s never NULL &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.whamcloud.com/images/icons/emoticons/wink.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="166781" author="jay" created="Wed, 21 Sep 2016 19:23:17 +0000"  >&lt;p&gt;indeed. thanks for explanation.&lt;/p&gt;

&lt;p&gt;However, page_count() is defined as an inline function:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;&lt;span class=&quot;code-keyword&quot;&gt;static&lt;/span&gt; inline &lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt; page_count(struct page *page)
{
        &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; atomic_read(&amp;amp;compound_head(page)-&amp;gt;_count);
}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;what would be the address of this function?&lt;/p&gt;
</comment>
                            <comment id="167149" author="green" created="Sat, 24 Sep 2016 03:59:53 +0000"  >&lt;p&gt;It would create a static instance and use that address I am sure. You can write a simple test case to see it in action, I guess.&lt;/p&gt;</comment>
                            <comment id="167742" author="gerrit" created="Thu, 29 Sep 2016 15:00:37 +0000"  >&lt;p&gt;Oleg Drokin (oleg.drokin@intel.com) merged in patch &lt;a href=&quot;http://review.whamcloud.com/22654/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/22654/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-8632&quot; title=&quot;Address of function &amp;#39;page_count&amp;#39; is used instead of a local variable&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-8632&quot;&gt;&lt;del&gt;LU-8632&lt;/del&gt;&lt;/a&gt; osc: remove of usage removed &apos;page_count&apos; local variable&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: f2b457a063159e3ae6d4dfe3b86910b3d4e0d8b2&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                            <outwardlinks description="is related to ">
                                        <issuelink>
            <issuekey id="36888">LU-8135</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzyp73:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>