[LU-8723] llapi_obd_statfs() tests errno in non error cases, may leak file descriptors

Related — Wed, 16 Nov 2016 00:40:03 +0000

In llapi_obd_statfs() we have:

        fd = open(path, O_RDONLY);
        if (errno == EISDIR)
                fd = open(path, O_DIRECTORY | O_RDONLY);

Second, if open() succeeds then the value of errno is arbitrary and the file descriptor may be leaked if errno was previously set to EISDIR.

Also note that open() will never set errno to EISDIR when write access is not requested.

Whamcloud Community JIRA