https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8724 Lustre <p>llapi_get_obd_count(), llapi_ostlist(), llapi_quotactl(), llapi_get_connect_flags(), and possibly other llapi functions are using <tt>opendir()</tt>, <tt>dirfd()</tt>, and <tt>closedir()</tt> when <tt>open()</tt> and <tt>close()</tt> would suffice.</p> LU-8724

several llapi functions use opendir() when open() would suffice

Bug Minor Resolved Fixed Steve Guminski John Hammond easy llapi Tue, 18 Oct 2016 21:35:32 +0000 Fri, 23 Dec 2016 13:42:53 +0000 Fri, 23 Dec 2016 13:42:53 +0000 Lustre 2.9.0 Lustre 2.10.0 0 4 <p>I don't think llapi_ostlist() should be changed, because it uses the opened directory as a parameter to setup_obd_uuid(), which takes a DIR pointer.</p> <p>Steve Guminski (stephenx.guminski@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23981" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23981</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8724" title="several llapi functions use opendir() when open() would suffice" class="issue-link" data-issue-key="LU-8724"><del>LU-8724</del></a> utils: Use open() instead of opendir() with dirfd()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f57b28954e8fff0467e3d7877c003c62cefe768f</p> <p>While you are at it another issue exist as well with newer platforms. On my Ubuntu 16 system I get the following build issues:</p> <p>gcc -DHAVE_CONFIG_H -I. -I../.. -include /usr/src/lustre-2.8.60/undef.h -include /usr/src/lustre-2.8.60/config.h -I/usr/src/lustre-2.8.60/libcfs/include -I/usr/src/lustre-2.8.60/lnet/include -I/usr/src/lustre-2.8.60/lustre/include -fPIC -D_GNU_SOURCE -D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DLUSTRE_UTILS=1 -g -O2 -Wall -Werror -MT liblustreapi.o -MD -MP -MF .deps/liblustreapi.Tpo -c -o liblustreapi.o liblustreapi.c<br/> liblustreapi.c: In function ‘llapi_get_poollist’:<br/> liblustreapi.c:1196:3: error: ‘readdir_r’ is deprecated <span class="error">&#91;-Werror=deprecated-declarations&#93;</span><br/> rc = readdir_r(dir, &amp;pool, &amp;cookie);<br/> ^~<br/> In file included from /usr/include/features.h:364:0,<br/> from /usr/include/mntent.h:22,<br/> from liblustreapi.c:44:<br/> /usr/include/dirent.h:189:12: note: declared here<br/> extern int __REDIRECT (readdir_r,<br/> ^<br/> cc1: all warnings being treated as errors<br/> Makefile:1191: recipe for target 'liblustreapi.o' failed</p> <p>readdir() is the replacement for this function,</p> <p>&gt; I don't think llapi_ostlist() should be changed, because it uses the opened directory as a parameter to setup_obd_uuid(), which takes a DIR pointer.</p> <p>setup_obd_uuid() only uses the dir parameter as an argument to dirfd(). So its <tt>DIR *dir</tt> parameter should be replaced with <tt>int fd</tt>.</p> <p>James, please open a new issue.</p> <p>OK. setup_obd_uuid() is called elsewhere, so I'll have to update the other code that will be impacted. I'll upload a new patch when those changes are made.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/23981/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/23981/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8724" title="several llapi functions use opendir() when open() would suffice" class="issue-link" data-issue-key="LU-8724"><del>LU-8724</del></a> utils: Use open() instead of opendir() with dirfd()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 44b6af40f70cf065e8198b6b438d6c953063d003</p> <p>Landed for 2.10</p> Development Rank 1|hzysfb: Rank (Obsolete) 9223372036854775807 Severity