https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8737 Lustre <p>Now that the upstream client is approaching the 2.8 version it is time to hook in testing setup to verify potential patches to land. When I went to check out the staging tree used for testing I noticed it is based on the wrong git tree. It needs to be based on the staging tree's staging-next branch.</p> lustre staging tree that gerrit uses. LU-8737

Lustre upstream client tree for testing is wrong branch

Bug Minor Resolved Not a Bug Minh Diep James A Simmons Wed, 19 Oct 2016 18:07:53 +0000 Fri, 20 Jan 2017 22:50:00 +0000 Tue, 25 Oct 2016 18:49:33 +0000 0 5 <p>Hi Minh,</p> <p>Could you please take a look at this issue or find someone proper to resolve the issue? Thank you.</p> <p>Hi James,</p> <p>Could you let me know exactly what you check? More info would help me understand.</p> <p>Thanks<br/> -Minh</p> <p>I checked out:</p> <p>ssh://jsimmons@review.whamcloud.com:29418/fs/linux-staging</p> <p>Is this the wrong thing that I checked out?</p> <p>What is used for upstream lustre developement is:</p> <p>git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git</p> <p>Then switch to branch staging-testing</p> <p>Hi James,</p> <p>These are what we mirrored</p> <p>git remote add linux <a href="http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" class="external-link" target="_blank" rel="nofollow noopener">http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git</a><br/> git remote add stable <a href="http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git" class="external-link" target="_blank" rel="nofollow noopener">http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git</a><br/> git remote add staging <a href="http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git" class="external-link" target="_blank" rel="nofollow noopener">http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git</a></p> <p>I compared staging.git/staging-testing and our mirrored fs/linux-testing/staging-testing; and they seem to match. am I missing something?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> bddalton-mobl:staging minhdiep$ grep url .git/config url = http:<span class="code-comment">//git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git </span>bddalton-mobl:staging minhdiep$ git lg | head * 49b9137 - (HEAD, origin/staging-testing, origin/staging-next, staging-testing, staging-next) staging: greybus: audio: remove redundant slot field (25 hours ago)&lt;Pankaj Bharadiya&gt; * 73270bb - Staging: Greybus: Fix trailing */ in block comments (25 hours ago)&lt;Rahul Krishnan&gt; * 7fec2bc - staging: greybus: es2: fix arpc request size (25 hours ago)&lt;Rui Miguel Silva&gt; * f9a21a3 - staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable conversion. (25 hours ago)&lt;Elise Lennion&gt; * 5bc45c9d - staging: xgifb: Remove unnecessary parentheses. (25 hours ago)&lt;Elise Lennion&gt; * 596f144 - staging: vt6656: Remove unnecessary parentheses. (25 hours ago)&lt;Elise Lennion&gt; * a0f204a - Staging: android: ion: Make a read-only structure (25 hours ago)&lt;Mihaela Muraru&gt; * 9fdd532 - staging: android: Remove unnecessary parentheses. (25 hours ago)&lt;Elise Lennion&gt; * f9bee6d - staging: vc04_services: Add casts to remove warnings in vchiq_core.c (26 hours ago)&lt;Michael Zoran&gt; * 8e8e2e3 - staging: vc04_services: Handle conversion from VCHIQ_SERVICE_HANDLE_T to VCHI_SERVICE_HANDLE_T (26 hours ago)&lt;Michael Zoran&gt; hgyoo-mobl3:linux-staging minhdiep$ grep url .git/config url = ssh:<span class="code-comment">//mdiep@review.whamcloud.com:29418/fs/linux-staging </span>hgyoo-mobl3:linux-staging minhdiep$ git lg | head * 49b9137 - (HEAD, origin/staging-testing, origin/staging-next, staging-testing, staging-next) staging: greybus: audio: remove redundant slot field (25 hours ago)&lt;Pankaj Bharadiya&gt; * 73270bb - Staging: Greybus: Fix trailing */ in block comments (25 hours ago)&lt;Rahul Krishnan&gt; * 7fec2bc - staging: greybus: es2: fix arpc request size (25 hours ago)&lt;Rui Miguel Silva&gt; * f9a21a3 - staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable conversion. (25 hours ago)&lt;Elise Lennion&gt; * 5bc45c9d - staging: xgifb: Remove unnecessary parentheses. (25 hours ago)&lt;Elise Lennion&gt; * 596f144 - staging: vt6656: Remove unnecessary parentheses. (25 hours ago)&lt;Elise Lennion&gt; * a0f204a - Staging: android: ion: Make a read-only structure (25 hours ago)&lt;Mihaela Muraru&gt; * 9fdd532 - staging: android: Remove unnecessary parentheses. (25 hours ago)&lt;Elise Lennion&gt; * f9bee6d - staging: vc04_services: Add casts to remove warnings in vchiq_core.c (26 hours ago)&lt;Michael Zoran&gt; * 8e8e2e3 - staging: vc04_services: Handle conversion from VCHIQ_SERVICE_HANDLE_T to VCHI_SERVICE_HANDLE_T (26 hours ago)&lt;Michael Zoran&gt; </pre> </div></div> <p>Ah I didn't know that you mirror several branches. So I did a checkout of the staging-testing branch. Its correct now.<br/> Next step is to see if I can push a patch. When I push something now I see.</p> <p>lustre-upstream$ git push ssh://jsimmons@review.whamcloud.com:29418/fs/linux-staging HEAD:refs/heads/staging-testing<br/> Enter passphrase for key '/ccs/home/jsimmons/.ssh/id_rsa': <br/> Counting objects: 15, done.<br/> Delta compression using up to 24 threads.<br/> Compressing objects: 100% (8/8), done.<br/> Writing objects: 100% (8/8), 953 bytes, done.<br/> Total 8 (delta 7), reused 0 (delta 0)<br/> remote: Resolving deltas: 100% (7/7)<br/> remote: Counting objects: 8, done<br/> remote: Branch refs/heads/staging-testing:<br/> remote: You are not allowed to perform this operation.<br/> remote: To push into this reference you need 'Push' rights.<br/> remote: User: jsimmons<br/> remote: Please read the documentation and contact an administrator<br/> remote: if you feel the configuration is incorrect<br/> remote: Processing changes: refs: 1, done <br/> To ssh://jsimmons@review.whamcloud.com:29418/fs/linux-staging<br/> ! <span class="error">&#91;remote rejected&#93;</span> HEAD -&gt; staging-testing (prohibited by Gerrit)<br/> error: failed to push some refs to 'ssh://jsimmons@review.whamcloud.com:29418/fs/linux-staging'</p> <p>I would think you should use HEAD:refs/for/staging-testing to push for review; and which will trigger a build and test</p> <p>You are right. I'm a idiot. I just pushed the patch. It works:</p> <p><a href="http://review.whamcloud.com/#/c/23382" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/23382</a></p> <p>Don't be so hard on yourself James <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Minh I noticed a few oddities with the pushed patch. The Intel-bug-id: url seems to have gotten mangled. The jenkins build links is also invalid. Lastly do you think it would be possible to get linux/scripts/checkpatch to run against the patch and report the result.</p> <p><b>Thanks Peter</b></p> <p>I will look into the commit message being mangled; and checkpatch .</p> <p>The jenkins build links should be accessible now</p> <p>Yep Jenkins passed. Now for the checkpatch and commit message issue.</p> <p>From Doug's latest patch that was pushed it appears that the commit message issues has been fixed. Does checkpatch run against a submitted patch. Also it looks like the test suite is run against staging-testing branch which is correct. We are making progress.</p> Related LU-7746 Development Rank 1|hzysk7: Rank (Obsolete) 9223372036854775807 Severity