https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8769 Lustre <p>There are several LND types that are no longer in use, and should be removed. The LND types are initialized in this array in libcfs/libcfs/util/nidstrings.c:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">static</span> struct netstrfns libcfs_netstrfns[] </pre> </div></div> <p>The following LNDs should be removed:</p> <ul> <li>CIBLND</li> <li>OPENIBLND</li> <li>IIBLND</li> <li>VIBLND</li> <li>RALND</li> <li>QSWLND</li> <li>GMLND</li> <li>MXLND</li> <li>PTLLND</li> </ul> LU-8769

Remove obsolete LND types

Bug Trivial Resolved Fixed Sonia Sharma Steve Guminski easy Thu, 27 Oct 2016 15:03:27 +0000 Tue, 7 Feb 2017 12:20:33 +0000 Tue, 7 Feb 2017 12:20:33 +0000 Lustre 2.10.0 0 12 <p>Note that some of the LNDs were only recently removed (after 2.5) and at least the name-&gt;network mapping should stick around in order for a client/server to route to that network type (e.g. on a Cray cluster running an older version of Lustre that connects to newer servers), even if it doesn't have support for the network locally. The other IBLND and GMLND types are have not been used for ages so it isn't a concern and they can be removed completely. Please keep commented-out definitions in lnet/include/lnet/nidstr.h (the unnamed enum, that should really get a name like <tt>enum lnet_types</tt> so that this can properly be used elsewhere in the code) to avoid re-using these values:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">enum</span> lnet_types { /* Only add to these values (i.e. don't ever change or redefine them): * network addresses depend on them... */ QSWLND = 1, <span class="code-comment">/* removed v2_7_50_0-34-g8be9e41 */</span> SOCKLND = 2, <span class="code-comment">/* GMLND = 3, removed v2_0_0-rc1a-16-gc660aac */</span> PTLLND = 4, <span class="code-comment">/* removed v2_5_53_0-21-g61bcfb2 */</span> O2IBLND = 5, <span class="code-comment">/* CIBLND = 6, removed v2_0_0-rc1a-175-gd2b8a0e */</span> <span class="code-comment">/* OPENIBLND = 7, removed v2_0_0-rc1a-175-gd2b8a0e */</span> <span class="code-comment">/* IIBLND = 8, removed v2_0_0-rc1a-175-gd2b8a0e */</span> LOLND = 9, RALND = 10, <span class="code-comment">/* removed v2_7_50_0-34-g8be9e41 */</span> <span class="code-comment">/* VIBLND = 11, removed v2_0_0-rc1a-175-gd2b8a0e */</span> MXLND = 12, <span class="code-comment">/* removed v2_7_50_0-34-g8be9e41 */</span> GNILND = 13, GNIIPLND = 14, }; </pre> </div></div> <p>If you are removing the remaining LNDs, please also look at removing the rest of the places where these constants are used (headers, Makefile.*, autoconf, etc). Run e.g. <tt>git grep VIBLND</tt> to see all of the places this is used.</p> <p>FWIW, speaking for Cray, the PTLLND line can be completely commented out. We are confident about never running 2.9 or 2.10 on anything that has a connection with a PTLLND system.</p> <p>Hi Sonia,</p> <p>Would you be able to assess these LND's for possible removal?</p> <p>Thanks.<br/> Joe</p> <p>Just to clarify, the LNDs were removed long ago. All that this ticket is about is removing the name&lt;-&gt;network number mapping for these obsolete LNDs, and (preferably, as stated above) adding clear comments for the removed LND network numbers.</p> <p>Sonia Sharma (sonia.sharma@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23621" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23621</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8769" title="Remove obsolete LND types" class="issue-link" data-issue-key="LU-8769"><del>LU-8769</del></a> lnds: &lt;removal of obsolete LNDs&gt;<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 30f89305b86bf7bb1ebee80cb0cb45e560797b9b</p> <p>Sonia Sharma (sonia.sharma@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23622" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23622</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8769" title="Remove obsolete LND types" class="issue-link" data-issue-key="LU-8769"><del>LU-8769</del></a> lnds: &lt;removal of obsolete LNDs&gt;<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f46c57b6ef24a7809bf7f52bf022ef9061812607</p> <p>Sonia Sharma (sonia.sharma@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23623" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23623</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8769" title="Remove obsolete LND types" class="issue-link" data-issue-key="LU-8769"><del>LU-8769</del></a> lnds: &lt;removal of obsolete LNDs&gt;<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 4c678e349a2dd5c1d8835c6dd8efc4ff87284fb9</p> <p>Sonia Sharma (sonia.sharma@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23627" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23627</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8769" title="Remove obsolete LND types" class="issue-link" data-issue-key="LU-8769"><del>LU-8769</del></a> lnds: &lt;Remove Obsolete LND types&gt;<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: bfbac77aa4dab97b4ffe203fb4e8036a14b01375</p> <p>Sonia Sharma (sonia.sharma@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23628" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23628</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8769" title="Remove obsolete LND types" class="issue-link" data-issue-key="LU-8769"><del>LU-8769</del></a> lnds: &lt;remove obsolete LNDs&gt;<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 06c83c6a51c5b7ee2fb68358b22b534fe5934cf8</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/23621/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/23621/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8769" title="Remove obsolete LND types" class="issue-link" data-issue-key="LU-8769"><del>LU-8769</del></a> lnet: removal of obsolete LNDs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ce8735993473c1055038f7422350c96b092d707d</p> <p>Landed for 2.10</p> Development Rank 1|hzytkv: Rank (Obsolete) 9223372036854775807 Severity