https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8829 Lustre <p>Adding a default secure RPC rule followed by a rule for a specific network changes how the initial default rule is displayed when viewed with 'lctl get_param mgs.*.live.testfs'</p> <p>==<br/> mgs# lctl conf_param testfs.srpc.flavor.default=skpi<br/> mgs# lctl get_param mgs.*.live.testfs<br/> ...<br/> Secure RPC Config Rules:<br/> testfs.srpc.flavor.default=skpi</p> <p>mgs# lctl conf_param testfs.srpc.flavor.tcp=ska<br/> mgs# lctl get_param mgs.*.live.testfs<br/> ...<br/> Secure RPC Config Rules:<br/> testfs.srpc.flavor.tcp=ska<br/> testfs.srpc.flavor.tcp=skpi<br/> ==</p> <p>Notice how the initial testfs.srpc.flavor.default=skpi rule now appears as testfs.srpc.flavor.tcp=skpi.</p> <p>Below is the llog_reader dump of testfs-sptlrpc:<br/> mgs# llog_reader testfs-sptlrpc <br/> rec #1 type=10620000 len=224 offset 8192<br/> rec #2 type=10620000 len=104 offset 8416<br/> rec #3 type=10620000 len=224 offset 8520<br/> rec #4 type=10620000 len=224 offset 8744<br/> rec #5 type=10620000 len=96 offset 8968<br/> rec #6 type=10620000 len=224 offset 9064<br/> Header size : 8192<br/> Time : Fri Nov 11 12:57:59 2016<br/> Number of records: 6<br/> Target uuid : config_uuid<br/> -----------------------<br/> #01 (224)marker 62 (flags=0x01, v2.8.60.0) testfs 'srpc.flavor.default' Fri Nov 11 12:57:59 2016-<br/> #02 (104)sptlrpc_conf 0:testfs 1:srpc.flavor.default=skpi <br/> #03 (224)END marker 62 (flags=0x02, v2.8.60.0) testfs 'srpc.flavor.default' Fri Nov 11 12:57:59 2016-<br/> #04 (224)marker 63 (flags=0x01, v2.8.60.0) testfs 'srpc.flavor.tcp' Fri Nov 11 13:50:03 2016-<br/> #05 (096)sptlrpc_conf 0:testfs 1:srpc.flavor.tcp=ska <br/> #06 (224)END marker 63 (flags=0x02, v2.8.60.0) testfs 'srpc.flavor.tcp' Fri Nov 11 13:50:03 2016-</p> LU-8829

'default' Secure RPC rule display issue

Bug Minor Resolved Fixed John Hammond Nathan Lavender Fri, 11 Nov 2016 19:24:40 +0000 Thu, 17 Nov 2016 08:13:36 +0000 Thu, 17 Nov 2016 08:13:36 +0000 Lustre 2.9.0 Lustre 2.9.0 0 4 <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>ommit 907a321c9b9e2cd5f5ccf488cc516ba05dee0ad8 Author: Dmitry Eremin &lt;dmitry.eremin@intel.com&gt; Date: Thu Dec 25 15:12:02 2014 +0300 LU-6070 libcfs: provide separate buffers for libcfs_*2str() Provide duplicates with separate buffers for libcfs_*2str() functions. Replace libcfs_nid2str() with libcfs_nid2str_r() function in critical places. Provide buffer size for nf_addr2str functions. Use __u32 as nf_type always Signed-off-by: Dmitry Eremin &lt;dmitry.eremin@intel.com&gt; Change-Id: I7505271954745d1b1e288ef4e09a7f52bd970536 Reviewed-on: http://review.whamcloud.com/13185 Tested-by: Jenkins Reviewed-by: John L. Hammond &lt;john.hammond@intel.com&gt; Tested-by: Maloo &lt;hpdd-maloo@intel.com&gt; Reviewed-by: Andreas Dilger &lt;andreas.dilger@intel.com&gt; diff --git a/lustre/mgs/lproc_mgs.c b/lustre/mgs/lproc_mgs.c index 8ae52ea..2e4adf4 100644 --- a/lustre/mgs/lproc_mgs.c +++ b/lustre/mgs/lproc_mgs.c @@ -90,16 +90,14 @@ static void seq_show_srpc_rules(struct seq_file *seq, const char *tgtname, struct sptlrpc_rule *r; char dirbuf[10]; char flvrbuf[40]; - char *net; + char net[LNET_NIDSTR_SIZE] = "default"; int i; for (i = 0; i &lt; rset-&gt;srs_nrule; i++) { r = &amp;rset-&gt;srs_rules[i]; - if (r-&gt;sr_netid == LNET_NIDNET(LNET_NID_ANY)) - net = "default"; - else - net = libcfs_net2str(r-&gt;sr_netid); + if (r-&gt;sr_netid != LNET_NIDNET(LNET_NID_ANY)) + libcfs_net2str_r(r-&gt;sr_netid, net, sizeof(net)); if (r-&gt;sr_from == LUSTRE_SP_ANY &amp;&amp; r-&gt;sr_to == LUSTRE_SP_ANY) dirbuf[0] = '\0'; </pre> </div></div> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23756" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23756</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8829" title="&#39;default&#39; Secure RPC rule display issue" class="issue-link" data-issue-key="LU-8829"><del>LU-8829</del></a> mgs: fix default secure RPC rule display<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e811fa9733e7127da1d1ae4d2d9babea3b8677c4</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/23756/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23756/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8829" title="&#39;default&#39; Secure RPC rule display issue" class="issue-link" data-issue-key="LU-8829"><del>LU-8829</del></a> mgs: fix default secure RPC rule display<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 207245382e8b8713f42c013a114aa55d3208b65f</p> <p>Landed for 2.9</p> Development Rank 1|hzyvdr: Rank (Obsolete) 9223372036854775807 Severity