https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8832 Lustre <p>The virt-what command that is used in the function runnng_in_vm() in test-framework.sh only exists in RHEL, not in SLES. This makes the behavior of any test that uses this function unpredictable on anything but RHEL distros.</p> <p>The running_in_vm() function was added in <a href="http://review.whamcloud.com/20698" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20698</a>, part of the fix for <a href="https://jira.whamcloud.com/browse/LU-8248" title="sanity test_248: fast read was not 4 times faster" class="issue-link" data-issue-key="LU-8248"><del>LU-8248</del></a>.</p> LU-8832

no virt-what command in SLES

Bug Major Resolved Fixed James Nunez Bob Glossman Mon, 14 Nov 2016 23:52:41 +0000 Sun, 23 Apr 2017 03:10:56 +0000 Sat, 17 Dec 2016 14:24:36 +0000 Lustre 2.10.0 0 6 <p>The code should be able to handle the lack of "virt-what" by running dmidecode and finally just returning nothing:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">running_in_vm() { local virt=$(virt-what 2&gt; /dev/<span class="code-keyword">null</span>) [ $? -eq 0 ] &amp;&amp; [ -n <span class="code-quote">"$virt"</span> ] &amp;&amp; { echo $virt; <span class="code-keyword">return</span>; } virt=$(dmidecode -s system-product-name | awk <span class="code-quote">'{print $1}'</span>) <span class="code-keyword">case</span> $virt in VMware|KVM|VirtualBox|Parallels) echo ${virt,,} ;; *) ;; esac } </pre> </div></div> <p>What sort of error are you seeing?</p> <p>see <a href="https://jira.whamcloud.com/browse/LU-8831" title="sanity test_248: test-framework.sh: line 1003: ${virt,,}: bad substitution" class="issue-link" data-issue-key="LU-8831"><del>LU-8831</del></a> for an example of an error.</p> <p>another branch, not master, has a different instance of using virt-what but in that case it makes sure it really exists using 'which virt-what' before using it.</p> <p>Bob, could you please try the above sequence of commands manually to see what "virt" is, and what <tt>dmidecode</tt> returns. It may be that the problem is really that the ${virt,,} expansion (which converts the string to lower case) is not working in the SLES version of bash. We know that the $virt string is not empty since it has to match one of the guest machine names to even be run.</p> <p>Andreas,<br/> It appears you are correct, the SLES version of bash doesn't know about the ,, expansion.<br/> Here are the manual commands:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>sles11sp4gm:/home/bogl/lustre-release # virt=$(dmidecode -s system-product-name | awk '{print $1}') sles11sp4gm:/home/bogl/lustre-release # echo $virt VMware sles11sp4gm:/home/bogl/lustre-release # echo ${virt,,} bash: ${virt,,}: bad substitution </pre> </div></div> <p>Since it only matters if the string echo'ed by this function is empty or not, why not just echo $virt ?<br/> Who cares if it has some caps in it.</p> <p>if it absolutely needs conversion, I think this will work everywhere:</p> <p>echo $virt | tr '<span class="error">&#91;A-Z&#93;</span>' '<span class="error">&#91;a-z&#93;</span>'</p> <p>it looks like only the sles11 bash doesn't know about the ,, expansion. it does work fine in sles12.</p> <p>fwiw, it works as expected in all versions of el6 and el7 I can find and try.</p> <p>Assigning to James for the test update</p> <p>Bob - Do you have a patch for this or should I create one?</p> <p>James, I have no patch. The simplest patch would be to just change echo ${virt,,} to echo $virt.</p> <p>I would propose 'echo $virt | tr '<span class="error">&#91;A-Z&#93;</span>' '<span class="error">&#91;a-z&#93;</span>'' to avoid puzzles like 'VMWare', 'VMware', 'KVM', 'kvm'</p> <p>fine, I won't argue. if the favored solution is to continue to translate to all lower case I'm ok with that. It just seems unnecessary.</p> <p>I was going to suggest the same thing as Jinshan, to keep the output constant. Even if we don't need to know the VM details today, it may help in the future. </p> <p>Sorry if this would introduce extra work on your side. I proposed that way because dmidecode and virt-what can produce different results.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[root@centos7 tests]# dmidecode -s system-product-name |awk '{print $1}' VMware [root@centos7 tests]# virt-what vmware </pre> </div></div> <p>James Nunez (james.a.nunez@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23774" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23774</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8832" title="no virt-what command in SLES" class="issue-link" data-issue-key="LU-8832"><del>LU-8832</del></a> tests: Generalize check of virtual machine<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8ef7cc5073ba246b0700bdf9ce5c108ae104a12a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/23774/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/23774/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8832" title="no virt-what command in SLES" class="issue-link" data-issue-key="LU-8832"><del>LU-8832</del></a> tests: Generalize check of virtual machine<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: fb4e9d58e387af627e3599ddaa2ae553d078b6e1</p> <p>Landed for 2.10</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/25660" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25660</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8832" title="no virt-what command in SLES" class="issue-link" data-issue-key="LU-8832"><del>LU-8832</del></a> tests: fix module loading for Parallels<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: fb06483bf3a6dbeabd569997704723010104073a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/25660/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25660/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8832" title="no virt-what command in SLES" class="issue-link" data-issue-key="LU-8832"><del>LU-8832</del></a> tests: fix module loading for Parallels<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: c49c8b146fdb45ef621fbba288758611c6d35cf3</p> Duplicate LU-8831 Development Rank 1|hzyvmf: Rank (Obsolete) 9223372036854775807 Severity