https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8846 Lustre <p><tt>lfs_migrate()</tt> bypasses <tt>llapi_create_volatile_idx()</tt> and creates a volatile file directly. (It does this because it needs to create the volatile file with a specific striping and <tt>llapi_create_volatile_idx()</tt> does not allow us to pass in striping.) It should do as <tt>llapi_create_volatile_idx()</tt> does and try to unlink the volatile file after opening it (in case volatile file creation is not supported).</p> <p>Or we could add <tt>O_LOV_DELAY_CREATE</tt> to the open flags and use <tt>llapi_create_volatile_idx()</tt> but then we would need a function to apply the striping described by a <tt>struct llapi_stripe_param</tt> to an open file handle.</p> LU-8846

lfs_migrate() should try to unlink volatile file

Bug Minor Resolved Fixed John Hammond John Hammond lfs Thu, 17 Nov 2016 15:08:40 +0000 Sat, 17 Dec 2016 15:19:56 +0000 Sat, 17 Dec 2016 15:19:56 +0000 Lustre 2.10.0 0 5 <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/23842" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/23842</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8846" title="lfs_migrate() should try to unlink volatile file" class="issue-link" data-issue-key="LU-8846"><del>LU-8846</del></a> lfs: try to unlink volatile file in lfs_migrate()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 222f9b93d7675a53d0b3d5d5e047ffb9f3f50dca</p> <p>I'm curious, what is the situation where volatile files are not supported and we're doing lfs migrate? </p> <p>Robert, I think John is saying that it isn't possible to specify the file layout when creating a volatile file, so that it can't be used when restriping a file during migration. </p> <p>I'm thinking it makes sense to create a new API to allow specifying the layout for a volatile file. Probably passing O_LOV_DELAY_CREATE and setting the layout explicitly (within the same llapi_create_volatile_layout() function) would be most straight forward. </p> <p>I don't think the current patch is wrong, however, since it shouldn't leave files around if the volatile file create API isn't available. </p> <p>The existing API already allows passing O_LOV_DELAY_CREATE), and the copytool uses this so it can set striping on the volatile file. </p> <p>But my question was based on the patch comment: "In lfs_migrate() try to unlink the volatile file in case the MDT does not support volatile file creation."</p> <p>It's also totally conceivable that upstream reviewers will notice volatile file handling and decide that it's a security issue or something.</p> <p>Ah, that's a good point. </p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/23842/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/23842/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8846" title="lfs_migrate() should try to unlink volatile file" class="issue-link" data-issue-key="LU-8846"><del>LU-8846</del></a> lfs: try to unlink volatile file in lfs_migrate()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d15fbc4fd9fbf5b892ea4320771ad40963bfdc69</p> <p>Landed for 2.10</p> Related LU-8559 Development Rank 1|hzyvz3: Rank (Obsolete) 9223372036854775807 Severity