https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-888 Lustre <p>If <tt>lctl get_param &lt;param&gt;</tt> has a file named <tt>&lt;param&gt;</tt> in the current working directory, it returns that instead of the expected values.</p> <p>To reproduce:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"># /usr/lib64/lustre/tests/llmount.sh # cd /tmp # lctl get_param version version= lustre: 2.1.51 kernel: patchless_client build: 2.1.51-ga83a510-CHANGED-2.6.32-131.6.1.el6_lustre.g65156ed.x86_64 # echo <span class="code-quote">"All your Lustre are belong to us"</span> &gt; ./version # lctl get_param version = All your Lustre are belong to us # </pre> </div></div> LU-888

lctl get_param easily confused

Bug Minor Resolved Fixed Richard Henwood Richard Henwood Fri, 2 Dec 2011 13:11:57 +0000 Wed, 4 Jan 2012 15:50:05 +0000 Wed, 4 Jan 2012 15:41:59 +0000 Lustre 2.1.0 Lustre 1.8.6 Lustre 2.2.0 0 3 <p>The code appears to first check if a file called <tt>&lt;param&gt;</tt> is present and can open <tt>0_RDONLY</tt>. If a file is not present, the code falls back to look for <tt>/proc/{fs,sys}/{lnet,lustre}/&lt;param&gt;</tt>.</p> <p>I suggest to fix the issue of <tt>get_param</tt> being easily confused, the path <tt>/proc/{fs,sys}/{lnet,lustre}/&lt;param&gt;</tt> should be checked first.</p> <p>John identified a more sinister potential issue with the behavior of <tt>get_param</tt>. One can unwittingly corrupt a local file if it has the same name as the <tt>&lt;param&gt;</tt>:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"># lctl set_param version=<span class="code-quote">"All your Nyancat'"</span> # lctl get_param version = All your Nyancat're belong to us </pre> </div></div> <p>A better fix for this perilous behavior is to not have <tt>lctl {get|set}_param</tt> lookup the local path at all.</p> <p>Good catch. </p> <p>If anyone is going to do more than trivial changes to get_param, it would be good to move it into an llapi_get_param() helper that can be used in other parts of the code. In quite a number of places in lctl, lfs, mount.lustre, erx. </p> <p>Trivial <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/help_16.png" height="16" width="16" align="absmiddle" alt="" border="0"/> change available for review at:</p> <p><a href="http://review.whamcloud.com/#change,1765" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,1765</a></p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=ofa/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,ofa #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/doc/lctl.8</li> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/tests/sanity.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el6,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el6,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/tests/sanity.sh</li> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/doc/lctl.8</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/tests/sanity.sh</li> <li>lustre/doc/lctl.8</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=sles11,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,sles11,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/tests/sanity.sh</li> <li>lustre/doc/lctl.8</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el6,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el6,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/doc/lctl.8</li> <li>lustre/tests/sanity.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/tests/sanity.sh</li> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/doc/lctl.8</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=ofa/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,ofa #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/tests/sanity.sh</li> <li>lustre/doc/lctl.8</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/doc/lctl.8</li> <li>lustre/tests/sanity.sh</li> <li>lustre/utils/lustre_cfg.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el6,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/tests/sanity.sh</li> <li>lustre/doc/lctl.8</li> <li>lustre/utils/lustre_cfg.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el6,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/tests/sanity.sh</li> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/doc/lctl.8</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=ofa/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,ofa #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/doc/lctl.8</li> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/tests/sanity.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/tests/sanity.sh</li> <li>lustre/doc/lctl.8</li> <li>lustre/utils/lustre_cfg.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,inkernel #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/utils/lustre_cfg.c</li> <li>lustre/tests/sanity.sh</li> <li>lustre/doc/lctl.8</li> </ul> <p>I believe this is still an open issue with 1.8.x</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=ofa/404/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,ofa #404</a><br/> <a href="https://jira.whamcloud.com/browse/LU-888" title="lctl get_param easily confused" class="issue-link" data-issue-key="LU-888"><del>LU-888</del></a> lctl: remove perilous lctl </p> {get,set,list} <p>_param behavior. (Revision 51ed079112c9a9eeac37eaf680637a4d04dd3cc9)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=51ed079112c9a9eeac37eaf680637a4d04dd3cc9" class="external-link" target="_blank" rel="nofollow noopener">51ed079112c9a9eeac37eaf680637a4d04dd3cc9</a><br/> Files : </p> <ul> <li>lustre/tests/sanity.sh</li> <li>lustre/doc/lctl.8</li> <li>lustre/utils/lustre_cfg.c</li> </ul> Development Rank 1|hzv7pb: Rank (Obsolete) 4782 Severity