https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8945 Lustre <p>Currently a user land utility req-layout does evil things like include layout.c from the ptlrpc layout into its user land source file. This ends up pull lots of unnecessary kernel code into user land as well as libcfs kernel headers. If we really need the req-layout tool this it would be better to export the data via debugfs. The question also is this utility really needed anymore. The other option is to delete req-layout.c</p> LU-8945

Stop building ptlrpc/layout.c in userland

Improvement Minor Resolved Fixed James A Simmons James A Simmons Thu, 15 Dec 2016 22:06:32 +0000 Wed, 18 Jan 2017 19:29:21 +0000 Wed, 18 Jan 2017 19:29:21 +0000 Lustre 2.10.0 Lustre 2.10.0 0 5 <p>While <tt>req_layout</tt> appears to be somewhat interesting (I didn't know this existed) I don't think anyone is actually using it. We would be far better off to do this kind of structure decoding in wireshark, and this utility can almost certainly be removed.</p> <p>PS: it wouldn't be terrible to run it once and post the output in a comment here for posterity, since this might be useful for anyone looking at RPC structures.</p> <p>True, wireshark is a much better solution. Here is a sample of the output, otherwise it is too long.</p> <p>L OBD_PING (1/1)<br/> FC 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) <br/> -----------------------------------<br/> FS 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) </p> <p>L OBD_SET_INFO (3/1)<br/> FC 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) <br/> FC 1 <span class="error">&#91;184&#93;</span> setinfo_key (var) <br/> FC 2 <span class="error">&#91;184 + ...&#93;</span> setinfo_val (var) <br/> -----------------------------------<br/> FS 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) </p> <p>L OBD_IDX_READ (2/2)<br/> FC 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) <br/> FC 1 <span class="error">&#91;184&#93;</span> idx_info (080) <br/> -----------------------------------<br/> FS 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) <br/> FS 1 <span class="error">&#91;184&#93;</span> idx_info (080) </p> <p>L SEC_CTX (1/1)<br/> FC 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) <br/> -----------------------------------<br/> FS 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) </p> <p>L MGS_TARGET_REG (2/2)<br/> FC 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) <br/> FC 1 <span class="error">&#91;184&#93;</span> mgs_target_info (4544) <br/> -----------------------------------<br/> FS 0 <span class="error">&#91;000&#93;</span> ptlrpc_body (184) <br/> FS 1 <span class="error">&#91;184&#93;</span> mgs_target_info (4544) </p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/24396" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24396</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8945" title="Stop building ptlrpc/layout.c in userland" class="issue-link" data-issue-key="LU-8945"><del>LU-8945</del></a> ptlrpc : remove userland usage from ptlrpc<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f2eb7f40c489344e43c4a15b93f53cc89b239953</p> <p>This cleanup is one of the last blockers of completely removing the libcfs headers from userland.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/24396/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24396/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8945" title="Stop building ptlrpc/layout.c in userland" class="issue-link" data-issue-key="LU-8945"><del>LU-8945</del></a> ptlrpc : remove userland usage from ptlrpc<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: fb403f8b5f8ba61fe0da28e7f7c5e01776717750</p> <p>Landed for 2.10</p> Related LU-6401 Development Rank 1|hzyykn: Rank (Obsolete) 9223372036854775807