https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8969 Lustre <p>This issue was created by maloo for Bob Glossman &lt;bob.glossman@intel.com&gt;</p> <p>This issue relates to the following test suite run: <a href="https://testing.hpdd.intel.com/test_sets/3f9ace90-c8ca-11e6-8911-5254006e85c2" class="external-link" target="_blank" rel="nofollow noopener">https://testing.hpdd.intel.com/test_sets/3f9ace90-c8ca-11e6-8911-5254006e85c2</a>.</p> <p>The sub-test test_56x failed with the following error:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>migrate failed rc = 22 </pre> </div></div> <p>fails in the same test as previous bug <a href="https://jira.whamcloud.com/browse/LU-8559" title="sanity test_56xa: cannot swap layouts: Operation not permitted" class="issue-link" data-issue-key="LU-8559"><del>LU-8559</del></a>, but different errors.</p> <p>Info required for matching: sanity 56x</p> LU-8969

sanity test_56x: read failed: Invalid argument

Bug Minor Resolved Fixed Yang Sheng Maloo Fri, 23 Dec 2016 15:21:33 +0000 Tue, 28 Mar 2017 18:46:23 +0000 Mon, 9 Jan 2017 13:07:51 +0000 Lustre 2.10.0 0 4 <p>another on master, sles12sp2:<br/> <a href="https://testing.hpdd.intel.com/test_sets/ef072448-cbed-11e6-8580-5254006e85c2" class="external-link" target="_blank" rel="nofollow noopener">https://testing.hpdd.intel.com/test_sets/ef072448-cbed-11e6-8580-5254006e85c2</a></p> <p>have discovered by trial and error that eliminating the use of O_DIRECT in lfs.c makes this problem go away. not entirely sure why.</p> <p>This appears to be due to a difference in arg checking in linux 4.4 vs. earlier linux versions. I constructed a simple test program that just opens an existing file with O_DIRECT and reads through it 1MB at a time. This is similar to migrate_copy_data().</p> <p>On earlier versions of linux the read returns 0 on the read at EOF as expected regardless of the length of the file.</p> <p>On linux 4.4, the sles12sp2 kernel version, it returns 0 on the read at EOF only if the file length is a multiple of page_size. If it isn't then the read fails, returning -1 with an errno of EINVAL. This is true of all fs types, not just lustre.</p> <p>I strongly suspect that in linux 4.4 the kernel does more careful and complete checking of the read args for O_DIRECT reads and returns EINVAL on an EOF read when EOF isn't a page_size boundary. This makes sense since such a read violates the requirements of O_DIRECT I/O that enforces restrictions on the file offsets of I/O. I speculate that in earlier linux'es the checking for EOF on reads was done before the checking of args, and in linux 4.4 the checking on args is done first. Again, I emphasize this difference in behavior is seen on all fs types, not just lustre. This is strong evidence that it isn't primarily a lustre bug but due to the I/O logic in the underlying kernel.</p> <p>This being the case it makes sense that turning off O_DIRECT makes the problem go away. The only question is if that solution is permissible in the lfs_migrate() code.</p> <p>I have seen this failure for some time in my upstream client testing. I always assumed it was some faulty port. Thanks for tracking this down.</p> <p>will push a patch turning off O_DIRECT. I expect reviewers will tell me if that's not allowed.</p> <p>Bob Glossman (bob.glossman@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/24549" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24549</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8969" title="sanity test_56x: read failed: Invalid argument" class="issue-link" data-issue-key="LU-8969"><del>LU-8969</del></a> utils: avoid use of O_DIRECT in lfs_migrate<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 95843e1f6d8f46a2e305cbfdcb19dc0bfb3d5ca6</p> <p>Yang Sheng (yang.sheng@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/24552" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24552</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8969" title="sanity test_56x: read failed: Invalid argument" class="issue-link" data-issue-key="LU-8969"><del>LU-8969</del></a> llite: sanity test_56x read failed: Invalid argument<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 23c9778cc006ea75cd2f01d7baa4561c4d5219a7</p> <p>Are both patches needed?</p> <p>No. My patch is Abandoned. Only <a href="https://review.whamcloud.com/24552" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24552</a> is needed.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/24552/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24552/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8969" title="sanity test_56x: read failed: Invalid argument" class="issue-link" data-issue-key="LU-8969"><del>LU-8969</del></a> llite: sanity test_56x read failed: Invalid argument<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2730656aa4d4326e67615e9652c576545403ed15</p> <p>Patch landed. Close this ticket.</p> Related Development Rank 1|hzyz7r: Rank (Obsolete) 9223372036854775807 Severity