https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9053 Lustre <p>right now it's pretty random. Sometimes the APIs return <tt>-errno</tt>, sometimes they set <tt>errno</tt> and return -1.</p> <p>Typical examples are <tt>llapi_fswap_layouts_grouplock()</tt> and <tt>llapi_layout_get_by_fd()</tt>. I would say the funnier one is <tt>llapi_open_by_fid()</tt> where <tt>llapi_search_mounts()</tt> return error code but <tt>llapi_open_by_fid()</tt> itself returns -1 as if the <tt>errno</tt> has been set.</p> LU-9053

standardize error code returned by lustreapi

Improvement Minor Closed Fixed WC Triage Jinshan Xiong Thu, 26 Jan 2017 00:32:58 +0000 Tue, 31 Jan 2017 05:54:21 +0000 Tue, 31 Jan 2017 05:54:15 +0000 0 3 <p>There was a long discussion about this in <a href="https://jira.whamcloud.com/browse/LU-3840" title="llapi_layout API design discussion" class="issue-link" data-issue-key="LU-3840"><del>LU-3840</del></a>. The proposal there was to set <tt>errno</tt> and return -1 to the caller for <tt>llapi_layout_&#42;</tt> functions, but this doesn't help with existing functions that return <tt>-errno</tt>.</p> <p>My thought is that it makes sense to update existing functions to both return <tt>-errno</tt> and also set <tt>errno</tt> internally. Callers can then either check <tt>rc &lt; 0</tt> and access <tt>errno</tt>, or continue to use the return code directly. This gives is a path to move toward a single style of error returns.</p> <p>Hi Andreas, Which way do you prefer for the new APIs?</p> <p>The newer llapi_layout code is using -1 and errno. </p> Development Rank 1|hzz1rj: Rank (Obsolete) 9223372036854775807