https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9118 Lustre <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">+ make -j4 -s Making all in . In file included from /tmp/rpmbuild-lustre-jenkins-2HDIMGOt/BUILD/lustre-2.9.52_82_gb2d45e0/libcfs/include/libcfs/linux/libcfs.h:85:0, from /tmp/rpmbuild-lustre-jenkins-2HDIMGOt/BUILD/lustre-2.9.52_82_gb2d45e0/libcfs/include/libcfs/libcfs.h:37, from /tmp/rpmbuild-lustre-jenkins-2HDIMGOt/BUILD/lustre-2.9.52_82_gb2d45e0/lnet/klnds/o2iblnd/o2iblnd.h:77, from /tmp/rpmbuild-lustre-jenkins-2HDIMGOt/BUILD/lustre-2.9.52_82_gb2d45e0/lnet/klnds/o2iblnd/o2iblnd.c:38: /tmp/rpmbuild-lustre-jenkins-2HDIMGOt/BUILD/lustre-2.9.52_82_gb2d45e0/libcfs/include/libcfs/linux/linux-time.h:149:19: error: redefinition of <span class="code-quote">'ktime_get_real_ns'</span> <span class="code-keyword">static</span> inline u64 ktime_get_real_ns(void) ^ In file included from /<span class="code-keyword">var</span>/lib/jenkins/workspace/lustre-reviews-ib/arch/x86_64/build_type/client/distro/sles12/ib_stack/mlx/BUILD/mlnx-ofa_kernel-devel/usr/src/ofa_kernel/<span class="code-keyword">default</span>/include/linux/compat-2.6.h:82:0, from &lt;command-line&gt;:0: /<span class="code-keyword">var</span>/lib/jenkins/workspace/lustre-reviews-ib/arch/x86_64/build_type/client/distro/sles12/ib_stack/mlx/BUILD/mlnx-ofa_kernel-devel/usr/src/ofa_kernel/<span class="code-keyword">default</span>/include/linux/compat-3.17.h:12:19: note: previous definition of <span class="code-quote">'ktime_get_real_ns'</span> was here <span class="code-keyword">static</span> inline u64 ktime_get_real_ns(void) { ^ </pre> </div></div> LU-9118

Failed to build MOFED 3.4-1.0.0

Bug Minor Resolved Fixed James A Simmons Minh Diep Fri, 10 Feb 2017 22:14:58 +0000 Thu, 2 Mar 2017 15:28:29 +0000 Thu, 2 Mar 2017 13:11:26 +0000 Lustre 2.10.0 Lustre 2.10.0 0 5 <p>Oh no we are colliding again with compact from MLX.</p> <p>MInh can you try patch <a href="https://review.whamcloud.com/#/c/24919/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/24919</a> with MLX OFED as well. I like to see the amount of conflict with the remaining 64 bit time work.</p> <p>James, we still hit the same error. I guess your changed is after this error</p> <p>I just wanted to see if ktime_get_ns() is the only problem.</p> <p>you need to fix ktime_get_real_ns first <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>I'm installing a MOFED 4 stack on our system. Will push something soon.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/25564" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25564</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9118" title="Failed to build MOFED 3.4-1.0.0" class="issue-link" data-issue-key="LU-9118"><del>LU-9118</del></a> o2iblnd: handle MOFED libcfs time api collision<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 25f64d4aeb292d42ccafbd8568476df4f32b9e7c</p> <p>I hesitate to give this a +review. I can see the proposed solution works when building without MOFED. Can't see evidence of it working building with MOFED.</p> <p>James, have you tested build with MOFED on both el6 and el7 to cover both cases of finding and not finding ktime_get_real_ns in the kernel?</p> <p>I tested it on MOFED 4 + RHEL7.3 but then I went to my Power8 RHEL7.2 + MOFED 3.3 which didn't work. I also have a Cray system with OFED 3.12 + SLES11SP3. The man problem is both MOFED and libcfs are setting HAVE_KTIME_GET_REAL_NS <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/> So I need to rethink it.</p> <p>Yes, I confirmed that it failed in el6.8 too</p> <p> </p> <p>Okay I figured out a solution. So both OFED and libcfs was setting HAVE_KTIME_GET_REAL_NS. So I inverted the logic of detection in libcfs, now NEED_KTIME_GET_REAL_NS and unset it in o2iblnd.h.  The logic is in the commit. Try the latest patch. Tested on RHEL7.2 + MOFED 3.3 and RHEL7.3 + MOFED 4.0 and SLES11SP3 + OFED12</p> <p>It looks this also affect the Open OFED 3.18-3.</p> <p>Does my patch help you Dmitry</p> <p>James, I didn't reproduce this locally yet. I just got an issue report from our customer. I'm going to reproduce this and check this patch soon.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">In file included from /<span class="code-keyword">var</span>/lib/jenkins/workspace/lustre-reviews-ib/arch/x86_64/build_type/client/distro/el7/ib_stack/ofa/BUILD/BUILD/compat-rdma-3.18/include/linux/compat-2.6.h:75:0, from &lt;command-line&gt;:1: /<span class="code-keyword">var</span>/lib/jenkins/workspace/lustre-reviews-ib/arch/x86_64/build_type/client/distro/el7/ib_stack/ofa/BUILD/BUILD/compat-rdma-3.18/include/linux/compat-3.16.h:25:59: error: redefinition of <span class="code-quote">'ktime_get_ns'</span> <span class="code-keyword">static</span> inline u64 ktime_get_ns(void) ^ In file included from include/linux/ktime.h:442:0, from include/linux/timer.h:5, from include/linux/workqueue.h:8, from include/linux/pm.h:25, </pre> </div></div> <p>I don't think we can verify on OFED 3.18-3 because OFED also broken on el7 with similar/same error</p> <p>The complains was following:</p> <p>For centos 7 kernel 3.10.0-514. OFED 3.18-3 installation fails during compilation.</p> <ol> <li>uname -a<br/> <b>Linux x 3.10.0-514.el7_lustre.x86_64 #1 SMP Wed Dec 7 15:50:02 PST 2016 x86_64 x86_64 x86_64 GNU/Linux</b> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>In file included from /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-2.6.h:75:0, from &lt;command-line&gt;:0: /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-3.16.h:25:19: error: redefinition of ‘ktime_get_ns’ static inline u64 ktime_get_ns(void) ^ In file included from /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-2.6.h:75:0, from &lt;command-line&gt;:0: /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-3.16.h:25:19: error: redefinition of ‘ktime_get_ns’ static inline u64 ktime_get_ns(void) ^ In file included from /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-2.6.h:75:0, from &lt;command-line&gt;:0: /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-3.16.h:25:19: error: redefinition of ‘ktime_get_ns’ static inline u64 ktime_get_ns(void) ^ In file included from include/linux/ktime.h:442:0, from include/linux/timer.h:5, from include/linux/workqueue.h:8, from include/linux/pm.h:25, from ./arch/x86/include/asm/apic.h:5, from ./arch/x86/include/asm/smp.h:12, from include/linux/smp.h:43, from include/linux/percpu.h:6, from /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/percpu.h:6, from include/linux/percpu-rwsem.h:6, from include/linux/fs.h:28, from /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-3.5.h:5, from /var/tmp/OFED_topdir/BUILD/compat-rdma-3.18/include/linux/compat-2.6.h:64, from &lt;command-line&gt;:0: include/linux/timekeeping.h:170:19: note: previous definition of ‘ktime_get_ns’ was here static inline u64 ktime_get_ns(void) </pre> </div></div></li> </ol> <p>I miss this is not related to Lustre code.But it have the same issue. So, the patch can be the same but for OFED-3.18-3. <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>I just looked at the OFED-3.18 source and compat-3.16.h unconditionally create ktime_get_ns(). I can't turn off the collision like I did for ktime_get_real_ns(). Their is nothing I can do <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p> </p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/25564/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25564/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9118" title="Failed to build MOFED 3.4-1.0.0" class="issue-link" data-issue-key="LU-9118"><del>LU-9118</del></a> o2iblnd: handle MOFED libcfs time api collision<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f548d1a00eaf705607b0c1eac254c95e3905f5b2</p> <p>MOFED 3.4 support is restored.</p> <p>Landed in Lustre 2.10</p> Blocker Related Development Rank 1|hzz3j3: Rank (Obsolete) 9223372036854775807 Severity