https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9128 Lustre <p>There's a fair amount of OBD_OCD_VERSION-ed out code in lustre/utils/ and elsewhere which can be removed or made unconditional:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>x:lustre-release# git grep 'OBD_OCD_VERSION(2, [0-9],' lustre/llite/dir.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 50, 0) lustre/ofd/ofd_dev.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 8, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &gt;= OBD_OCD_VERSION(2, 6, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &gt;= OBD_OCD_VERSION(2, 6, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &gt;= OBD_OCD_VERSION(2, 6, 53, 0) lustre/utils/lfs.c:#endif /* LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) */ lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD _VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &gt;= OBD_OCD_VERSION(2, 6, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &gt;= OBD_OCD_VERSION(2, 6, 53, 0) lustre/utils/lfs.c:#endif /* LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) */ lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/lfs.c:#if LUSTRE_VERSION_CODE &gt;= OBD_OCD_VERSION(2, 6, 53, 0) lustre/utils/liblustreapi.c:#if LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 9, 53, 0) lustre/utils/liblustreapi_util.c:#if LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 8, 53, 0) </pre> </div></div> LU-9128

remove OBD_OCD_VERSION-ed out code

Bug Minor Resolved Fixed WC Triage John Hammond Wed, 15 Feb 2017 16:22:51 +0000 Mon, 27 Sep 2021 18:22:27 +0000 Mon, 27 Sep 2021 18:22:27 +0000 0 6 <p>I was pondering if lustre_ver.h really needs to be exposed to user land the other day. It can't be guaranteed that the tools will be running against a lustre kernel version it was built again.</p> <p>&gt; It can't be guaranteed that the tools will be running against a lustre kernel version it was built again.</p> <p>I agree but when it comes to utilities the version is (mostly) not being used in that way (i.e. to manage ABI compatibility). Instead it's being used to manage deprecation and removal of the utility features, options, etc.</p> <p>Hi Steve,</p> <p>Can you please have a look at this one?</p> <p>Thanks.<br/> Joe</p> <p>I'll add this to my queue.</p> <p>As of today, Lustre 2.10.58+ still has the following version checks for version 2.x with x &lt;=11:</p> <p>lustre/ofd/ofd_dev.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 8, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">1779 out_nolock: 1780 <span class="code-keyword">if</span> (rc == 0) { 1781 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 8, 53, 0) 1782 struct ofd_thread_info *info = ofd_info(tsi-&gt;tsi_env); 1783 struct lu_fid *fid = &amp;info-&gt;fti_fid; 1784 1785 /* For compatible purpose, it needs to convert back to 1786 * OST ID before put it on wire. */ 1787 *fid = rep_oa-&gt;o_oi.oi_fid; 1788 fid_to_ostid(fid, &amp;rep_oa-&gt;o_oi); 1789 #endif 1790 rep_oa-&gt;o_valid |= OBD_MD_FLID | OBD_MD_FLGROUP; 1791 } </pre> </div></div> <p>lustre/utils/liblustreapi_util.c:#if LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 8, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 160 <span class="code-object">int</span> llapi_get_version(<span class="code-object">char</span> *buffer, <span class="code-object">int</span> buffer_size, <span class="code-object">char</span> **version) 161 { 162 <span class="code-object">int</span> rc; 163 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 8, 53, 0) 164 <span class="code-keyword">static</span> bool printed; 165 <span class="code-keyword">if</span> (!printed) { 166 fprintf(stderr, 167 <span class="code-quote">"%s deprecated, use llapi_get_version_string()\n"</span>, 168 __func__); 169 printed = <span class="code-keyword">true</span>; 170 } 171 #endif 172 </pre> </div></div> <p>lustre/llite/dir.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 50, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">1260 1261 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 50, 0) 1262 mode = data-&gt;ioc_type != 0 ? data-&gt;ioc_type : S_IRWXUGO; 1263 #<span class="code-keyword">else</span> 1264 mode = data-&gt;ioc_type; 1265 #endif 1266 rc = ll_dir_setdirstripe(dentry, lum, lumlen, filename, mode); </pre> </div></div> <p>lustre/utils/liblustreapi.c:#if LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 9, 59, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">4395 <span class="code-object">int</span> llapi_mv(<span class="code-object">char</span> *path, struct find_param *param) 4396 { 4397 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 9, 59, 0) 4398 <span class="code-keyword">static</span> bool printed; 4399 4400 <span class="code-keyword">if</span> (!printed) { 4401 llapi_error(LLAPI_MSG_ERROR, -ESTALE, 4402 <span class="code-quote">"llapi_mv() is deprecated, use llapi_migrate_mdt()\n"</span>); 4403 printed = <span class="code-keyword">true</span>; 4404 } 4405 #endif 4406 <span class="code-keyword">return</span> llapi_migrate_mdt(path, param); 4407 } </pre> </div></div> <p>lustre/utils/mount_lustre.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 10, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 61 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 10, 53, 0) 62 /* 63 * LU-1783 64 * We only #include a kernel level include file here because 65 * important MS_ flag #defines are missing from the SLES version 66 * of sys/mount.h 67 * In the <span class="code-keyword">future</span> <span class="code-keyword">if</span> SLES updates sys/mount.h to have a more complete 68 * set of flag #defines we should stop including linux/fs.h 69 */ 70 #<span class="code-keyword">if</span> !defined(MS_RDONLY) 71 #include &lt;linux/fs.h&gt; 72 #endif 73 #endif </pre> </div></div> <p>lustre/include/uapi/linux/lustre/lustre_idl.h:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 11, 56, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">2106 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 11, 56, 0) 2107 /* Since lustre 2.8, <span class="code-keyword">this</span> flag will not be needed, instead <span class="code-keyword">this</span> DEAD 2108 * and orphan flags will be stored in LMA (see LMAI_ORPHAN) 2109 * Keep <span class="code-keyword">this</span> flag just <span class="code-keyword">for</span> LFSCK, because it still might meet such 2110 * flag when it checks the old FS */ 2111 #define LMV_HASH_FLAG_DEAD 0x40000000 2112 #endif </pre> </div></div> <p>Update: As of November 1, 2019, here are all the conditional code based on Lustre version up to 2.14.50:</p> <p>lustre/ofd/ofd_dev.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 8, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 1726 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 8, 53, 0) 1727 struct ofd_thread_info *info = ofd_info(tsi-&gt;tsi_env); 1728 struct lu_fid *fid = &amp;info-&gt;fti_fid; 1729 1730 /* For compatible purpose, it needs to convert back to 1731 * OST ID before put it on wire. */ 1732 *fid = rep_oa-&gt;o_oi.oi_fid; 1733 fid_to_ostid(fid, &amp;rep_oa-&gt;o_oi); 1734 #endif </pre> </div></div> <p>lustre/utils/liblustreapi_util.c:#if LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 8, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 164 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 8, 53, 0) 165 <span class="code-keyword">static</span> bool printed; 166 <span class="code-keyword">if</span> (!printed) { 167 fprintf(stderr, 168 <span class="code-quote">"%s deprecated, use llapi_get_version_string()\n"</span>, 169 __func__); 170 printed = <span class="code-keyword">true</span>; 171 } 172 #endif </pre> </div></div> <p>lustre/llite/dir.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 50, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 1427 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 9, 50, 0) 1428 mode = data-&gt;ioc_type != 0 ? data-&gt;ioc_type : S_IRWXUGO; 1429 #<span class="code-keyword">else</span> 1430 mode = data-&gt;ioc_type; 1431 #endif </pre> </div></div> <p>lustre/utils/liblustreapi.c:#if LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 9, 59, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 5076 <span class="code-object">int</span> llapi_mv(<span class="code-object">char</span> *path, struct find_param *param) 5077 { 5078 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &gt; OBD_OCD_VERSION(2, 9, 59, 0) 5079 <span class="code-keyword">static</span> bool printed; 5080 5081 <span class="code-keyword">if</span> (!printed) { 5082 llapi_error(LLAPI_MSG_ERROR, -ESTALE, 5083 <span class="code-quote">"llapi_mv() is deprecated, use llapi_migrate_mdt()\n"</span>); 5084 printed = <span class="code-keyword">true</span>; 5085 } 5086 #endif 5087 <span class="code-keyword">return</span> llapi_migrate_mdt(path, param); 5088 } </pre> </div></div> <p>lustre/utils/mount_lustre.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 10, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 61 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 10, 53, 0) 62 /* 63 * LU-1783 64 * We only #include a kernel level include file here because 65 * important MS_ flag #defines are missing from the SLES version 66 * of sys/mount.h 67 * In the <span class="code-keyword">future</span> <span class="code-keyword">if</span> SLES updates sys/mount.h to have a more complete 68 * set of flag #defines we should stop including linux/fs.h 69 */ 70 #<span class="code-keyword">if</span> !defined(MS_RDONLY) 71 #include &lt;linux/fs.h&gt; 72 #endif 73 #endif </pre> </div></div> <p>lustre/llite/llite_lib.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 12, 50, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 464 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 12, 50, 0) 465 data-&gt;ocd_connect_flags |= OBD_CONNECT_LOCKAHEAD_OLD; 466 #endif </pre> </div></div> <p>lustre/llite/dir.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 414 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 415 <span class="code-keyword">static</span> <span class="code-object">int</span> ll_send_mgc_param(struct obd_export *mgc, <span class="code-object">char</span> *string) 416 { 417 struct mgs_send_param *msp; 418 <span class="code-object">int</span> rc = 0; 419 420 OBD_ALLOC_PTR(msp); 421 <span class="code-keyword">if</span> (!msp) 422 <span class="code-keyword">return</span> -ENOMEM; 423 424 strlcpy(msp-&gt;mgs_param, string, sizeof(msp-&gt;mgs_param)); 425 rc = obd_set_info_async(NULL, mgc, sizeof(KEY_SET_INFO), KEY_SET_INFO, 426 sizeof(struct mgs_send_param), msp, NULL); 427 <span class="code-keyword">if</span> (rc) 428 CERROR(<span class="code-quote">"Failed to set parameter: %d\n"</span>, rc); 429 OBD_FREE_PTR(msp); 430 431 <span class="code-keyword">return</span> rc; 432 } 433 #endif </pre> </div></div> <p>lustre/llite/dir.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 561 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 562 struct lustre_sb_info *lsi = s2lsi(inode-&gt;i_sb); 563 struct obd_device *mgc = lsi-&gt;lsi_mgc; 564 #endif </pre> </div></div> <p>lustre/llite/dir.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 626 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 627 /* 628 * 2.9 server has stored filesystem <span class="code-keyword">default</span> stripe in ROOT xattr, 629 * and it's stored into system config <span class="code-keyword">for</span> backward compatibility. 630 * 631 * In the following we use the fact that LOV_USER_MAGIC_V1 and 632 * LOV_USER_MAGIC_V3 have the same initial fields so we <span class="code-keyword">do</span> not 633 * need the make the distiction between the 2 versions 634 */ 635 <span class="code-keyword">if</span> (set_default &amp;&amp; mgc-&gt;u.cli.cl_mgc_mgsexp &amp;&amp; 636 (lump == NULL || 637 le32_to_cpu(lump-&gt;lmm_magic) == LOV_USER_MAGIC_V1 || 638 le32_to_cpu(lump-&gt;lmm_magic) == LOV_USER_MAGIC_V3)) { 639 <span class="code-object">char</span> *param = NULL; 640 <span class="code-object">char</span> *buf; 641 642 OBD_ALLOC(param, MGS_PARAM_MAXLEN); 643 <span class="code-keyword">if</span> (param == NULL) 644 GOTO(end, rc = -ENOMEM); 645 646 buf = param; 647 <span class="code-comment">/* Get fsname and assume devname to be -MDT0000. */</span> 648 snprintf(buf, MGS_PARAM_MAXLEN, <span class="code-quote">"%s-MDT0000.lov"</span>, 649 sbi-&gt;ll_fsname); 650 buf += strlen(buf); 651 652 <span class="code-comment">/* Set root stripesize */</span> 653 snprintf(buf, MGS_PARAM_MAXLEN, <span class="code-quote">".stripesize=%u"</span>, 654 lump ? le32_to_cpu(lump-&gt;lmm_stripe_size) : 0); 655 rc = ll_send_mgc_param(mgc-&gt;u.cli.cl_mgc_mgsexp, param); 656 <span class="code-keyword">if</span> (rc) 657 GOTO(end, rc); 658 659 <span class="code-comment">/* Set root stripecount */</span> 660 snprintf(buf, MGS_PARAM_MAXLEN, <span class="code-quote">".stripecount=%hd"</span>, 661 lump ? le16_to_cpu(lump-&gt;lmm_stripe_count) : 0); 662 rc = ll_send_mgc_param(mgc-&gt;u.cli.cl_mgc_mgsexp, param); 663 <span class="code-keyword">if</span> (rc) 664 GOTO(end, rc); 665 666 <span class="code-comment">/* Set root stripeoffset */</span> 667 snprintf(buf, MGS_PARAM_MAXLEN, <span class="code-quote">".stripeoffset=%hd"</span>, 668 lump ? le16_to_cpu(lump-&gt;lmm_stripe_offset) : 669 (typeof(lump-&gt;lmm_stripe_offset))(-1)); 670 rc = ll_send_mgc_param(mgc-&gt;u.cli.cl_mgc_mgsexp, param); 671 672 end: 673 <span class="code-keyword">if</span> (param != NULL) 674 OBD_FREE(param, MGS_PARAM_MAXLEN); 675 } 676 #endif </pre> </div></div> <p>lustre/mgc/mgc_request.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 1067 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 1068 <span class="code-comment">/* Send parameter to MGS*/</span> 1069 <span class="code-keyword">static</span> <span class="code-object">int</span> mgc_set_mgs_param(struct obd_export *exp, 1070 struct mgs_send_param *msp) 1071 { 1072 struct ptlrpc_request *req; 1073 struct mgs_send_param *req_msp, *rep_msp; 1074 <span class="code-object">int</span> rc; 1075 ENTRY; 1076 1077 req = ptlrpc_request_alloc_pack(class_exp2cliimp(exp), 1078 &amp;RQF_MGS_SET_INFO, LUSTRE_MGS_VERSION, 1079 MGS_SET_INFO); 1080 <span class="code-keyword">if</span> (!req) 1081 RETURN(-ENOMEM); 1082 1083 req_msp = req_capsule_client_get(&amp;req-&gt;rq_pill, &amp;RMF_MGS_SEND_PARAM); 1084 <span class="code-keyword">if</span> (!req_msp) { 1085 ptlrpc_req_finished(req); 1086 RETURN(-ENOMEM); 1087 } 1088 1089 memcpy(req_msp, msp, sizeof(*req_msp)); 1090 ptlrpc_request_set_replen(req); 1091 1092 <span class="code-comment">/* Limit how <span class="code-object">long</span> we will wait <span class="code-keyword">for</span> the enqueue to complete */</span> 1093 req-&gt;rq_delay_limit = MGC_SEND_PARAM_LIMIT; 1094 rc = ptlrpc_queue_wait(req); 1095 <span class="code-keyword">if</span> (!rc) { 1096 rep_msp = req_capsule_server_get(&amp;req-&gt;rq_pill, &amp;RMF_MGS_SEND_PARAM); 1097 memcpy(msp, rep_msp, sizeof(*rep_msp)); 1098 } 1099 1100 ptlrpc_req_finished(req); 1101 1102 RETURN(rc); 1103 } 1104 #endif </pre> </div></div> <p>lustre/mgc/mgc_request.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 1280 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 1281 <span class="code-keyword">if</span> (KEY_IS(KEY_SET_INFO)) { 1282 struct mgs_send_param *msp; 1283 1284 msp = (struct mgs_send_param *)val; 1285 rc = mgc_set_mgs_param(exp, msp); 1286 RETURN(rc); 1287 } 1288 #endif </pre> </div></div> <p>lustre/mgs/mgs_handler.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 99 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 100 <span class="code-keyword">static</span> <span class="code-object">int</span> mgs_set_info(struct tgt_session_info *tsi) 101 { 102 struct mgs_thread_info *mgi; 103 struct mgs_send_param *msp, *rep_msp; 104 struct lustre_cfg *lcfg; 105 size_t param_len; 106 <span class="code-object">char</span> *s; 107 <span class="code-object">int</span> rc; 108 109 ENTRY; 110 111 mgi = mgs_env_info(tsi-&gt;tsi_env); 112 <span class="code-keyword">if</span> (IS_ERR(mgi)) 113 RETURN(err_serious(PTR_ERR(mgi))); 114 115 msp = req_capsule_client_get(tsi-&gt;tsi_pill, &amp;RMF_MGS_SEND_PARAM); 116 <span class="code-keyword">if</span> (msp == NULL) 117 RETURN(err_serious(-EFAULT)); 118 119 param_len = strnlen(msp-&gt;mgs_param, sizeof(msp-&gt;mgs_param)); 120 <span class="code-keyword">if</span> (param_len == 0 || param_len == sizeof(msp-&gt;mgs_param)) 121 RETURN(-EINVAL); 122 123 <span class="code-comment">/* We only allow <span class="code-quote">'*.lov.stripe{size,count,offset}=*'</span> from an RPC. */</span> 124 s = strchr(msp-&gt;mgs_param, <span class="code-quote">'.'</span>); 125 <span class="code-keyword">if</span> (s == NULL) 126 RETURN(-EINVAL); 127 128 <span class="code-keyword">if</span> (!str_starts_with(s + 1, <span class="code-quote">"lov.stripesize="</span>) &amp;&amp; 129 !str_starts_with(s + 1, <span class="code-quote">"lov.stripecount="</span>) &amp;&amp; 130 !str_starts_with(s + 1, <span class="code-quote">"lov.stripeoffset="</span>)) 131 RETURN(-EINVAL); 132 133 <span class="code-comment">/* Construct lustre_cfg structure to pass to function mgs_set_param */</span> 134 lustre_cfg_bufs_reset(&amp;mgi-&gt;mgi_bufs, NULL); 135 lustre_cfg_bufs_set_string(&amp;mgi-&gt;mgi_bufs, 1, msp-&gt;mgs_param); 136 OBD_ALLOC(lcfg, lustre_cfg_len(mgi-&gt;mgi_bufs.lcfg_bufcount, 137 mgi-&gt;mgi_bufs.lcfg_buflen)); 138 <span class="code-keyword">if</span> (!lcfg) 139 RETURN(-ENOMEM); 140 lustre_cfg_init(lcfg, LCFG_PARAM, &amp;mgi-&gt;mgi_bufs); 141 142 rc = mgs_set_param(tsi-&gt;tsi_env, exp2mgs_dev(tsi-&gt;tsi_exp), lcfg); 143 <span class="code-keyword">if</span> (rc) { 144 LCONSOLE_WARN(<span class="code-quote">"%s: Unable to set parameter %s: %d\n"</span>, 145 tgt_name(tsi-&gt;tsi_tgt), msp-&gt;mgs_param, rc); 146 GOTO(out_cfg, rc); 147 } 148 149 <span class="code-comment">/* send back the whole msp in the reply */</span> 150 rep_msp = req_capsule_server_get(tsi-&gt;tsi_pill, &amp;RMF_MGS_SEND_PARAM); 151 *rep_msp = *msp; 152 EXIT; 153 out_cfg: 154 OBD_FREE(lcfg, lustre_cfg_len(lcfg-&gt;lcfg_bufcount, lcfg-&gt;lcfg_buflens)); 155 <span class="code-keyword">return</span> rc; 156 } 157 #endif </pre> </div></div> <p>lustre/mgs/mgs_handler.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 1205 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 1206 TGT_MGS_HDL(HAS_REPLY | IS_MUTABLE, MGS_SET_INFO, mgs_set_info), 1207 #endif 1208 TGT_MGS_HDL(HAS_REPLY | IS_MUTABLE, MGS_TARGET_REG, mgs_target_reg), </pre> </div></div> <p>lustre/ptlrpc/layout.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 74 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 75 <span class="code-keyword">static</span> <span class="code-keyword">const</span> struct req_msg_field *mgs_set_info[] = { 76 &amp;RMF_PTLRPC_BODY, 77 &amp;RMF_MGS_SEND_PARAM 78 }; 79 #endif </pre> </div></div> <p>lustre/ptlrpc/layout.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 760 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 761 &amp;RQF_MGS_SET_INFO, 762 #endif </pre> </div></div> <p>lustre/ptlrpc/layout.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 905 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 906 struct req_msg_field RMF_MGS_SEND_PARAM = 907 DEFINE_MSGF(<span class="code-quote">"mgs_send_param"</span>, 0, 908 sizeof(struct mgs_send_param), 909 NULL, NULL); 910 EXPORT_SYMBOL(RMF_MGS_SEND_PARAM); 911 #endif </pre> </div></div> <p>lustre/ptlrpc/layout.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 1350 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 1351 struct req_format RQF_MGS_SET_INFO = 1352 DEFINE_REQ_FMT0(<span class="code-quote">"MGS_SET_INFO"</span>, mgs_set_info, 1353 mgs_set_info); 1354 EXPORT_SYMBOL(RQF_MGS_SET_INFO); 1355 #endif </pre> </div></div> <p>lustre/utils/wirecheck.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 1613 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 1614 <span class="code-keyword">static</span> void 1615 check_mgs_send_param(void) 1616 { 1617 BLANK_LINE(); 1618 CHECK_STRUCT(mgs_send_param); 1619 CHECK_CVALUE(MGS_PARAM_MAXLEN); 1620 CHECK_MEMBER(mgs_send_param, mgs_param[MGS_PARAM_MAXLEN]); 1621 } 1622 #endif </pre> </div></div> <p>lustre/utils/wirecheck.c:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 2896 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 2897 check_mgs_send_param(); 2898 #endif </pre> </div></div> <p>lustre/include/uapi/linux/lustre/lustre_idl.h:#if LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 2560 #<span class="code-keyword">if</span> LUSTRE_VERSION_CODE &lt; OBD_OCD_VERSION(2, 13, 53, 0) 2561 #define MGS_PARAM_MAXLEN 1024 2562 #define KEY_SET_INFO <span class="code-quote">"set_info"</span> 2563 2564 struct mgs_send_param { 2565 <span class="code-object">char</span> mgs_param[MGS_PARAM_MAXLEN]; 2566 }; 2567 #endif </pre> </div></div> <p>The 2.13.53 conditionals have been removed in patch <a href="https://review.whamcloud.com/38106" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38106</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-8454" title="non-root user is able to change stripe size for mount point" class="issue-link" data-issue-key="LU-8454"><del>LU-8454</del></a> Remove struct mgs_send_param and its users</tt>" and the ones for the older versions are removed in patch <a href="https://review.whamcloud.com/38109" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38109</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-6179" title="Lock ahead - Request extent locks from userspace" class="issue-link" data-issue-key="LU-6179"><del>LU-6179</del></a> llite: remove LOCKAHEAD_OLD compatibility</tt>" .</p> Related LU-9123 LU-9125 LU-6401 LU-6202 Development Rank 1|hzz3xr: Rank (Obsolete) 9223372036854775807 Severity