https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9152 Lustre <p>Found 2 new static analysis issues in v2_9_53_0-27-gf913720:</p> <ol> <li><b>Null pointer may be passed to function that may dereference it</b> <ul> <li><tt>lustre/mgc/mgc_request.c</tt>: in <em>config_log_add</em>, Null pointer 'sptlrpc&#95;cld' that comes from line 315 may be passed to function and can be dereferenced there by passing argument 1 to function 'config&#95;log&#95;put' at line 419.</li> </ul> </li> <li><b>Null pointer may be passed to function that may dereference it</b> <ul> <li><tt>lustre/mgc/mgc_request.c</tt>: in <em>config_log_add</em>, Null pointer 'params&#95;cld' that comes from line 316 may be passed to function and can be dereferenced there by passing argument 1 to function 'config&#95;log&#95;put' at line 413.</li> </ul> </li> </ol> <p>The list of commits since the previous build v2_9_52_0-74-gc39d13d:</p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=f913720c7e09f9e829bbd6bea49e0f4cb9b4e6c5" class="external-link" target="_blank" rel="nofollow noopener">f913720</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8773" title="fiemap extent uses u64 type, not loff_t type" class="issue-link" data-issue-key="LU-8773"><del>LU-8773</del></a> llite: refactor lov_object_fiemap()</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8d27681c98b2e702b2d3ea7fc603e21c444f7590" class="external-link" target="_blank" rel="nofollow noopener">8d27681</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8767" title="Improve proc file text in lproc_llite.c" class="issue-link" data-issue-key="LU-8767"><del>LU-8767</del></a> llite: Improve proc file text in lproc_llite.c</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=db999716eee2ca09f7569d71cd960857ad5af0a7" class="external-link" target="_blank" rel="nofollow noopener">db99971</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9100" title="lctl network down shouldn&#39;t error with &quot;LNET unconfigure error 19&quot;" class="issue-link" data-issue-key="LU-9100"><del>LU-9100</del></a> lnet: lctl net down success when lnet not loaded</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=40fe3cd7283dfd1cee5f989483c517601ac773f8" class="external-link" target="_blank" rel="nofollow noopener">40fe3cd</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8703" title="rework CPU partition code" class="issue-link" data-issue-key="LU-8703"><del>LU-8703</del></a> libcfs: remove usless abstraction</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=ad8f66967d66238539700081d555ebc08e43cead" class="external-link" target="_blank" rel="nofollow noopener">ad8f669</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8888" title="Remove unused clt_current_io from struct cl_thread_info" class="issue-link" data-issue-key="LU-8888"><del>LU-8888</del></a> clio: remove unused members from struct cl_thread_info</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c152f7b0c84cab95e55fb0ba19d0b6bdeefd6e12" class="external-link" target="_blank" rel="nofollow noopener">c152f7b</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7670" title="Return errors from changelog_clear and changelog_deregister" class="issue-link" data-issue-key="LU-7670"><del>LU-7670</del></a> mdt: allow changelog commands to return errors</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=1f58cac8e4a7f5196ceab2a411bd11d152de27e4" class="external-link" target="_blank" rel="nofollow noopener">1f58cac</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9019" title="Migrate lustre to standard 64 bit time kernel API" class="issue-link" data-issue-key="LU-9019"><del>LU-9019</del></a> mdt: use 64-bit timestamps for rename stats</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=6e67953c438a9b0e2667dc5407f8556d181ffaab" class="external-link" target="_blank" rel="nofollow noopener">6e67953</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8560" title="Support for linux 4.6 kernels" class="issue-link" data-issue-key="LU-8560"><del>LU-8560</del></a> build: announce linux kernel 4.6.7 support</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=dad9ce41f34812a71a542ed2c86be5be746510a7" class="external-link" target="_blank" rel="nofollow noopener">dad9ce4</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9125" title="replay-single test_68: @@@@@@ FAIL: 2nd cp failed 1" class="issue-link" data-issue-key="LU-9125"><del>LU-9125</del></a> test: Correct setstripe -s option</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=2b16d2d81eafc3e6c7349f486225998be85b2362" class="external-link" target="_blank" rel="nofollow noopener">2b16d2d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9123" title="sanity test 27D fails with &#39;llapi_layout_test failed&#39; " class="issue-link" data-issue-key="LU-9123"><del>LU-9123</del></a> test: correct setstripe options in layout test</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=603aa7a1df6ee6ce6fe0d501a8b2bd1bfdf43bb8" class="external-link" target="_blank" rel="nofollow noopener">603aa7a</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9094" title="OOM caused by huge number of peers in case of INVALID_SERVICE_ID" class="issue-link" data-issue-key="LU-9094"><del>LU-9094</del></a> o2iblnd: reconnect peer for REJ_INVALID_SERVICE_ID</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=81e010d101a667b2bc22c2caddeefd40f02a3d19" class="external-link" target="_blank" rel="nofollow noopener">81e010d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9115" title="Remove special handling on MULTIMODRPCS flag" class="issue-link" data-issue-key="LU-9115"><del>LU-9115</del></a> llite: buggy special handling on MULTIMODRPCS</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=540fcd21849788d02ddef89ecdf1492e6eff23e2" class="external-link" target="_blank" rel="nofollow noopener">540fcd2</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4423" title="Tracking of patches from upstream kernel to Lustre client" class="issue-link" data-issue-key="LU-4423"><del>LU-4423</del></a> mdc: use 64-bit timestamps for mdc</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=19f057cc120cb59fde06cfe18b2472ec9962eddd" class="external-link" target="_blank" rel="nofollow noopener">19f057c</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9101" title="kernel update [SLES11 SP4 3.0.101-94]" class="issue-link" data-issue-key="LU-9101"><del>LU-9101</del></a> kernel: kernel update <span class="error">&#91;SLES11 SP4 3.0.101-94&#93;</span></td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=adf08bdb841d776b385396fe176b2383ea0f250d" class="external-link" target="_blank" rel="nofollow noopener">adf08bd</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8066" title="Move lustre procfs handling to sysfs and debugfs." class="issue-link" data-issue-key="LU-8066">LU-8066</a> ldlm: move server side /proc/fs/lustre/ldlm to sysfs</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9d13d286c72cb67617a8159faf515efd0f7a9aa8" class="external-link" target="_blank" rel="nofollow noopener">9d13d28</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8947" title="sanity test_253: @@@@@@ FAIL: test_253 failed with 2" class="issue-link" data-issue-key="LU-8947"><del>LU-8947</del></a> test: fix getting OST name at sanity test_253</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a1c8e27ca38de157c2ce4ecf3f21392a079ac1a0" class="external-link" target="_blank" rel="nofollow noopener">a1c8e27</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9125" title="replay-single test_68: @@@@@@ FAIL: 2nd cp failed 1" class="issue-link" data-issue-key="LU-9125"><del>LU-9125</del></a> utils: Postpone deprecation of some options.</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=57ba9deb978a8335e0dde04baf6281e8b9ab23f8" class="external-link" target="_blank" rel="nofollow noopener">57ba9de</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9081" title="Don&#39;t attach other logs when processing client log for LWP" class="issue-link" data-issue-key="LU-9081"><del>LU-9081</del></a> config: don't attach sub logs for LWP</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=723f40030aa289f0b44d9394cc2e15a4d1772600" class="external-link" target="_blank" rel="nofollow noopener">723f400</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-5170" title="lfs usability" class="issue-link" data-issue-key="LU-5170">LU-5170</a> utils: Add support for --list-commands option</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=70e9d4ecc9130aeed1260d78cd8b33a5cde6edd7" class="external-link" target="_blank" rel="nofollow noopener">70e9d4e</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6210" title="change positional struct initializers to C99 initializers" class="issue-link" data-issue-key="LU-6210"><del>LU-6210</del></a> utils: Change positional struct initializers to C99</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e4761eb1f4d564f111be66a61ac84f9f9be97fc2" class="external-link" target="_blank" rel="nofollow noopener">e4761eb</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6499" title="leaking a kernel device on error in init_obdclass" class="issue-link" data-issue-key="LU-6499"><del>LU-6499</del></a> obdclass: obdclass module cleanup upon load error</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=3dc5a9fed1cc45dc0df4f5986dc96662f4dd6abe" class="external-link" target="_blank" rel="nofollow noopener">3dc5a9f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8550" title="problems of conf-sanity test_32 " class="issue-link" data-issue-key="LU-8550"><del>LU-8550</del></a> test: fix problems of conf-sanity test_32</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=d89191163324200d1f57a095faef1253c7d9fe11" class="external-link" target="_blank" rel="nofollow noopener">d891911</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-5969" title="Create an LGPL version of liblustreapi" class="issue-link" data-issue-key="LU-5969">LU-5969</a> lustreapi: allow "version" without "lustre:"</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=eecf886f2491af99af66ebde2ef9793f060cf2ff" class="external-link" target="_blank" rel="nofollow noopener">eecf886</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9059" title="mount.lustre FATAL: unhandled/unloaded fs type 0 &#39;ext3&#39;" class="issue-link" data-issue-key="LU-9059"><del>LU-9059</del></a> utils: skip label check for client</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=04794b33653fedca282d6f8dfd9c1c9e833ead06" class="external-link" target="_blank" rel="nofollow noopener">04794b3</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8526" title="replay-single test_90: @@@@@@ FAIL: wrong stripe: all, uuid: lustre-OST0000_UUID" class="issue-link" data-issue-key="LU-8526"><del>LU-8526</del></a> tests: ensure all OSTs active for allocations</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=05ad99f1f3a9f85756bf3355505722bb4f20f420" class="external-link" target="_blank" rel="nofollow noopener">05ad99f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6142" title="Enforce Linux kernel coding style in all code" class="issue-link" data-issue-key="LU-6142">LU-6142</a> lnet: remove most of typedefs from LNet headers</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=1e42682aeadb0f80dd6e9bfd45abe17221b698bf" class="external-link" target="_blank" rel="nofollow noopener">1e42682</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9040" title="Soft lockup on CPU during lfsck" class="issue-link" data-issue-key="LU-9040"><del>LU-9040</del></a> scrub: handle group boundary properly</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a4bbf4124c5cc29c62d1b74a113bf9b458d34cbe" class="external-link" target="_blank" rel="nofollow noopener">a4bbf41</a></td> <td class='confluenceTd'>New tag 2.9.53</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=f03c8b1bb6ed317464257472e408b6fb6094fc61" class="external-link" target="_blank" rel="nofollow noopener">f03c8b1</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9032" title="syntax error in sanity.sh in cleanup_test32_mount" class="issue-link" data-issue-key="LU-9032"><del>LU-9032</del></a> tests: syntax error in cleanup_test32_mount</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=3403364783e895252c57d36b532a685a48268149" class="external-link" target="_blank" rel="nofollow noopener">3403364</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8843" title="comparison between signed and unsigned integer expressions" class="issue-link" data-issue-key="LU-8843"><del>LU-8843</del></a> client: fix all less than 0 comparison for unsigned values</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9ab8061abc989be519482888e64e90ebecb228c9" class="external-link" target="_blank" rel="nofollow noopener">9ab8061</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9078" title="Fix router hops print" class="issue-link" data-issue-key="LU-9078"><del>LU-9078</del></a> lnet: Fix route hops print</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=cfa981f3bf06d602aee998e64d4758e13f48aab8" class="external-link" target="_blank" rel="nofollow noopener">cfa981f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8974" title="Сhange force_over_256tb lustre mount option to force_over_512tb for ldiskfs" class="issue-link" data-issue-key="LU-8974"><del>LU-8974</del></a> osd-ldiskfs: increase supported ldiskfs fs size</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=d2c403363f65337166dc745b58d0a4529a534b84" class="external-link" target="_blank" rel="nofollow noopener">d2c4033</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-5620" title="nrs tbf policy based on opcode" class="issue-link" data-issue-key="LU-5620"><del>LU-5620</del></a> ptlrpc: Add QoS for opcode in NRS-TBF</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=74d0cf95c147ac8dc5a1ace9387b92711e5a6a68" class="external-link" target="_blank" rel="nofollow noopener">74d0cf9</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9019" title="Migrate lustre to standard 64 bit time kernel API" class="issue-link" data-issue-key="LU-9019"><del>LU-9019</del></a> osd: migrate osd-ldiskfs thandle stats to 64 bit time</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=ad0a085d95f80fa16a0c96fddd03577d499ab903" class="external-link" target="_blank" rel="nofollow noopener">ad0a085</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8702" title="Performance test parallel execution" class="issue-link" data-issue-key="LU-8702"><del>LU-8702</del></a> tests: parallel execution of IOR and MDTEST added.</td> </tr> </tbody></table> </div> LU-9152

New static analysis issues in v2_9_53_0-27-gf913720

Bug Minor Resolved Fixed Steve Guminski Dmitry Eremin kw Fri, 24 Feb 2017 07:14:43 +0000 Wed, 30 Aug 2023 21:39:37 +0000 Fri, 28 Apr 2017 21:03:02 +0000 Lustre 2.10.0 Lustre 2.10.0 0 4 <p>Hi Steve,</p> <p>Would you be able to pick up this one?</p> <p>Thanks.<br/> Joe</p> <p>I'm currently working another ticket, but I'll add this to my queue and pick it up as soon as I can.</p> <p>Steve Guminski (stephenx.guminski@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/25854" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25854</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9152" title="New static analysis issues in v2_9_53_0-27-gf913720" class="issue-link" data-issue-key="LU-9152"><del>LU-9152</del></a> mgc: Fix NULL pointers found by static analysis<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 19adeee562eef6a028a163c719b41adb6d249cc4</p> <p>Changeset 24262 merged on March 9 included a check in config_log_put() for a NULL parameter.  Can this ticket be closed without any further code changes now that config_log_put() cannot dereference a NULL pointer?</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/25854/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25854/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9152" title="New static analysis issues in v2_9_53_0-27-gf913720" class="issue-link" data-issue-key="LU-9152"><del>LU-9152</del></a> mgc: Remove unnecessary checks for config_log_put()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ffde9ae4784fdb045eae8438aa0c179db6172232</p> <p>Landed for 2.10</p> Related LU-4629 Development Rank 1|hzz4tj: Rank (Obsolete) 9223372036854775807 Severity