https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9325 Lustre <p>While pushing work upstream some of the feedback was related to how Lustre does its own direct parsing of string which is frowned on. Secondly we are still not using newer kernel string interfaces like kstrtoul instead of simple_string() and other examples exist as well that have been merged upstream.</p> LU-9325

Improve lustre kernel string handling

Improvement Minor In Progress Unresolved James A Simmons James A Simmons patch Wed, 12 Apr 2017 17:56:47 +0000 Tue, 12 Sep 2023 21:55:53 +0000 Lustre 2.10.0 Upstream 0 4 <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/26558" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/26558</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obdclass: handle strings correctly in lmd_find_delimiter<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 26c43bcffb6a06d791813bf634341c1a29be3a89</p> <p>James is working on this</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/30539/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30539/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obd: replace lprocfs_str_to_s64<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 860e20e42ddc45bf5521cbd5f53d35a310b34ded</p> <p>Landed for 2.11</p> <p>Whoops still another patch to come</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32217" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32217</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> libcfs: replace simple_strtoul with kstrtouint<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 200e60f1f76a24d75513d102866c8b6c4839bef1</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32322" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32322</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> libcfs: Convert cfs_trace_daemon_command to use kstrtoul<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: cfd07f26a52b6d72f7a6320fede3966905d9f5b1</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/26558/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/26558/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obdclass: handle strings correctly in lmd_find_delimiter<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 25aed16fe4d33c3ce09a4135774173e7adba3943</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/32217/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32217/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> libcfs: handle complex strings in cfs_str2num_check<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5728fb3009f5f797d1ff68e5ad6de341850c35d4</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/32322/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32322/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> libcfs: Convert cfs_trace_daemon_command to use kstrtoul<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: cfd07f26a52b6d72f7a6320fede3966905d9f5b1</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32594" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32594</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> ptlrpc: replace simple_strtol with kstrtol<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ec619b812ea13f6f0ffe763a2363634be235c8fe</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32598" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32598</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> llog: replace simple_strtol with kstrtol<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c99eda99d72103f5f012e9c8744dba651f34b77d</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32785" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32785</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> ptlrpc: replace simple_strtol with kstrtol<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 800d04bd0ec6cd82be7cc8edbd9df7b45e4a7de5</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32598/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32598/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> llog: replace simple_strtol with kstrtol<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 62a19d61419453048dc595b8ba2cf77c06a9755f</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32785/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32785/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> ptlrpc: replace simple_strtol with kstrtol<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 8f37d64b6bc9111ff20ffb0bd22daf8fb9c8c159</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/33385" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33385</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> libcfs: don't stomp on module string for cfs_str2num_check<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d9f60a170dd8f7786b52b8f09bfe04218c374cbe</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/33617" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33617</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obdclass: make niduuid for lustre_stop_mgc() static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: fdf3062c711fa27504be9029e03a4c84c9014ed5</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/33959" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33959</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> msg: replace obsolete simple_strtoul use<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f7ebdb6c5aa4a42e4a7ce4e1ec3daecdb1f86107</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/33959/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33959/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> msg: replace obsolete simple_strtoul use<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 30239b4aecbe80e14f65316defd9fe162426147a</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/36551" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36551</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> mds: replace simple_strtol use with target_name2index()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8625814aecc72beb592d6620b4382c007c119a04</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36551/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36551/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> mds: replace simple_strtol use with target_name2index()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7d37148e36854a293fdc40d7d771769f0a6b64e0</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/38846" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38846</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> mdt: replace simple_strtol() with kstrtol()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 201128895c982522dc78b9f6c98329e56a7cb5a1</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38846/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38846/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> mdt: replace simple_strtol() with kstrtol()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4115148e4ac5ccb3620a9f8d3e48da0a712943c5</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/39498" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39498</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> fld: replace simple_strto* with kstr* functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3feaa7d148d9b64e9d1fb9c4afef7f13f59f52d5</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39498/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39498/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> fld: replace simple_strto* with kstr* functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f875fa73f215c3e1f71656dd8aa0cd30d931fa09</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/40119" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40119</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> osd-ldisk: replace simple_strto* with kstr* functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8ddd1d616f35a9b9937631fa5e6d653d8e855886</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/40119/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40119/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> osd-ldisk: replace simple_strto* with kstr* functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e520b6a7fa6b6dd3f703dc8c6918a3699b3d9517</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/33617/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33617/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obdclass: make niduuid for lustre_stop_mgc() static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 85b400b67b0d8d49315f80252025c98303d242bb</p> <p>"jsimmons &lt;jsimmons@infradead.org&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49910" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49910</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obd: replace simple_strtoul()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6da5463b9e39c149c3c6717398dc93eb3cc57d0d</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49910/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49910/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obd: replace simple_strtoul()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 79b34a83f811f5f1dc40a077bd6d5f65194c9bbe</p> <p>Down to two patches.</p> <p>"James Simmons &lt;jsimmons@infradead.org&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51209" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51209</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9325" title="Improve lustre kernel string handling" class="issue-link" data-issue-key="LU-9325">LU-9325</a> obdclass: use match_table for server mount options<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 234816c141dcb499b50963f33ac6c05b9d5f79e8</p> Related LU-4423 LU-12861 LU-12511 Development Epic/Theme upstream Rank 1|hzz9zb: Rank (Obsolete) 9223372036854775807