Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-934] external xattr inode support in e2fsprogs https://jira.whamcloud.com/browse/LU-934 Lustre <p>The existing codes have the following issues:</p> <ul class="alternate" type="square"> <li>pass1.c check_ea_in_inode() compares e_value_size to fit in free space of inode, but for xattr in external inode this is wrong.</li> <li>e2fsck_lfsck_find_ea() have no code to copy EA from external inode.</li> </ul> LU-934 external xattr inode support in e2fsprogs Bug Minor Closed Fixed Jian Yu Jian Yu Fri, 16 Dec 2011 08:44:04 +0000 Mon, 16 Jan 2012 07:17:54 +0000 Mon, 16 Jan 2012 07:17:41 +0000 Lustre 2.2.0 Lustre 2.2.0 0 2 <p>Patch from Alexander Boyko is in the attachment.</p> <p>While applying the patch on the latest e2fsprogs/master-lustre branch, I got:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>patching file patches/e2fsprogs-large-ea.patch patching file patches/e2fsprogs-lfsck.patch patch: **** malformed patch at line 374: </pre> </div></div> <p>Alex, could you please fix the above issue and upload the updated patch to this ticket? I'd help submit the patch to Gerrit.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ git pull Already up-to-date. $ git apply external_inode.patch -v external_inode.patch:19: space before tab in indent. if (entry-&gt;e_value_offs &gt; storage_size || external_inode.patch:23: space before tab in indent. problem = PR_1_INODE_EA_BAD_VALUE; external_inode.patch:24: space before tab in indent. goto fix; external_inode.patch:25: space before tab in indent. } external_inode.patch:44: trailing whitespace. @@ -1654,6 +1778,7 @@ static int check_ext_attr(e2fsck_t ctx, Checking patch patches/e2fsprogs-large-ea.patch... Checking patch patches/e2fsprogs-lfsck.patch... Applied patch patches/e2fsprogs-large-ea.patch cleanly. Applied patch patches/e2fsprogs-lfsck.patch cleanly. warning: squelched 36 whitespace errors warning: 41 lines add whitespace errors. git log commit bc526c65d2a4cf0c6c04e9ed4837d6dd7dbbf2b3 Author: Theodore Ts'o &lt;tytso@mit.edu&gt; Date: Tue Jul 5 20:35:46 2011 -0400 libext2fs: fix 64-bit support in ext2fs_bmap2() Signed-off-by: "Theodore Ts'o" &lt;tytso@mit.edu&gt; </pre> </div></div> <p>Are you use git apply?</p> <p>The malformed patch is my fault. I was fixing the patch to use tabs instead of spaces for indenting. It should be easy enough to edit the patch to correct the line count for the malformed hunk. </p> <p>change spaces to tabs</p> <p>The patch is in: <a href="http://review.whamcloud.com/1886" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1886</a></p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ git apply external_inode.patch -v external_inode.patch:19: space before tab in indent. if (entry-&gt;e_value_offs &gt; storage_size || external_inode.patch:23: space before tab in indent. problem = PR_1_INODE_EA_BAD_VALUE; external_inode.patch:24: space before tab in indent. goto fix; external_inode.patch:25: space before tab in indent. } external_inode.patch:44: trailing whitespace. @@ -1654,6 +1778,7 @@ static int check_ext_attr(e2fsck_t ctx, Checking patch patches/e2fsprogs-large-ea.patch... Checking patch patches/e2fsprogs-lfsck.patch... Applied patch patches/e2fsprogs-large-ea.patch cleanly. Applied patch patches/e2fsprogs-lfsck.patch cleanly. warning: squelched 38 whitespace errors warning: 43 lines add whitespace errors. </pre> </div></div> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/e2fsprogs-master/./arch=x86_64,distro=el5/159/" class="external-link" target="_blank" rel="nofollow noopener">e2fsprogs-master » x86_64,el5 #159</a><br/> <a href="https://jira.whamcloud.com/browse/LU-934" title="external xattr inode support in e2fsprogs" class="issue-link" data-issue-key="LU-934"><del>LU-934</del></a> e2fsck: copy EA from external inode, fix size check (Revision f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd)</p> <p> Result = SUCCESS<br/> alexander_boyko : <a href="http://git.whamcloud.com/gitweb/?p=tools/e2fsprogs.git;a=commit;h=refs/heads/master-lustre&amp;a=commit&amp;h=f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd" class="external-link" target="_blank" rel="nofollow noopener">f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd</a><br/> Files : </p> <ul> <li>patches/e2fsprogs-lfsck.patch</li> <li>patches/e2fsprogs-large-ea.patch</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/e2fsprogs-master/./arch=x86_64,distro=el6/159/" class="external-link" target="_blank" rel="nofollow noopener">e2fsprogs-master » x86_64,el6 #159</a><br/> <a href="https://jira.whamcloud.com/browse/LU-934" title="external xattr inode support in e2fsprogs" class="issue-link" data-issue-key="LU-934"><del>LU-934</del></a> e2fsck: copy EA from external inode, fix size check (Revision f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd)</p> <p> Result = SUCCESS<br/> alexander_boyko : <a href="http://git.whamcloud.com/gitweb/?p=tools/e2fsprogs.git;a=commit;h=refs/heads/master-lustre&amp;a=commit&amp;h=f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd" class="external-link" target="_blank" rel="nofollow noopener">f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd</a><br/> Files : </p> <ul> <li>patches/e2fsprogs-large-ea.patch</li> <li>patches/e2fsprogs-lfsck.patch</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/e2fsprogs-master/./arch=i686,distro=el6/159/" class="external-link" target="_blank" rel="nofollow noopener">e2fsprogs-master » i686,el6 #159</a><br/> <a href="https://jira.whamcloud.com/browse/LU-934" title="external xattr inode support in e2fsprogs" class="issue-link" data-issue-key="LU-934"><del>LU-934</del></a> e2fsck: copy EA from external inode, fix size check (Revision f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd)</p> <p> Result = SUCCESS<br/> alexander_boyko : <a href="http://git.whamcloud.com/gitweb/?p=tools/e2fsprogs.git;a=commit;h=refs/heads/master-lustre&amp;a=commit&amp;h=f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd" class="external-link" target="_blank" rel="nofollow noopener">f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd</a><br/> Files : </p> <ul> <li>patches/e2fsprogs-large-ea.patch</li> <li>patches/e2fsprogs-lfsck.patch</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/e2fsprogs-master/./arch=i686,distro=el5/159/" class="external-link" target="_blank" rel="nofollow noopener">e2fsprogs-master » i686,el5 #159</a><br/> <a href="https://jira.whamcloud.com/browse/LU-934" title="external xattr inode support in e2fsprogs" class="issue-link" data-issue-key="LU-934"><del>LU-934</del></a> e2fsck: copy EA from external inode, fix size check (Revision f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd)</p> <p> Result = SUCCESS<br/> alexander_boyko : <a href="http://git.whamcloud.com/gitweb/?p=tools/e2fsprogs.git;a=commit;h=refs/heads/master-lustre&amp;a=commit&amp;h=f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd" class="external-link" target="_blank" rel="nofollow noopener">f8ba0de1d5d4fb670c3bb287e6d20d1ded8827dd</a><br/> Files : </p> <ul> <li>patches/e2fsprogs-lfsck.patch</li> <li>patches/e2fsprogs-large-ea.patch</li> </ul> <p>The patch has been pushed to e2fsprogs/master-lustre branch. The issue is resolved.</p> Development Rank 1|hzvhm7: Rank (Obsolete) 6503 Severity