https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9385 Lustre <p>Clients use the {{MDS_HSM_STATE_</p> {GET,SET} <p>}} RPCs to get and set the HSM state of a file and not the HSM xattr. Thus the MDT should not use MDS_INODELOCK_XATTR to protect updates to the HSM state. A local (preferably already existing) mutex or semaphore in the MDT object should be used instead.</p> LU-9385

mdt_add_dirty_flag() should not use MDS_INODELOCK_XATTR

Bug Minor Resolved Fixed John Hammond John Hammond Fri, 21 Apr 2017 16:06:56 +0000 Thu, 31 Aug 2017 17:51:31 +0000 Tue, 9 May 2017 04:19:51 +0000 Lustre 2.10.0 0 5 <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/26870" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/26870</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9385" title="mdt_add_dirty_flag() should not use MDS_INODELOCK_XATTR" class="issue-link" data-issue-key="LU-9385"><del>LU-9385</del></a> mdt: remove XATTR locking from mdt_add_dirty_flag()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 193dbfa42674074555606eae0f8b38981b025a6b</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/26870/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/26870/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9385" title="mdt_add_dirty_flag() should not use MDS_INODELOCK_XATTR" class="issue-link" data-issue-key="LU-9385"><del>LU-9385</del></a> mdt: remove XATTR locking from mdt_add_dirty_flag()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e5eec257c4daf9e2f538f13c7f7ff121acbc0195</p> <p>Landed for 2.10</p> <p>Note that <tt>mdt_add_dirty_flag()</tt> is called from the close path. As explained in <tt>mdc_close()</tt>:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /* To avoid a livelock (bug 7034), we need to send CLOSE RPCs to a * portal whose threads are not taking any DLM locks and are therefore * always progressing */ req-&gt;rq_request_portal = MDS_READPAGE_PORTAL; ptlrpc_at_set_req_timeout(req); </pre> </div></div> <p>And so this is another instance of <a href="https://bugzilla.lustre.org/show_bug.cgi?id=7034" class="external-link" target="_blank" rel="nofollow noopener">https://bugzilla.lustre.org/show_bug.cgi?id=7034</a>.</p> Duplicate Related Development Rank 1|hzzaxb: Rank (Obsolete) 9223372036854775807 Severity