[LU-9422] sanity test 234 is skipped incorrectly for attr rpm version number

Related — Thu, 25 Jan 2018 05:03:14 +0000

sanity test_234 is being skipped with the message

SKIP: sanity test_234 LU-3703: attr version getfattr 2.4.46 too old

Looking at the test code, the test is skipped due to the check

13747         # output of the form: attr 2 4 44 3 fc13 x86_64
13748         V=($(IFS=".-" rpm -q attr))
13749         if [[ ${V[1]} > 2 || ${V[2]} > 4 || ${V[3]} > 44 ||
13750               ${V[1]} = 2 && ${V[2]} = 4 && ${V[3]} = 44 && ${V[4]} > 6 ]]; then
13751                 # attr pre-2.4.44-7 had a bug with rc
13752                 # LU-3703 - SLES 11 and FC13 clients have older attr
13753                 getfattr -n user.attr $DIR/$tdir/$tfile &&
13754                         error "getfattr should have failed with ENOMEM"
13755         else
13756                 skip "LU-3703: attr version $(getfattr --version) too old"
13757         fi

From this description, this test should not be skipped with attr version 2.4.46. The problem is setting the Internal Field Separator (IFS) this way isn’t actually setting the correct values to split the string on.

This is easily fixed by setting the IFS outside the assignment/call to rpm, but is this check necessary any more?

Whamcloud Community JIRA

[LU-9422] sanity test 234 is skipped incorrectly for attr rpm version number