<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 02:26:44 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-9500] MOFED 4/mlx5: Aligning non-aligned page addresses trigger dump_cqe</title>
                <link>https://jira.whamcloud.com/browse/LU-9500</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;In Lustre, we allow the first fragment in an IOV-based message to be non-page aligned. &#160;When we set up the scatter/gather list we properly set the address and page_offset to reflect the non-page alignment. &#160;&lt;/p&gt;

&lt;p&gt;When we assign a remote address for RDMA purposes, the current code masks the address so it is page aligned. &#160;When the page aligned address does not match the address in the scatter/gather list, the mlx5 driver under MOFED 4 is rejecting the IB_RDMA_WRITE operation by doing a &quot;dump_cqe&quot; error message.&lt;/p&gt;

&lt;p&gt;That is the main problem to be fixed. &#160;However, the code which was doing the masking for page alignment is wrong. &#160;Here is the line of code in the routine kiblnd_fmr_map_tx() which is doing the masking incorrectly:&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;rd-&amp;gt;rd_frags[0].rf_addr &amp;amp;= ~hdev-&amp;gt;ibh_page_mask;

&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;The &quot;~&quot; should not be there. We were setting the rf_addr to the page offset. When pages are aligned, rf_addr becomes zero and that is the remote_addr value we send to the other node. The fact that this works and does not break things sort of implies that the MOFED code is not using the remote_addr field of a IB_RDMA_WRITE work request.&lt;/p&gt;

&lt;p&gt;In any case, we need to fix this in case some day some code does actually pay attention to this field.&lt;/p&gt;

&lt;p&gt;The question to be answered here: should the remote address we generate be page aligned or not. When I stopped page aligning it, the dump_cqe error stopped and everything worked just fine.&lt;br/&gt;
 &#160;&lt;/p&gt;</description>
                <environment></environment>
        <key id="46078">LU-9500</key>
            <summary>MOFED 4/mlx5: Aligning non-aligned page addresses trigger dump_cqe</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.whamcloud.com/images/icons/priorities/critical.svg">Critical</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="sharmaso">Sonia Sharma</assignee>
                                    <reporter username="doug">Doug Oucharek</reporter>
                        <labels>
                    </labels>
                <created>Sat, 13 May 2017 01:42:24 +0000</created>
                <updated>Tue, 1 Sep 2020 14:13:59 +0000</updated>
                            <resolved>Sat, 22 Jul 2017 04:00:27 +0000</resolved>
                                                    <fixVersion>Lustre 2.10.1</fixVersion>
                    <fixVersion>Lustre 2.11.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>16</watches>
                                                                            <comments>
                            <comment id="196101" author="gerrit" created="Tue, 16 May 2017 23:03:43 +0000"  >&lt;p&gt;Doug Oucharek (doug.s.oucharek@intel.com) uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/27149&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/27149&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-9500&quot; title=&quot;MOFED 4/mlx5: Aligning non-aligned page addresses trigger dump_cqe&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-9500&quot;&gt;&lt;del&gt;LU-9500&lt;/del&gt;&lt;/a&gt; lnd: Don&apos;t Page Align remote_addr with FastReg&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: b0e0556df581300b976536c2c16351fe4ed492b7&lt;/p&gt;</comment>
                            <comment id="196926" author="shadow" created="Wed, 24 May 2017 16:09:48 +0000"  >&lt;p&gt;Doug,&lt;/p&gt;

&lt;p&gt;patch looks fine for me. But looks we need to have same for other memory registration modes.&lt;/p&gt;

&lt;p&gt;But I will be like to ask Jay to review a CLIO code to avoid unaligned address using.&lt;br/&gt;
Lustre locks is page aligned always, so we should have a single way to have unaligned address - direct IO code. I will avoid problem with many fragments on routers discussed before and needs a two SGE per WR.&lt;/p&gt;</comment>
                            <comment id="198129" author="simmonsja" created="Mon, 5 Jun 2017 15:12:29 +0000"  >&lt;p&gt;Hi Doug.&lt;/p&gt;

&lt;p&gt;So I tested on our RHEL7 with default OFED using mlx4 driver and the latest patch worked. I need to test it on a few configurations. I have:&lt;/p&gt;

&lt;p&gt;1) SLES11 SP3 with OFED 311 stack using mlx4 hardware, maybe mlx5. Have to ask.&lt;/p&gt;

&lt;p&gt;2) Power8 RHEL7.3 with MOFED 3.3 with mlx5 hardware&lt;/p&gt;

&lt;p&gt;3) Power8 RHEL7.3 with MOFED 4.X with mlx5 hardware (needs to be set up)&lt;/p&gt;

&lt;p&gt;I will let you know the results.&lt;/p&gt;</comment>
                            <comment id="203174" author="gerrit" created="Sat, 22 Jul 2017 02:55:03 +0000"  >&lt;p&gt;Oleg Drokin (oleg.drokin@intel.com) merged in patch &lt;a href=&quot;https://review.whamcloud.com/27149/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/27149/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-9500&quot; title=&quot;MOFED 4/mlx5: Aligning non-aligned page addresses trigger dump_cqe&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-9500&quot;&gt;&lt;del&gt;LU-9500&lt;/del&gt;&lt;/a&gt; lnd: Don&apos;t Page Align remote_addr with FastReg&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: 6c6341804133ea0a4d4535c621f28f61fe6c29ab&lt;/p&gt;</comment>
                            <comment id="203181" author="mdiep" created="Sat, 22 Jul 2017 04:00:27 +0000"  >&lt;p&gt;landed in lustre 2.11.0&lt;/p&gt;</comment>
                            <comment id="203631" author="gerrit" created="Wed, 26 Jul 2017 18:51:02 +0000"  >&lt;p&gt;Minh Diep (minh.diep@intel.com) uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/28237&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/28237&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-9500&quot; title=&quot;MOFED 4/mlx5: Aligning non-aligned page addresses trigger dump_cqe&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-9500&quot;&gt;&lt;del&gt;LU-9500&lt;/del&gt;&lt;/a&gt; lnd: Don&apos;t Page Align remote_addr with FastReg&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: b2_10&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 25c54cbd1c4a2b02bab548b0feed96ad635af70f&lt;/p&gt;</comment>
                            <comment id="204698" author="gerrit" created="Mon, 7 Aug 2017 18:51:02 +0000"  >&lt;p&gt;John L. Hammond (john.hammond@intel.com) merged in patch &lt;a href=&quot;https://review.whamcloud.com/28237/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/28237/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-9500&quot; title=&quot;MOFED 4/mlx5: Aligning non-aligned page addresses trigger dump_cqe&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-9500&quot;&gt;&lt;del&gt;LU-9500&lt;/del&gt;&lt;/a&gt; lnd: Don&apos;t Page Align remote_addr with FastReg&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: b2_10&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: f87c7c2cee6fc5a0864a757917a414dc605554b3&lt;/p&gt;</comment>
                            <comment id="205693" author="dougo" created="Thu, 17 Aug 2017 23:03:21 +0000"  >&lt;p&gt;Has this been pushed upstream yet?&lt;/p&gt;</comment>
                            <comment id="205704" author="simmonsja" created="Thu, 17 Aug 2017 23:36:35 +0000"  >&lt;p&gt;Not yet.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10120">
                    <name>Blocker</name>
                                                                <inwardlinks description="is blocked by">
                                        <issuelink>
            <issuekey id="46328">LU-9565</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10010">
                    <name>Duplicate</name>
                                                                <inwardlinks description="is duplicated by">
                                        <issuelink>
            <issuekey id="48069">LU-9932</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                            <outwardlinks description="is related to ">
                                                        </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="45954">LU-9472</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="48300">LU-9983</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="45901">LU-9461</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="46758">LU-9679</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="26842" name="dump-LU-9500.log" size="8032891" author="simmonsja" created="Tue, 30 May 2017 23:00:13 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzzcpb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>