https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9513 Lustre <p>Found 1 new static analysis issues in v2_9_57_0-66-gb6d5b5b:</p> <ol> <li><b>Result of function that may return NULL will be dereferenced</b> <ul> <li><tt>lustre/utils/liblustreapi_layout.c</tt>: in <em>llapi_layout_file_comp_del</em>, Pointer 'comp' returned from call to function '&#95;&#95;llapi&#95;layout&#95;cur&#95;comp' at line 1963 may be NULL and will be dereferenced at line 1964.</li> </ul> </li> </ol> <p>The list of commits since the previous build v2_9_57_0-45-gcdc7b3b:</p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=b6d5b5b44f83efdbac4a79a8e20e8f8ec7f8b3ee" class="external-link" target="_blank" rel="nofollow noopener">b6d5b5b</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9415" title="lfsck_load_one_trace_file() is too noisy" class="issue-link" data-issue-key="LU-9415"><del>LU-9415</del></a> lfsck: quiet noisy console message</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=2ef0f3abe5abe609979b9c6dd58945400b2cdecc" class="external-link" target="_blank" rel="nofollow noopener">2ef0f3a</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9477" title="hsm test: check correct handling of dead object" class="issue-link" data-issue-key="LU-9477"><del>LU-9477</del></a> tests: check correct handling of dead object</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=2dd720a1ad43c4d3cf1d226a226e2ffa494866e4" class="external-link" target="_blank" rel="nofollow noopener">2dd720a</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9464" title="use OBD_ALLOC_LARGE() for hsm_scan_data request array" class="issue-link" data-issue-key="LU-9464"><del>LU-9464</del></a> hsm: use OBD_ALLOC_LARGE() for hsm_scan_data array</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a003d8d6af63801c8f8431453fd0d94630122125" class="external-link" target="_blank" rel="nofollow noopener">a003d8d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9119" title="LNet Multi-Rail Dynamic Discovery preparation" class="issue-link" data-issue-key="LU-9119"><del>LU-9119</del></a> lnet: Fix deleting peers from YAML</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a6d463ff0b018e902afe63801c8b2c1e9a92ddc2" class="external-link" target="_blank" rel="nofollow noopener">a6d463f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9315" title="New static analysis issues in v2_9_55_0-35-gaa32cc5" class="issue-link" data-issue-key="LU-9315"><del>LU-9315</del></a> pfl: static analysis issues</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=49f4bd032446a9f7c594b5b2ca130e2a45714262" class="external-link" target="_blank" rel="nofollow noopener">49f4bd0</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9241" title="ASSERTION( de-&gt;d_op == &amp;ll_d_ops ) failed" class="issue-link" data-issue-key="LU-9241"><del>LU-9241</del></a> llite: ASSERTION( de-&gt;d_op == &amp;ll_d_ops ) failed</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e96c70e04ff2644909b96d94d4718117f7402a40" class="external-link" target="_blank" rel="nofollow noopener">e96c70e</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9202" title="lfsck_layout_assistant_sync_failures()) ASSERTION( ltd != ((void *)0) ) failed" class="issue-link" data-issue-key="LU-9202"><del>LU-9202</del></a> lfsck: skip unavailable targets when sync failures</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=5d32447500107f5abd386400ec9cd8ab8a3d9706" class="external-link" target="_blank" rel="nofollow noopener">5d32447</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9183" title="Support for linux 4.9 kernels" class="issue-link" data-issue-key="LU-9183"><del>LU-9183</del></a> llite: remove struct file on stack in ll_setxattr()</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=fa3598d0beca2bc8c5eb4c570210f5298a8613d0" class="external-link" target="_blank" rel="nofollow noopener">fa3598d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9183" title="Support for linux 4.9 kernels" class="issue-link" data-issue-key="LU-9183"><del>LU-9183</del></a> ptlrpc: handle changes in struct group_info</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=185251325971a8111f3e821cde4f18f9533f8746" class="external-link" target="_blank" rel="nofollow noopener">1852513</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8730" title="interop: 2.1(server)&lt;-&gt;2.8(client): conf-sanity test_82: mkfs.lustre FATAL: Bad argument: /dev/vdb" class="issue-link" data-issue-key="LU-8730"><del>LU-8730</del></a> test: Remove duplicate $dev from conf-sanity test_83</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=434eeba4d33d9ddd871cff080d51534081bb3d30" class="external-link" target="_blank" rel="nofollow noopener">434eeba</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8589" title="remove &quot;_object&quot; from method names" class="issue-link" data-issue-key="LU-8589"><del>LU-8589</del></a> osd: remove "object" from method function names</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c60e949e3b9f7ff19e1a644210cc764ee150ad8b" class="external-link" target="_blank" rel="nofollow noopener">c60e949</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8359" title="Wrong evict during failover" class="issue-link" data-issue-key="LU-8359">LU-8359</a> ldlm: Wrong evict during failover</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=3800d05641158608e5a139336c00a781fa9fb8c7" class="external-link" target="_blank" rel="nofollow noopener">3800d05</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9305" title="Running File System Aging create write checksum errors " class="issue-link" data-issue-key="LU-9305"><del>LU-9305</del></a> osd-zfs: arc_buf could be non-pagesize aligned</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=f240769f40bf9e623fe7e9a8b061c7cd332a7c46" class="external-link" target="_blank" rel="nofollow noopener">f240769</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8670" title="sanity_115 Fixes &amp; Improvements " class="issue-link" data-issue-key="LU-8670"><del>LU-8670</del></a> tests: test_115 Fixes &amp; Improvements</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=b27652cb440f2bea59db254e955403484c6c1d3a" class="external-link" target="_blank" rel="nofollow noopener">b27652c</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6952" title="Mount options parsing problem" class="issue-link" data-issue-key="LU-6952"><del>LU-6952</del></a> mount: Mount options parsing problem</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=b76a5b14f558eb3b5eba41dbd0c440fe69e25fe4" class="external-link" target="_blank" rel="nofollow noopener">b76a5b1</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9425" title="Turn RDMA Fragment Fix on by default" class="issue-link" data-issue-key="LU-9425"><del>LU-9425</del></a> lnd: Turn on 2 sges by default</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=5611dbe56b95e79df0723e2668f977492abd68ed" class="external-link" target="_blank" rel="nofollow noopener">5611dbe</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7584" title="sanity test_129: current dir size 24576, previous limit 24576" class="issue-link" data-issue-key="LU-7584"><del>LU-7584</del></a> tests: clean up sanity test_129</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=da47e9c0320c9da342b7366e45a010e5a9ba239d" class="external-link" target="_blank" rel="nofollow noopener">da47e9c</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-9362" title="PFL: Files with multiple components should not return multiple values for ‘lfs getstripe’" class="issue-link" data-issue-key="LU-9362"><del>LU-9362</del></a> lfs: getstripe print last init-ed component info</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e79e711e8f61dab7978102c5be04b94c5557b3dc" class="external-link" target="_blank" rel="nofollow noopener">e79e711</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8998" title="Progressive File Layout (PFL)" class="issue-link" data-issue-key="LU-8998"><del>LU-8998</del></a> tests: improve sanity.sh::check_seq_oid()</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=7a1c0f950f8733c3f44e28a3b96d579797e46e80" class="external-link" target="_blank" rel="nofollow noopener">7a1c0f9</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-8998" title="Progressive File Layout (PFL)" class="issue-link" data-issue-key="LU-8998"><del>LU-8998</del></a> tools: support negative flags</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=64b2fad22a4eb4727315709e014d8f74c5a7f289" class="external-link" target="_blank" rel="nofollow noopener">64b2fad</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7473" title="Enlarge ACL entry limitation" class="issue-link" data-issue-key="LU-7473"><del>LU-7473</del></a> acl: increase ACL entries limitation</td> </tr> </tbody></table> </div> LU-9513

New static analysis issues in v2_9_57_0-66-gb6d5b5b

Bug Minor Resolved Fixed Niu Yawei Dmitry Eremin kw Tue, 16 May 2017 16:07:25 +0000 Wed, 30 Aug 2023 21:38:59 +0000 Mon, 29 May 2017 18:17:05 +0000 Lustre 2.10.0 Lustre 2.10.0 0 7 <p>Niu</p> <p>Could you pelase assist with this issue?</p> <p>Peter</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> layout = llapi_layout_alloc(); <span class="code-keyword">if</span> (layout == NULL) <span class="code-keyword">return</span> -1; llapi_layout_comp_extent_set(layout, 0, LUSTRE_EOF); comp = __llapi_layout_cur_comp(layout); comp-&gt;llc_id = id; comp-&gt;llc_flags = flags; </pre> </div></div> <p>For this particular call to "__llapi_layout_cur_comp(layout)", it's different from other callers (where the 'layout' is passed in from user apps), the 'layout' is constructed internally by the caller itself, so we can guarantee the 'layout' is valid, and the __llapi_layout_cur_comp() won't return a NULL on a valid 'layout'.</p> <p>I'm wondering why the analysis tool warn about this, is this a shortcoming (or defect) of the tool? Or I missed anything in the code? Bobi, could you double check the code to see if I missed anything which may lead to a NULL being returned?</p> <p>Dmitry/Andreas, should we add redundant check to make analysis tool happy or just leave it as-is? I'm not quite sure what policy we used for such kind of issues.</p> <p>current code can make sure that 1963 returned a non-NULL pointer, while I think we'd add the check, since further code change could possibly introduce NULL pointer.</p> <p>My position is we should write robust code. Even if now this condition is not possible we should check for it to avoid crash or unxpected behavior in the future when something can be changed. We cannot remember all details of all calling conventions especially without comments.</p> <p>Niu Yawei (yawei.niu@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/27154" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/27154</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9513" title="New static analysis issues in v2_9_57_0-66-gb6d5b5b" class="issue-link" data-issue-key="LU-9513"><del>LU-9513</del></a> liblustre: always check return value<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: bcf5cf8502221dbca1610723b999193f7d91209f</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/27154/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/27154/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9513" title="New static analysis issues in v2_9_57_0-66-gb6d5b5b" class="issue-link" data-issue-key="LU-9513"><del>LU-9513</del></a> liblustre: always check return value<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b58fcb7fe4f63830ccc3e6c1747cb1b361d481dd</p> <p>Landed for 2.10</p> Related LU-4629 LU-8998 Development Rank 1|hzzcwn: Rank (Obsolete) 9223372036854775807 Severity