https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9619 Lustre <p>It would be possible to have the <tt>contrib/git-hooks/prepare-commit-message</tt> script automatically add a <tt>Test-Parameters: trivial</tt> tag (with an optional <tt>testlist=&lt;test&gt;</tt> item) to patches that are only modifying test scripts. As with the <tt>Signed-off-by:</tt> line, this should be added in a commented-out form so that it is up to the developer to determine if this is appropriate, but having the line present would at least remind the user about this option to reduce testing time.</p> LU-9619

automatically add Test-Parameters: line for simple patches

Improvement Minor Open Unresolved Tim Day Andreas Dilger easy tests Thu, 8 Jun 2017 00:04:27 +0000 Wed, 20 Sep 2023 04:06:39 +0000 0 5 <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50298" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50298</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9619" title="automatically add Test-Parameters: line for simple patches" class="issue-link" data-issue-key="LU-9619">LU-9619</a> misc: add Test-Parameters to git-hook<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: de150d9f0479eafdae5a2b0d28ca8297fd6afd4c</p> <p>Tim, as a follow-on to your above patch, it would be useful if <tt>prepare-commit-msg</tt> could add a "real" Test-Parameters: lines (not just examples) based on the output of "<tt>git diff $DIFFOPT --stat</tt>". </p> <p>For example, if the patch is only modifying files like "<tt>lustre/tests/conf-sanity.sh</tt>" then the commit message could add:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Test-Parameters: trivial testlist=conf-sanity </pre> </div></div> <p>Similarly, though a bit more complex, would be if patches add lines in test scripts with <tt>version_code</tt> then it makes sense to automatically add lines that run interop testing:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Test-Parameters: testlist=&lt;test_script&gt; serverversion=&lt;older_version&gt; Test-Parameters: testlist=&lt;test_script&gt; clientversion=&lt;older_version&gt; </pre> </div></div> <p>This is a bit tricky if it is kernel or distro versions being checked, but it couldn't hurt to highlight this at least (maybe also <tt>checkpatch.pl</tt>, so that it is posted in Gerrit as a reminder for reviewers).</p> <p>Also, <tt>commit-msg</tt> could potentially sanity-check any existing <tt>Test-Parameters:</tt> lines to confirm that either no <tt>trivial</tt> keyword is added, or that every test script in <tt>lustre/tests/&#42;.sh</tt> is explicitly listed with <tt>testlist=</tt> (excluding "<tt>sanity.sh</tt> because that is <b>always</b> run regardless of any <tt>Test-Parameters:</tt> specified). However, I'd prefer the "carrot" approach that automatically adds the <tt>Test-Parameters:</tt> lines rather than complaining afterward.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50298/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50298/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9619" title="automatically add Test-Parameters: line for simple patches" class="issue-link" data-issue-key="LU-9619">LU-9619</a> misc: add Test-Parameters to git-hook<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a7cd87862470899fe6ceb08b50267ea058221a13</p> <p>Oleg's code for determining tests to be run based on the patch content is in <a href="https://github.com/verygreen/lustretester/blob/master/gerrit_build-and-test-new.py" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/verygreen/lustretester/blob/master/gerrit_build-and-test-new.py</a></p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=timday" class="user-hover" rel="timday">timday</a>, are you planning to work on this any further? I think automating the generation of <tt>Test-Parameters:</tt> lines in the <tt>prepare-commit-message</tt> Git hook would optimize the use of testing resources, and simplify the submission of larger patch series (which in turn would make patch reviews easier to do). I've linked Oleg's script to do something similar for the Gerrit Janitor testing, but doing something similar for <tt>Test-Parameters:</tt> would also help Autotest.</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/52420" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/52420</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9619" title="automatically add Test-Parameters: line for simple patches" class="issue-link" data-issue-key="LU-9619">LU-9619</a> contrib: rewrite prepare-commit-msg in python<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 4fd637ebe2f6fed1ac3da8fc5ee044cd61f271ee</p> Related Development Rank 1|hzzejb: Rank (Obsolete) 9223372036854775807