https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9767 Lustre <p><a href="https://review.whamcloud.com/#/c/24325/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/24325/</a> removed name length and content checking for the fsname.</p> <p>You can now format a FS with up to 16 characters, but can only reference 8 of them in various places, 16 in others.</p> LU-9767

FS name checking got removed

Bug Critical Resolved Fixed James A Simmons Ben Evans Wed, 12 Jul 2017 18:08:25 +0000 Thu, 21 Sep 2017 12:14:37 +0000 Mon, 28 Aug 2017 14:47:30 +0000 Lustre 2.10.1 Lustre 2.11.0 Lustre 2.10.1 Lustre 2.11.0 0 4 <p>John Hammond asked for this. User land can scribble what ever it wants but kernel space should be rejecting the invalid file system name. The same goes for pool names. Is this not the case?</p> <p>Well, you get some weird looking bugs from it:</p> <p>tunefs.lustre:<br/> Permanent disk data:<br/> Target: asdfasdf-MDT0000<br/> Index: 0<br/> Lustre FS: asdfasdfasdfasd<br/> Mount type: ldiskfs<br/> Flags: 0x5<br/> (MDT MGS )<br/> Persistent mount opts: user_xattr,errors=remount-ro<br/> Parameters:</p> <p>so the fsname got accepted, but is truncated, except where it's not. I haven't fully sorted out what tools would refer to it by its full name, rather than the truncated one. mkfs.lustre happily accepts it, throwing no errors (up to 16 chars). I'd be curious what happens if you give it a raft of control characters. Regardless, this is a UI error, as the user should be informed of the problem in some manner.</p> <p>For mkfs.lustre, the problem is that there is no way for the kernel to verify the fsname because the kernel isn't even involved until the filesystem is mounted.</p> <p>My recommendation would be make a quick patch to add checks into <tt>mount_utils_ldiskfs.c</tt> and <tt>mount_utils_zfs.c</tt> that the fsname is &lt;= 8 characters, and do not include a '.' or other illegal character, and then separately we can examine whether it is safe to have a longer fsname where that works (e.g. ZFS where it isn't limited by the size of <tt>s_volume_name</tt> in the superblock) and make a patch to allow ZFS to have a longer fsname. This will need a code review of where fsname is used on disk and over the network, to verify there aren't explicit or implicit limitations based on the length.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/28070" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28070</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9767" title="FS name checking got removed" class="issue-link" data-issue-key="LU-9767"><del>LU-9767</del></a> utils: validate filesystem name for mkfs.lustre<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 654f635ed795d6eed28a37585dbfaec7f42b6342</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28070/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28070/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9767" title="FS name checking got removed" class="issue-link" data-issue-key="LU-9767"><del>LU-9767</del></a> utils: validate filesystem name for mkfs.lustre<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 28216a73f4c0b19ef45e3ec2d6949801f6b9f828</p> <p>Landed for 2.11</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/28996" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28996</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9767" title="FS name checking got removed" class="issue-link" data-issue-key="LU-9767"><del>LU-9767</del></a> utils: validate filesystem name for mkfs.lustre<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 51deb7c46a0509732a9274bfc87a0d762f40114b</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/28996/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28996/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9767" title="FS name checking got removed" class="issue-link" data-issue-key="LU-9767"><del>LU-9767</del></a> utils: validate filesystem name for mkfs.lustre<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: ba56efcfdd53f3066d95bb2274f6f9cca9e34c0b</p> Related LU-6401 Development Rank 1|hzzgkf: Rank (Obsolete) 9223372036854775807 Severity