https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9814 Lustre <ol> <li>cat /proc/fs/ldiskfs/md0p1/prealloc_table<br/> 256 512 1024</li> <li>echo "256 512 1024” &gt; /proc/fs/ldiskfs/md0p1/prealloc_table<br/> -bash: echo: write error: Invalid argument</li> </ol> RHEL 7.2 LU-9814

prealloc table change don't work after 2.10 upgrade

Bug Major Resolved Fixed Zhenyu Xu Alexey Lyashkov Tue, 1 Aug 2017 14:02:51 +0000 Thu, 26 Oct 2017 16:49:15 +0000 Tue, 24 Oct 2017 12:55:48 +0000 Lustre 2.10.0 Lustre 2.11.0 Lustre 2.10.2 0 8 <p>What version of Lustre are you upgrading from?</p> <p>It test system upgrade from IEEL 3.<br/> bug introduced by commit<br/> git describe b9ecf2671cba08530cc49d47713a360f2c6c25ca<br/> v2_10_50_0-19-gb9ecf2671c</p> <p>if one chunk was reverted </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">--- ldiskfs/mballoc.c 2017-08-01 05:41:12.711164350 -0700 +++ /usr/src/lustre/2.10.0/ldiskfs/mballoc.c 2017-08-01 05:44:25.782155391 -0700 @@ -2357,20 +2357,16 @@ num = 0; cur = str; end = str + cnt; - <span class="code-keyword">while</span> (cur &lt; end) { - <span class="code-object">int</span> rc; - <span class="code-keyword">while</span> ((cur &lt; end) &amp;&amp; (*cur == <span class="code-quote">' '</span>)) - cur++; - rc = kstrtol(cur, 0, &amp;value); - <span class="code-keyword">if</span> (rc != 0) - <span class="code-keyword">return</span> -EINVAL; - <span class="code-keyword">if</span> (value == 0) - <span class="code-keyword">break</span>; - <span class="code-keyword">if</span> (value &lt;= prev) - <span class="code-keyword">return</span> -EINVAL; - prev = value; - num++; - } + <span class="code-keyword">while</span> ((cur &lt; end) &amp;&amp; (*cur == <span class="code-quote">' '</span>)) cur++; + value = simple_strtol(cur, &amp;cur, 0); + <span class="code-keyword">if</span> (value == 0) + <span class="code-keyword">break</span>; + <span class="code-keyword">if</span> (value &lt;= prev) + <span class="code-keyword">return</span> -EINVAL; + prev = value; + num++; + } + new_table = kmalloc(num * sizeof(*new_table), GFP_KERNEL); <span class="code-keyword">if</span> (new_table == NULL) </pre> </div></div> <p>it will be work again.</p> <p>Bobijam</p> <p>Could you please advise?</p> <p>Thanks</p> <p>Peter</p> <p>btw. patch in <a href="https://jira.whamcloud.com/browse/LU-3719" title="divide error in ldiskfs_mb_normalize_request on MDT" class="issue-link" data-issue-key="LU-3719"><del>LU-3719</del></a> isn't real solution for a own bug. We hit similar bug with patch applied. <a href="https://jira.whamcloud.com/browse/LU-3917" title="lod_initialize_objects()) ASSERTION( cfs_bitmap_check(md-&gt;lod_ost_descs.ltd_tgt_bitmap, idx) ) failed" class="issue-link" data-issue-key="LU-3917"><del>LU-3917</del></a> root cause is unprotected access to the table while update. prealloc_table modified by ext4_mb_prealloc_table_add while accessed. Andriy Skylush should fill a ticket and provide a more details in near time.</p> <p>Yang Sheng (yang.sheng@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/28553" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28553</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9814" title="prealloc table change don&#39;t work after 2.10 upgrade" class="issue-link" data-issue-key="LU-9814"><del>LU-9814</del></a> ldiskfs: restore simple_strtol in prealloc<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: add8915bb4083d29aec27fb81ac49b7ed9ecb9a7</p> <p>Alexey</p> <p>Does this patch work from your point of view?</p> <p>Peter</p> <p>Hi <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=shadow" class="user-hover" rel="shadow">shadow</a>,</p> <p>Do you have any updates on the patch?</p> <p>Thanks,</p> <p>Brad</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28553/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28553/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9814" title="prealloc table change don&#39;t work after 2.10 upgrade" class="issue-link" data-issue-key="LU-9814"><del>LU-9814</del></a> ldiskfs: restore simple_strtol in prealloc<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 685ef61f0fb9849e3f7a32c4ebf2980d3300afb0</p> <p>Landed for 2.11</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/29733" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/29733</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9814" title="prealloc table change don&#39;t work after 2.10 upgrade" class="issue-link" data-issue-key="LU-9814"><del>LU-9814</del></a> ldiskfs: restore simple_strtol in prealloc<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: d42fb752b4b03e03e88c42bcc45ce324dba2e6a5</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/29733/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/29733/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9814" title="prealloc table change don&#39;t work after 2.10 upgrade" class="issue-link" data-issue-key="LU-9814"><del>LU-9814</del></a> ldiskfs: restore simple_strtol in prealloc<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: 3e8f17ccfe0a2358b93dbda9bba05c8dfd95aa61</p> Related LU-3719 Development Rank 1|hzzhjr: Rank (Obsolete) 9223372036854775807 Severity