Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-9855] Clean up obdclass preprocessor code https://jira.whamcloud.com/browse/LU-9855 Lustre <p>obdclass abuses the preprocessor, and the code needs to be trimmed, cleaned up, or turned into normal functions so that it is easier to read and understand.</p> LU-9855 Clean up obdclass preprocessor code Task Minor Resolved Fixed Neil Brown Ben Evans Thu, 10 Aug 2017 15:05:19 +0000 Thu, 11 Mar 2021 05:12:21 +0000 Thu, 11 Mar 2021 05:12:21 +0000 Lustre 2.15.0 0 5 <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/28458" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28458</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obdclass: Code cleanup<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 55f973a582be7aac5a61de9e2127cf400a08b813</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28458/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28458/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obdclass: Code cleanup<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 8c3c81fb787ab0a0152ebf497d1b4aef480bb82f</p> <p>Landed for 2.11</p> <p>There's a few more patches to really clean this up. I'm trying to break it into digestible chunks.</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/29286" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/29286</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obdclass: cleanup obd_class.h defines<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f7c05bb2b21854d8c837d7064f0875cda54ceef3</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/29286/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/29286/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obdclass: cleanup obd_class.h defines<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 49d8a7ccd7389586bd1c5eb98bf988f68ad2630f</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/30437" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30437</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obd: remove OBP and MBP macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 186d0f24e1f6a964d3d046e9d47d513e8653f323</p> <p>These patches can still land for 2.11 but this work does not <b>have</b> to be tracked for that release</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32822" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32822</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obdclass: simplify md_stats code<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ee669b336570e41fd54df9ec658a11af49da533e</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32822/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32822/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obdclass: simplify md_stats code<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7739c8d351e89a82280420b44241b82c220af8f2</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/33101" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33101</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> include: replace OBD_CHECK_DEV by obd_check_dev<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: bbd55d14a946163767f1d60141d33f4b49cc0aff</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/33101/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33101/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> include: replace OBD_CHECK_DEV by obd_check_dev<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 32dbb80b0dcf6774fcab1f4d79bfc119d27a25a2</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/34106" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34106</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obd: use ldo_process_config for mdc and osc layer<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 54191c4139c4ef67ba910e5e9ef103be601a175f</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/34106/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34106/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obd: use ldo_process_config for mdc and osc layer<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d12959c69fd486054619d52dbb32d7ea91327f94</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/36096" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36096</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> obd: Replace LPROCFS_CLIMP_CHECK with lprocfs_climp_check<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3f6ace5eee1ff831dfda1ddc2cf51da7da92bab5</p> <p>Neil Brown (neilb@suse.de) uploaded a new patch: <a href="https://review.whamcloud.com/36956" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36956</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> lustre: replace LPROCFS_CLIMP_CHECK()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 80f142a5ab8640631d3a86993d0828904c33b265</p> <p>Neil Brown (neilb@suse.de) uploaded a new patch: <a href="https://review.whamcloud.com/36969" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36969</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> lustre: rename obd_device variables to obd<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 32a51a6d4e50114d844d346a6ac1070d634aec87</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36956/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36956/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> lustre: replace LPROCFS_CLIMP_CHECK()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f4ce6b568b523060e71b17cf679c2b99d0038dbc</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36969/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36969/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> lustre: rename obd_device variables to obd<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: cd5d04b3722e2edca02671ab5b8729070de20275</p> <p>It looks like all this work has landed - is it ok to close out the ticket?</p> <p>Neil Brown (neilb@suse.de) uploaded a new patch: <a href="https://review.whamcloud.com/39595" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39595</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> lustre: use with_imp_locked() more broadly.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 550dd18c578c29bc95d6cb7edc18cb5aaa71355b</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39595/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39595/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9855" title="Clean up obdclass preprocessor code" class="issue-link" data-issue-key="LU-9855"><del>LU-9855</del></a> lustre: use with_imp_locked() more broadly.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 168ec247779f3ab743985bdbad605f8eacd8fc81</p> <p>Looks like all patches have landed</p> Related LU-14145 LU-12511 Development Rank 1|hzzi8f: Rank (Obsolete) 9223372036854775807