https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9909 Lustre <p>In <tt>lnet_discover()</tt> the buffer allocated by <tt>LIBCFS_ALLOC(buf, n_ids * sizeof(*buf))</tt> is never freed.</p> LU-9909

memory leak in lnet_discover()

Bug Minor Resolved Fixed Amir Shehata John Hammond Thu, 24 Aug 2017 15:17:02 +0000 Thu, 31 Aug 2017 19:45:11 +0000 Thu, 31 Aug 2017 19:45:11 +0000 Lustre 2.11.0 Lustre 2.11.0 0 7 <p>thanks for catching that. Will address it.</p> <p>I'm seeing several of our tests failing with </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[13455.203067] LNetError: 14901:0:(module.c:689:libcfs_exit()) Portals memory leaked: 184 bytes mv: cannot stat '/tmp/debug': No such file or directory Memory leaks detected </pre> </div></div> <p>Is this the same issue?</p> <p>Logs for this failure can be found at<br/> <a href="https://testing.hpdd.intel.com/test_sets/972a44c6-87e0-11e7-b4b0-5254006e85c2" class="external-link" target="_blank" rel="nofollow noopener">https://testing.hpdd.intel.com/test_sets/972a44c6-87e0-11e7-b4b0-5254006e85c2</a></p> <p>Did that just start happening after the latest landing? or has it been happening for a while?</p> <p>So far, the earliest date I see the 'Portals memory leaked' error is on August 22. So, yes, they started after the last batch of patch landings to master.</p> <p>I bisected this locally by running conf-sanity 35a. This was introduced by commit 0f1aaad4c1b4447ee5097b8bb79a49d09eaa23c2 <a href="https://review.whamcloud.com/25789" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25789</a> <a href="https://jira.whamcloud.com/browse/LU-9480" title="LNet Dynamic Discovery" class="issue-link" data-issue-key="LU-9480"><del>LU-9480</del></a> lnet: implement Peer Discovery. Unfortunately leak finder doesn't work for LNet allocations. But the leak is most likely an LNet peer:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>m:lustre-release# gdb lnet/lnet/lnet.ko ... (gdb) p sizeof(struct lnet_peer) $1 = 184 </pre> </div></div> <p>If the leak is an lnet_peer then it differs from the problem for which this LU was opened.</p> <p>I created <a href="https://jira.whamcloud.com/browse/LU-9913" title="conf-sanity tests 31 and 35a fail with “LNetError: 8653:0:(module.c:689:libcfs_exit()) Portals memory leaked: 184 bytes”" class="issue-link" data-issue-key="LU-9913"><del>LU-9913</del></a> to capture the lnet_peer memory leak error.</p> <p>Amir Shehata (amir.shehata@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/28702" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28702</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9909" title="memory leak in lnet_discover()" class="issue-link" data-issue-key="LU-9909"><del>LU-9909</del></a> lnet: fix memory leak and lnet_interfaces_max<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 52ea572d5e828584ba49f703f0161407384323a2</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28702/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28702/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9909" title="memory leak in lnet_discover()" class="issue-link" data-issue-key="LU-9909"><del>LU-9909</del></a> lnet: fix memory leak and lnet_interfaces_max<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 81d4f7a253193ebfe559f675d3c0975c0899d592</p> <p>Landed for 2.11</p> Development Rank 1|hzziyf: Rank (Obsolete) 9223372036854775807