https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9933 Lustre <p>More than 1/2 the time when I attempt to bring up a file system I hit this assertion:</p> <p>2017-08-30T14:33:56.720487-04:00 ninja33.ccs.ornl.gov kernel: LNetError: 1755:0:(peer.c:1248:lnet_peer_add_nid()) ASSERTION( nid !<br/> = ((lnet_nid_t) -1) ) failed:<br/> 2017-08-30T14:33:56.720539-04:00 ninja33.ccs.ornl.gov kernel: LNetError: 1755:0:(peer.c:1248:lnet_peer_add_nid()) LBUG<br/> 2017-08-30T14:33:56.720559-04:00 ninja33.ccs.ornl.gov kernel: Pid: 1755, comm: lnet_discovery<br/> 2017-08-30T14:33:56.726095-04:00 ninja33.ccs.ornl.gov kernel: #012Call Trace:<br/> 2017-08-30T14:33:56.740849-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffffc08797de&gt;&#93;</span> libcfs_call_trace+0x4e/0x60 <span class="error">&#91;libcfs&#93;</span><br/> 2017-08-30T14:33:56.740894-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffffc087986c&gt;&#93;</span> lbug_with_loc+0x4c/0xb0 <span class="error">&#91;libcfs&#93;</span><br/> 2017-08-30T14:33:56.756438-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffffc097b1f4&gt;&#93;</span> lnet_peer_add_nid+0x384/0x390 <span class="error">&#91;lnet&#93;</span><br/> 2017-08-30T14:33:56.756476-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffffc097b226&gt;&#93;</span> lnet_peer_set_primary_nid+0x26/0xe0 <span class="error">&#91;lnet&#93;</span><br/> 2017-08-30T14:33:56.773089-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffffc097cc46&gt;&#93;</span> lnet_peer_discovery+0xbf6/0xf80 <span class="error">&#91;lnet&#93;</span><br/> 2017-08-30T14:33:56.773129-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffff810b1910&gt;&#93;</span> ? autoremove_wake_function+0x0/0x40<br/> 2017-08-30T14:33:56.789130-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffffc097c050&gt;&#93;</span> ? lnet_peer_discovery+0x0/0xf80 <span class="error">&#91;lnet&#93;</span><br/> 2017-08-30T14:33:56.789167-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffff810b098f&gt;&#93;</span> kthread+0xcf/0xe0<br/> 2017-08-30T14:33:56.795447-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffff810b08c0&gt;&#93;</span> ? kthread+0x0/0xe0<br/> 2017-08-30T14:33:56.808636-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffff816b4f18&gt;&#93;</span> ret_from_fork+0x58/0x90<br/> 2017-08-30T14:33:56.808675-04:00 ninja33.ccs.ornl.gov kernel: <span class="error">&#91;&lt;ffffffff810b08c0&gt;&#93;</span> ? kthread+0x0/0xe0<br/> 2017-08-30T14:33:56.814948-04:00 ninja33.ccs.ornl.gov kernel:<br/> 2017-08-30T14:33:56.817775-04:00 ninja33.ccs.ornl.gov kernel: Kernel panic - not syncing: LBUG</p> LU-9933

Hitting ASSERTION in lnet_peer_add_nid()

Bug Blocker Resolved Fixed Amir Shehata James A Simmons patch Wed, 30 Aug 2017 18:44:05 +0000 Mon, 2 Oct 2017 22:29:30 +0000 Sat, 30 Sep 2017 04:43:14 +0000 Lustre 2.11.0 Lustre 2.11.0 0 5 <p>To get here the ping buffer must have contained only a single NID, which should always be the loopback NID. Like the <tt>lnet_peer_data_present()</tt> should have the following check changed</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (pbuf-&gt;pb_info.pi_nnis &gt; 1) nid = pbuf-&gt;pb_info.pi_ni[1].ns_nid; </pre> </div></div> <p>to</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (pbuf-&gt;pb_info.pi_nnis &lt;= 1) <span class="code-keyword">goto</span> out; nid = pbuf-&gt;pb_info.pi_ni[1].ns_nid; </pre> </div></div> <p>Olaf Weber (olaf.weber@hpe.com) uploaded a new patch: <a href="https://review.whamcloud.com/28811" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28811</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9933" title="Hitting ASSERTION in lnet_peer_add_nid()" class="issue-link" data-issue-key="LU-9933"><del>LU-9933</del></a> lnet: Handle ping buffer with only loopback NID<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f96a5611b5ed1d4414636970df3c20e02b997deb</p> <p>this patch has +2, should we land it since it's a blocker?</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28811/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28811/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9933" title="Hitting ASSERTION in lnet_peer_add_nid()" class="issue-link" data-issue-key="LU-9933"><del>LU-9933</del></a> lnet: Handle ping buffer with only loopback NID<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 002e25b9277905b97aa827dc3fb72db2f25b32f2</p> <p>Landed for 2.11.</p> <p>Does this affect b2_10?</p> <p>No. This impacts dynamic discovery only</p> Related LU-9990 Development Rank 1|hzzjcf: Rank (Obsolete) 9223372036854775807 Severity