https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9934 Lustre <p>Lustre doesn't build with newer gcc7 due to many different warnings. some are easier to fix in the code. another are rather false (see an example below) and easier to supress.</p> <p>util/parser.c:575:25: error: ‘%2d’ directive output may be truncated writing between 2 and 10 bytes into a region of size 4 <span class="error">&#91;-Werror=format-truncation=&#93;</span></p> gcc7 LU-9934

support gcc7

Improvement Minor Resolved Fixed Alex Zhuravlev Alex Zhuravlev Thu, 31 Aug 2017 07:01:07 +0000 Thu, 13 Sep 2018 18:22:50 +0000 Tue, 6 Mar 2018 21:12:45 +0000 Lustre 2.11.0 Lustre 2.11.0 0 5 <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/28810" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28810</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9934" title="support gcc7" class="issue-link" data-issue-key="LU-9934"><del>LU-9934</del></a> build: support for gcc7<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 5200a2f474fe049f3cf6176842e92aae2a6c5c64</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/30376" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30376</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9934" title="support gcc7" class="issue-link" data-issue-key="LU-9934"><del>LU-9934</del></a> build: address issues raised by gcc7<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6bb8778b2660b83f9ef83af12c5f0536f2b164a9</p> <p>with the latest patch:</p> <p>/home/alexey/head2/libcfs/libcfs/workitem.c: In function ‘cfs_wi_sched_create’:<br/> /home/alexey/head2/libcfs/libcfs/workitem.c:384:37: error: ‘%02d’ directive output may be truncated writing between 2 and 11 bytes into a region of size between 0 and 15 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(name, sizeof(name), "%s_%02d_%02d",<br/> ^~~~<br/> /home/alexey/head2/libcfs/libcfs/workitem.c:384:4: note: ‘snprintf’ output between 7 and 39 bytes into a destination of size 16<br/> snprintf(name, sizeof(name), "%s_%02d_%02d",<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> sched-&gt;ws_name, sched-&gt;ws_cpt,<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> sched-&gt;ws_nthreads);<br/> ~~~~~~~~~~~~~~~~~~~<br/> /home/alexey/head2/libcfs/libcfs/workitem.c:388:37: error: ‘%02d’ directive output may be truncated writing between 2 and 10 bytes into a region of size between 0 and 15 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(name, sizeof(name), "%s_%02d",<br/> ^~~~<br/> /home/alexey/head2/libcfs/libcfs/workitem.c:388:33: note: directive argument in the range <span class="error">&#91;0, 1073741823&#93;</span><br/> snprintf(name, sizeof(name), "%s_%02d",<br/> ^~~~~~~~~<br/> /home/alexey/head2/libcfs/libcfs/workitem.c:388:4: note: ‘snprintf’ output between 4 and 27 bytes into a destination of size 16<br/> snprintf(name, sizeof(name), "%s_%02d",<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> sched-&gt;ws_name, sched-&gt;ws_nthreads);<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/libcfs/libcfs/workitem.o&#93;</span> Error 1<br/> make<span class="error">&#91;5&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:488: /home/alexey/head2/libcfs/libcfs&#93;</span> Error 2<br/> make<span class="error">&#91;4&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:488: /home/alexey/head2/libcfs&#93;</span> Error 2<br/> make<span class="error">&#91;4&#93;</span>: *** Waiting for unfinished jobs....<br/> /home/alexey/head2/lustre/osp/lwp_dev.c: In function ‘lwp_notify_users’:<br/> /home/alexey/head2/lustre/osp/lwp_dev.c:453:46: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size 53 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(name, MTI_NAME_MAXLEN, "lwp_notify_%s",<br/> ^~<br/> /home/alexey/head2/lustre/osp/lwp_dev.c:453:2: note: ‘snprintf’ output between 12 and 139 bytes into a destination of size 64<br/> snprintf(name, MTI_NAME_MAXLEN, "lwp_notify_%s",<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> exp-&gt;exp_obd-&gt;obd_name);<br/> ~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/lustre/osp/lwp_dev.o&#93;</span> Error 1<br/> make<span class="error">&#91;5&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:488: /home/alexey/head2/lustre/osp&#93;</span> Error 2<br/> make<span class="error">&#91;5&#93;</span>: *** Waiting for unfinished jobs....<br/> /home/alexey/head2/lustre/mdc/mdc_changelog.c: In function ‘mdc_changelog_cdev_init’:<br/> /home/alexey/head2/lustre/mdc/mdc_changelog.c:606:38: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size 22 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(name, name_len, "changelog-%s", obd-&gt;obd_name);<br/> ^~<br/> /home/alexey/head2/lustre/mdc/mdc_changelog.c:606:2: note: ‘snprintf’ output between 11 and 138 bytes into a destination of size 32<br/> snprintf(name, name_len, "changelog-%s", obd-&gt;obd_name);<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/lustre/mdc/mdc_changelog.o&#93;</span> Error 1<br/> make<span class="error">&#91;5&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:488: /home/alexey/head2/lustre/mdc&#93;</span> Error 2<br/> /home/alexey/head2/lustre/mdd/mdd_orphans.c: In function ‘mdd_orphan_cleanup’:<br/> /home/alexey/head2/lustre/mdd/mdd_orphans.c:597:48: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size 51 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(name, MTI_NAME_MAXLEN, "orph_cleanup_%s",<br/> ^~<br/> /home/alexey/head2/lustre/mdd/mdd_orphans.c:597:2: note: ‘snprintf’ output between 14 and 141 bytes into a destination of size 64<br/> snprintf(name, MTI_NAME_MAXLEN, "orph_cleanup_%s",<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> mdd2obd_dev(d)-&gt;obd_name);<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/lustre/mdd/mdd_orphans.o&#93;</span> Error 1<br/> make<span class="error">&#91;5&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:488: /home/alexey/head2/lustre/mdd&#93;</span> Error 2<br/> /home/alexey/head2/lustre/ptlrpc/nrs_orr.c: In function ‘nrs_orr_start’:<br/> /home/alexey/head2/lustre/ptlrpc/nrs_orr.c:373:42: error: ‘%s’ directive output may be truncated writing up to 15 bytes into a region of size 12 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(name, NRS_ORR_OBJ_NAME_MAX, "%s%s%s%d",<br/> ^~<br/> /home/alexey/head2/lustre/ptlrpc/nrs_orr.c:373:2: note: ‘snprintf’ output between 10 and 36 bytes into a destination of size 16<br/> snprintf(name, NRS_ORR_OBJ_NAME_MAX, "%s%s%s%d",<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> "nrs_", policy-&gt;pol_desc-&gt;pd_name,<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> policy-&gt;pol_nrs-&gt;nrs_queue_type == PTLRPC_NRS_QUEUE_REG ?<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> "<em>reg</em>" : "<em>hp</em>", nrs_pol2cptid(policy));<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/lustre/ptlrpc/nrs_orr.o&#93;</span> Error 1<br/> make<span class="error">&#91;6&#93;</span>: *** Waiting for unfinished jobs....<br/> /home/alexey/head2/lustre/quota/qsd_reint.c: In function ‘qsd_start_reint_thread’:<br/> /home/alexey/head2/lustre/quota/qsd_reint.c:671:48: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size between 42 and 52 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(name, MTI_NAME_MAXLEN, "qsd_reint_%d.%s",<br/> ^~<br/> /home/alexey/head2/lustre/quota/qsd_reint.c:671:2: note: ‘snprintf’ output between 13 and 150 bytes into a destination of size 64<br/> snprintf(name, MTI_NAME_MAXLEN, "qsd_reint_%d.%s",<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> qqi-&gt;qqi_qtype, qsd-&gt;qsd_svname);<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/lustre/quota/qsd_reint.o&#93;</span> Error 1<br/> make<span class="error">&#91;5&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:488: /home/alexey/head2/lustre/quota&#93;</span> Error 2<br/> /home/alexey/head2/lustre/ptlrpc/ptlrpcd.c: In function ‘ptlrpcd_ctl_init’:<br/> /home/alexey/head2/lustre/ptlrpc/ptlrpcd.c:540:19: error: ‘%02d’ directive output may be truncated writing between 2 and 10 bytes into a region of size between 0 and 5 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> "ptlrpcd_%02d_%02d", cpt, index);<br/> ^~~~<br/> /home/alexey/head2/lustre/ptlrpc/ptlrpcd.c:540:5: note: directive argument in the range <span class="error">&#91;-1, 2147483647&#93;</span><br/> "ptlrpcd_%02d_%02d", cpt, index);<br/> ^~~~~~~~~~~~~~~~~~~<br/> /home/alexey/head2/lustre/ptlrpc/ptlrpcd.c:539:3: note: ‘snprintf’ output between 14 and 31 bytes into a destination of size 16<br/> snprintf(pc-&gt;pc_name, sizeof(pc-&gt;pc_name),<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> "ptlrpcd_%02d_%02d", cpt, index);<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/lustre/ptlrpc/ptlrpcd.o&#93;</span> Error 1<br/> make<span class="error">&#91;5&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:488: /home/alexey/head2/lustre/ptlrpc&#93;</span> Error 2<br/> /home/alexey/head2/lustre/mgs/mgs_handler.c: In function ‘mgs_target_reg’:<br/> /home/alexey/head2/lustre/mgs/mgs_handler.c:405:52: error: ‘%s’ directive output may be truncated writing up to 63 bytes into a region of size 19 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> snprintf(barrier_name, sizeof(barrier_name) - 1, "%s-%s",<br/> ^~<br/> /home/alexey/head2/lustre/mgs/mgs_handler.c:405:2: note: ‘snprintf’ output between 9 and 72 bytes into a destination of size 19<br/> snprintf(barrier_name, sizeof(barrier_name) - 1, "%s-%s",<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> mti-&gt;mti_fsname, BARRIER_FILENAME);<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> cc1: all warnings being treated as errors<br/> make<span class="error">&#91;6&#93;</span>: *** <span class="error">&#91;scripts/Makefile.build:341: /home/alexey/head2/lustre/mgs/mgs_handler.o&#93;</span> Error 1<br/> make<span class="error">&#91;6&#93;</span>: *** Waiting for unfinished jobs....<br/> /home/alexey/head2/lustre/mgs/mgs_llog.c: In function ‘mgs_write_log_target’:<br/> /home/alexey/head2/lustre/mgs/mgs_llog.c:2499:27: error: ‘%s’ directive output may be truncated writing up to 63 bytes into a region of size 40 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> "%s_UUID", mti-&gt;mti_svname);<br/> ^~<br/> /home/alexey/head2/lustre/mgs/mgs_llog.c:2498:17: note: ‘snprintf’ output between 6 and 69 bytes into a destination of size 40<br/> snprintf(mti-&gt;mti_uuid, sizeof(mti-&gt;mti_uuid),<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> "%s_UUID", mti-&gt;mti_svname);<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> /home/alexey/head2/lustre/mgs/mgs_llog.c:2768:27: error: ‘%s’ directive output may be truncated writing up to 63 bytes into a region of size 40 <span class="error">&#91;-Werror=format-truncation=&#93;</span><br/> "%s_UUID", mti-&gt;mti_svname);<br/> ^~<br/> /home/alexey/head2/lustre/mgs/mgs_llog.c:2767:17: note: ‘snprintf’ output between 6 and 69 bytes into a destination of size 40<br/> snprintf(mti-&gt;mti_uuid, sizeof(mti-&gt;mti_uuid),<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> "%s_UUID", mti-&gt;mti_svname);<br/> ~~~~~~~~~~~~~~~~~~~~~~~~~~~<br/> /home/alexey/head2/lustre/mgs/mgs_llog.c:2813:44: error: ‘sprintf’ may write a terminating nul past the end of the destination <span class="error">&#91;-Werror=format-overflow=&#93;</span><br/> sprintf(mdt_index, "-MDT%04x", i);<br/> ^~~~~~~~~~<br/> /home/alexey/head2/lustre/mgs/mgs_llog.c:2813:25: note: ‘sprintf’ output between 9 and 10 bytes into a destination of size 9<br/> sprintf(mdt_index, "-MDT%04x", i);<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/30376/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30376/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9934" title="support gcc7" class="issue-link" data-issue-key="LU-9934"><del>LU-9934</del></a> build: address issues raised by gcc7<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 61743b88672687f789f9c609c85a351e1595118b</p> <p>Alex</p> <p>Does your patch need to land too or was James's sufficient?</p> <p>Peter</p> <p>going to check in my setup today.</p> <p>I'm still getting those errors with gcc7.. will it be another patch?</p> <p>what's wrong with -Wno-format-truncation ?</p> <p>I've updated my patch (now much smaller) to be able to build with gcc7<br/> notice #include &lt;sys/sysmacros.h&gt;<br/> w/o that I'm getting this:</p> <p>libmount_utils_ldiskfs.c: In function ‘tune_block_dev’:<br/> libmount_utils_ldiskfs.c:1234:13: error: In the GNU C Library, "major" is defined<br/> by &lt;sys/sysmacros.h&gt;. For historical compatibility, it is<br/> currently defined by &lt;sys/types.h&gt; as well, but we plan to<br/> remove this soon. To use "major", include &lt;sys/sysmacros.h&gt;<br/> directly. If you did not intend to use a system-defined macro<br/> "major", you should undefine it after including &lt;sys/types.h&gt;. <span class="error">&#91;-Werror&#93;</span><br/> if (major(st.st_rdev) == LOOP_MAJOR)<br/> ^~~~~~~~~~~~~~~~~~~~~~~~~ </p> <p>Thanks. I also see another patch just landed that break Ubuntu17 builds again <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> Its in lnetconfig library.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28810/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28810/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9934" title="support gcc7" class="issue-link" data-issue-key="LU-9934"><del>LU-9934</del></a> build: support for gcc7<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4b67e5a8150309f4bbeb43a9095f12243be6dcfa</p> <p>Landed for 2.11</p> <p>Li Dongyang (dongyangli@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/31791" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31791</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9934" title="support gcc7" class="issue-link" data-issue-key="LU-9934"><del>LU-9934</del></a> build: fix gcc7 complains in lprocfs_status_server.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ca080cc5877ed4bb521c03466f92324760d5ff9f</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/33160" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33160</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9934" title="support gcc7" class="issue-link" data-issue-key="LU-9934"><del>LU-9934</del></a> build: address issues raised by gcc7<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 3b90539df347a9669bda22691855f98b4f7c06b1</p> Related LU-9833 LU-8587 Development Rank 1|hzzjdj: Rank (Obsolete) 9223372036854775807