https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-9971 Lustre <p>In lnet_discover_peer_locked() when we drop and re-acquire the net lock there is a possibility that the lpni might've been relinked, opening the window for an ABA problem.</p> LU-9971

MR: ABA problem in lnet_discover_peer_locked

Bug Minor Resolved Fixed Amir Shehata Amir Shehata Mon, 11 Sep 2017 15:08:37 +0000 Tue, 22 Sep 2020 16:29:02 +0000 Wed, 10 Jul 2019 20:23:32 +0000 Lustre 2.13.0 Lustre 2.12.6 0 4 <p>Not so much an ABA problem as a use-after-free: the <tt>lp</tt> pointer might point to a different <tt>lnet_peer</tt> at the same address. Reshuffling the reference count addref and decref on <tt>lp</tt> a bit we can easily ensure that even if <tt>lpni</tt> is now linked to a different peer, at least that peer must have a different address.</p> <p>Olaf Weber (olaf.weber@hpe.com) uploaded a new patch: <a href="https://review.whamcloud.com/28944" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28944</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9971" title="MR: ABA problem in lnet_discover_peer_locked" class="issue-link" data-issue-key="LU-9971"><del>LU-9971</del></a> lnet: use after free in lnet_discover_peer_locked()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0f1814c07e9e9107dc6b92584ab9ed999621fee6</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/28944/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28944/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9971" title="MR: ABA problem in lnet_discover_peer_locked" class="issue-link" data-issue-key="LU-9971"><del>LU-9971</del></a> lnet: use after free in lnet_discover_peer_locked()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2b5b551b15d96588f8f309b5a08c11cab203efeb</p> <p>The patch has a defect caused by landing of <a href="https://jira.whamcloud.com/browse/LU-11299" title="LNet: Router pinger" class="issue-link" data-issue-key="LU-11299"><del>LU-11299</del></a>.</p> <p>Amir Shehata (ashehata@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35446" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35446</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9971" title="MR: ABA problem in lnet_discover_peer_locked" class="issue-link" data-issue-key="LU-9971"><del>LU-9971</del></a> lnet: fix peer ref counting<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 086739cf3d0424da664cd11c7798f7c93153b95b</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35446/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35446/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9971" title="MR: ABA problem in lnet_discover_peer_locked" class="issue-link" data-issue-key="LU-9971"><del>LU-9971</del></a> lnet: fix peer ref counting<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: dbcddb4824f08153f145327e2bfe1bf4a2becc4f</p> <p>Both patches landed for 2.13</p> <p>Amir Shehata (ashehata@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/38891" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38891</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9971" title="MR: ABA problem in lnet_discover_peer_locked" class="issue-link" data-issue-key="LU-9971"><del>LU-9971</del></a> lnet: use after free in lnet_discover_peer_locked()<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: da45d5fe3b64f38391f25511eccbacf250bac28b</p> <p>Amir Shehata (ashehata@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/38892" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38892</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9971" title="MR: ABA problem in lnet_discover_peer_locked" class="issue-link" data-issue-key="LU-9971"><del>LU-9971</del></a> lnet: fix peer ref counting<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 9312614ca535a6b7c4d4c81756237a9192322460</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38891/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38891/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-9971" title="MR: ABA problem in lnet_discover_peer_locked" class="issue-link" data-issue-key="LU-9971"><del>LU-9971</del></a> lnet: use after free in lnet_discover_peer_locked()<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 3f3c839f97298f6e65e2e053fc2ece59c39931dc</p> Related LU-10281 LU-13652 LU-12519 Development Rank 1|hzzjyn: Rank (Obsolete) 9223372036854775807 Severity