Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10255

sanity 129 wrong comparison operator used

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0, Lustre 2.10.3
    • Lustre 2.10.1, Lustre 2.11.0
    • None
    • 3
    • 9223372036854775807

    Description

      When sanity 129 is run the following error from bash is printed (this doesn't cause direct test failure):

      ./sanity.sh: line 9244: [: true: integer expression expected

      This is due to has_warning being set to either true/false but those values aren't being evaluated as integers but as strings. So the correct comparison is actually:

       [ $has_warnings = "false" ] 

      Attachments

        Activity

          [LU-10255] sanity 129 wrong comparison operator used

          John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30151/
          Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129
          Project: fs/lustre-release
          Branch: b2_10
          Current Patch Set:
          Commit: 3dc028ea4916b1f2ca1f829c7338a5ff355f44d5

          gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30151/ Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129 Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: 3dc028ea4916b1f2ca1f829c7338a5ff355f44d5
          pjones Peter Jones added a comment -

          Landed for 2.11

          pjones Peter Jones added a comment - Landed for 2.11

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30149/
          Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 35531ce8bd1bfd79808723ee843f5ca8e10e105d

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30149/ Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129 Project: fs/lustre-release Branch: master Current Patch Set: Commit: 35531ce8bd1bfd79808723ee843f5ca8e10e105d

          Nikolay Borisov (nborisov@suse.com) uploaded a new patch: https://review.whamcloud.com/30151
          Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129
          Project: fs/lustre-release
          Branch: b2_10
          Current Patch Set: 1
          Commit: 010373cb5caf6bd454d666afc8ea9bd3e0d01e70

          gerrit Gerrit Updater added a comment - Nikolay Borisov (nborisov@suse.com) uploaded a new patch: https://review.whamcloud.com/30151 Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129 Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 010373cb5caf6bd454d666afc8ea9bd3e0d01e70

          Nikolay Borisov (nborisov@suse.com) uploaded a new patch: https://review.whamcloud.com/30149
          Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 2ce68c96844d8d91878322b99db6364f16ef51a2

          gerrit Gerrit Updater added a comment - Nikolay Borisov (nborisov@suse.com) uploaded a new patch: https://review.whamcloud.com/30149 Subject: LU-10255 tests: Fix wrong comparison operator in sanity 129 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2ce68c96844d8d91878322b99db6364f16ef51a2

          People

            jamesanunez James Nunez (Inactive)
            nborisov Nikolay Borisov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: