Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10507

Use {save,restore}_layout() to save and restore layout in test cases

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0, Lustre 2.10.7
    • None
    • None
    • 9223372036854775807

    Description

      From https://review.whamcloud.com/#/c/30836/

      {save,restore}_layout() are "probably more reliable than the mechanism used in e.g. sanity-pfl.sh test_10, which tries to parse the layout parameters and restore them, but that will only work for simple layouts. It would be good to update that test to use save_layout() and restore_layout() as well.
      Looking a bit more I see sanity.sh test_27A(), test_65[ij], test_65m (in case of success), test_406 would also benefit from proper layout restore. The test_65[ij] tests look like they should be combined into a single test so that the layout is always restored, and not/skipped or deleted.
      That should be a separate patch so that this one can land more quickly."

      Attachments

        Issue Links

          Activity

            [LU-10507] Use {save,restore}_layout() to save and restore layout in test cases

            Andreas Dilger (adilger@whamcloud.com) merged in patch https://review.whamcloud.com/34159/
            Subject: LU-10507 tests: use

            {save,restore}

            _layout() in test
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set:
            Commit: dafe2b93e6f4cb67754e960487e92700d6ec279c

            gerrit Gerrit Updater added a comment - Andreas Dilger (adilger@whamcloud.com) merged in patch https://review.whamcloud.com/34159/ Subject: LU-10507 tests: use {save,restore} _layout() in test Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: dafe2b93e6f4cb67754e960487e92700d6ec279c

            Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34159
            Subject: LU-10507 tests: use

            {save,restore}

            _layout() in test
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: f02c76ba1141af91720a492100a51e51230d680f

            gerrit Gerrit Updater added a comment - Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34159 Subject: LU-10507 tests: use {save,restore} _layout() in test Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: f02c76ba1141af91720a492100a51e51230d680f

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30858/
            Subject: LU-10507 tests: use

            {save,restore}

            _layout() in test
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 7b980e101e172d7d8b43a0db2dcaabc8c8c6c855

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30858/ Subject: LU-10507 tests: use {save,restore} _layout() in test Project: fs/lustre-release Branch: master Current Patch Set: Commit: 7b980e101e172d7d8b43a0db2dcaabc8c8c6c855

            Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/30858
            Subject: LU-10507 tests: use

            {save,restore}

            _layout() in test
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: ab989121293868716f109ec2a6ed487033a7da37

            gerrit Gerrit Updater added a comment - Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/30858 Subject: LU-10507 tests: use {save,restore} _layout() in test Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ab989121293868716f109ec2a6ed487033a7da37

            People

              yujian Jian Yu
              jay Jinshan Xiong (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: