Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10611

utils: missing zlib.h to compile lfs.c

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      This commit modified lfs.c so that it now requires the zlib.h header file but this dependency is not checked by the configure script.

      On Centos7 compiling without first installing zlib-devel fails with:

      make[4]: Entering directory `/home/guest/lustre-release/lustre/utils'
      gcc  -rdynamic -ldl -shared -export-dynamic \
      		  -o mount_osd_ldiskfs.so \
      		 `ar -t libmount_utils_ldiskfs.a`
      depbase=`echo lfs.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
      gcc -DHAVE_CONFIG_H -I. -I../..   -include /home/guest/lustre-release/undef.h -include /home/guest/lustre-release/config.h -I/home/guest/lustre-release/libcfs/include -I/home/guest/lustre-release/lnet/include -I/home/guest/lustre-release/lnet/include/uapi -I/home/guest/lustre-release/lustre/include -I/home/guest/lustre-release/lustre/include/uapi  -fPIC -D_GNU_SOURCE -D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DLUSTRE_UTILS=1 -g -O2 -Wall -Werror -MT lfs.o -MD -MP -MF $depbase.Tpo -c -o lfs.o lfs.c &&\
      mv -f $depbase.Tpo $depbase.Po
      lfs.c:65:18: fatal error: zlib.h: No such file or directory
       #include <zlib.h>
                        ^
      compilation terminated.
      make[4]: *** [lfs.o] Error 1
      
      
      

      Attachments

        Activity

          [LU-10611] utils: missing zlib.h to compile lfs.c
          pjones Peter Jones added a comment -

          Landed for 2.11

          pjones Peter Jones added a comment - Landed for 2.11

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31186/
          Subject: LU-10611 autoconf: check zlib library and zlib.h header file
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 3a76ece5ad644b21ad2307051b8f5b47cdf0e3f6

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31186/ Subject: LU-10611 autoconf: check zlib library and zlib.h header file Project: fs/lustre-release Branch: master Current Patch Set: Commit: 3a76ece5ad644b21ad2307051b8f5b47cdf0e3f6

          Jian Yu (jian.yu@intel.com) uploaded a new patch: https://review.whamcloud.com/31186
          Subject: LU-10611 autoconf: check zlib library and zlib.h header file
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: fe805d42e2264d87d9c40c977eb7278904e35d68

          gerrit Gerrit Updater added a comment - Jian Yu (jian.yu@intel.com) uploaded a new patch: https://review.whamcloud.com/31186 Subject: LU-10611 autoconf: check zlib library and zlib.h header file Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: fe805d42e2264d87d9c40c977eb7278904e35d68
          pjones Peter Jones added a comment -

          Jian

          Could you please investigate

          Peter

          pjones Peter Jones added a comment - Jian Could you please investigate Peter

          People

            yujian Jian Yu
            cealustre CEA
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: