[LU-10765] Broken error fs handling in llapi_hsm_action_{begin,end}

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Labels: easy
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

Both llapi_hsm_action_begin/end have this code in error handling:

err_out:
        if (!(hcp->source_fd < 0))
                close(hcp->source_fd);

The problem is source_fd is unsigned, so it could never be less than zero.