Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.12.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      There is no need to implement llog_cancel() as an llog operation. (We do not need to have a lop_cancel member in struct llog_operations. This method only used by changelogs now and the prototype is abused to make it work.

      With lop_cancel removed, all uses of hsm_actions_logops, changelog_orig_logops, and osp_mds_ost_orig_logops can be replaces with llog_common_cat_ops.

      LLOG_AGENT_ORIG_CTXT should be called LLOG_ACTIONS_ORIG_CTXT.

      LLOG_AGENT_ORIG_CTXT setup and cleanup should be moved from the MDD layer to the MDT layer. Then there will be no need for the MDT to clone this context.

      Attachments

        Issue Links

          Activity

            [LU-10855] llog cleanups
            pjones Peter Jones added a comment -

            Landed for 2.12

            pjones Peter Jones added a comment - Landed for 2.12

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/31812/
            Subject: LU-10855 llog: use llog_common_cat_ops
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 3e61bbbcd4baaac76a67093404b60810261812e0

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/31812/ Subject: LU-10855 llog: use llog_common_cat_ops Project: fs/lustre-release Branch: master Current Patch Set: Commit: 3e61bbbcd4baaac76a67093404b60810261812e0

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32654/
            Subject: LU-10855 ptlrpc: remove obsolete LLOG_ORIGIN_* RPCs
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 830ce1b10f3a5d3536e5ec0a9ef87fe739a509a2

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32654/ Subject: LU-10855 ptlrpc: remove obsolete LLOG_ORIGIN_* RPCs Project: fs/lustre-release Branch: master Current Patch Set: Commit: 830ce1b10f3a5d3536e5ec0a9ef87fe739a509a2

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32653/
            Subject: LU-10855 ptlrpc: assign specific values to MGS opcodes
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 12c5a26609f12b36dda0bfb33e27cc03f805155d

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32653/ Subject: LU-10855 ptlrpc: assign specific values to MGS opcodes Project: fs/lustre-release Branch: master Current Patch Set: Commit: 12c5a26609f12b36dda0bfb33e27cc03f805155d

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32651/
            Subject: LU-10855 ptlrpc: remove obsolete OBD RPC opcodes
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 7d89a5b8aefc5417fa04c03ab15b447cfde01e9b

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32651/ Subject: LU-10855 ptlrpc: remove obsolete OBD RPC opcodes Project: fs/lustre-release Branch: master Current Patch Set: Commit: 7d89a5b8aefc5417fa04c03ab15b447cfde01e9b

            Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/32654
            Subject: LU-10855 ptlrpc: remove obsolete LLOG_ORIGIN_* RPCs
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 553446963306c42f9af96604ddded80d63986450

            gerrit Gerrit Updater added a comment - Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/32654 Subject: LU-10855 ptlrpc: remove obsolete LLOG_ORIGIN_* RPCs Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 553446963306c42f9af96604ddded80d63986450

            Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/32653
            Subject: LU-10855 ptlrpc: assign specific values to MGS opcodes
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: a1903b4d49bcf536afd3b3c375eae96de45826df

            gerrit Gerrit Updater added a comment - Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/32653 Subject: LU-10855 ptlrpc: assign specific values to MGS opcodes Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: a1903b4d49bcf536afd3b3c375eae96de45826df

            Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/32651
            Subject: LU-10855 ptlrpc: remove obsolete RPC opcodes
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 7d3b46be031609ad657230677a31719c6fca78c7

            gerrit Gerrit Updater added a comment - Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/32651 Subject: LU-10855 ptlrpc: remove obsolete RPC opcodes Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 7d3b46be031609ad657230677a31719c6fca78c7

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/32202/
            Subject: LU-10855 llog: remove obsolete llog handlers
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 85011d372dfb50500ba5eef3f2fa79e5d6507539

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/32202/ Subject: LU-10855 llog: remove obsolete llog handlers Project: fs/lustre-release Branch: master Current Patch Set: Commit: 85011d372dfb50500ba5eef3f2fa79e5d6507539

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31795/
            Subject: LU-10855 llog: remove llog_cancel()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 86cb7e80f2a573bb23a10ee9eebe3c7f525bd2d0

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31795/ Subject: LU-10855 llog: remove llog_cancel() Project: fs/lustre-release Branch: master Current Patch Set: Commit: 86cb7e80f2a573bb23a10ee9eebe3c7f525bd2d0

            People

              jhammond John Hammond
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: