Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.12.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      There is no need to implement llog_cancel() as an llog operation. (We do not need to have a lop_cancel member in struct llog_operations. This method only used by changelogs now and the prototype is abused to make it work.

      With lop_cancel removed, all uses of hsm_actions_logops, changelog_orig_logops, and osp_mds_ost_orig_logops can be replaces with llog_common_cat_ops.

      LLOG_AGENT_ORIG_CTXT should be called LLOG_ACTIONS_ORIG_CTXT.

      LLOG_AGENT_ORIG_CTXT setup and cleanup should be moved from the MDD layer to the MDT layer. Then there will be no need for the MDT to clone this context.

      Attachments

        Issue Links

          Activity

            [LU-10855] llog cleanups
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.12.0 [ 13495 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            jhammond John Hammond made changes -
            Description Original: There is no need to implement {{llog_cancel()}} as an llog operation. (We do not need to have a {{lop_cancel}} member in {{struct llog_operations}}. This method only used by changelogs now and the prototype is abused to make it work.

            With {{lop_cancel}} removed, all uses of {{hsm_actions_logops}}, {{changelog_orig_logops}}, and {{osp_mds_ost_orig_logops}} can be replaces with {{llog_common_cat_ops}}.

            {{LLOG_AGENT_ORIG_CTXT}} should be called {{LLOG_ACTIONS_ORIG_CTXT}}.

            {{LLOG_AGENT_ORIG_CTXT}} setup and cleanup should be moved from the MDD layer to the MDT layer. Then there will be no need for the MDT to clone this context.

            AFAICT there is no need for the MDT layer to clone {{LLOG_CHANGELOG_ORIG_CTXT}}.


            New: There is no need to implement {{llog_cancel()}} as an llog operation. (We do not need to have a {{lop_cancel}} member in {{struct llog_operations}}. This method only used by changelogs now and the prototype is abused to make it work.

            With {{lop_cancel}} removed, all uses of {{hsm_actions_logops}}, {{changelog_orig_logops}}, and {{osp_mds_ost_orig_logops}} can be replaces with {{llog_common_cat_ops}}.

            {{LLOG_AGENT_ORIG_CTXT}} should be called {{LLOG_ACTIONS_ORIG_CTXT}}.

            {{LLOG_AGENT_ORIG_CTXT}} setup and cleanup should be moved from the MDD layer to the MDT layer. Then there will be no need for the MDT to clone this context.


            jhammond John Hammond made changes -
            Link New: This issue is related to LU-10699 [ LU-10699 ]
            jhammond John Hammond created issue -

            People

              jhammond John Hammond
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: