Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10946

add an interface to load ldiskfs block bitmaps

Details

    • Improvement
    • Resolution: Won't Fix
    • Minor
    • None
    • None
    • 9223372036854775807

    Description

      During our benchmarking/testing, we found sometimes write performances are not stable enough and there are some small read during write which could drop thoughoutput of write performances.

      It turned out that block bitmaps load make some latency here, also for a heavy fragment filesystem, we might need load many bitmaps to find some free blocks.

      To improve above situation, we had a patch to load block bitmaps to memory and pin those bitmaps memory until unmount or we release the memory on purpose, this could stable write performances and improve performances of a heavy fragment filesystem.

      Attachments

        Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. LU-17153 Random block allocation policy in ldiskfs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. LU-10967 MDT page cache management improvements

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. LU-12970 improve mballoc for huge filesystems

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-10946] add an interface to load ldiskfs block bitmaps
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-17153 [ LU-17153 ]
            wshilong Wang Shilong (Inactive) made changes -
            Resolution New: Won't Fix [ 2 ]
            Status Original: Open [ 1 ] New: Closed [ 6 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-12970 [ LU-12970 ]
            adilger Andreas Dilger made changes -
            Description Original:
                 During our benchmarking/testing, we found sometimes write performances

            are not stable enough and there are some small read during write which could

            drop thoughoutput of write performances.

                  It turned out that block bitmaps load make some latency here, also for a heavy

            fragment filesystem, we might need load many bitmaps to find some free blocks.

            To improve above situation, we had a patch to load block bitmaps to memory

            and pin those bitmaps memory until unmount or we release the memory on

            purpose, this could stable write performances and improve performances of

            a heavy fragment filesystem.
            		 New: During our benchmarking/testing, we found sometimes write performances are not stable enough and there are some small read during write which could drop thoughoutput of write performances.

            It turned out that block bitmaps load make some latency here, also for a heavy fragment filesystem, we might need load many bitmaps to find some free blocks.

            To improve above situation, we had a patch to load block bitmaps to memory and pin those bitmaps memory until unmount or we release the memory on purpose, this could stable write performances and improve performances of a heavy fragment filesystem.
            adilger Andreas Dilger made changes -
            Link New: This issue is related to DDN-923 [ DDN-923 ]
            pjones Peter Jones made changes -
            Assignee Original: Wang Shilong [ wangshilong ] New: Wang Shilong [ wshilong ]
            wangshilong Wang Shilong (Inactive) added a comment -

            Hi Jay Lan,

            You could just ignore the 4 missing patches, and apply my patch directly, I build locally, it works.

            Thanks,
            Shilong

            wangshilong Wang Shilong (Inactive) added a comment - Hi Jay Lan, You could just ignore the 4 missing patches, and apply my patch directly, I build locally, it works. Thanks, Shilong
            jaylan Jay Lan (Inactive) added a comment - - edited

            Hi Shilong,

            Nathan asked me to cherry-pick the #32347 review. This patch caused conflicts in b2_10. Branch b2_10 is 4 ldiskfs kernel_patches behind compared to master branch. Is there dependency on the 4 missing patches or any other commit? If yes, could you list prerequisites of your patch?

            Thanks,
            Jay

            jaylan Jay Lan (Inactive) added a comment - - edited Hi Shilong, Nathan asked me to cherry-pick the #32347 review. This patch caused conflicts in b2_10. Branch b2_10 is 4 ldiskfs kernel_patches behind compared to master branch. Is there dependency on the 4 missing patches or any other commit? If yes, could you list prerequisites of your patch? Thanks, Jay
            wangshilong Wang Shilong (Inactive) added a comment -

            Hi Nathan Dauchy,

            Sorry for late patch, I just pushed a simple version, could you help test if it help your performance case?

            echo 1 > /sys/fs/ldiskfs/vdb/loadbbitmaps # this is just load not pin.
            echo 2 > /sys/fs/ldiskfs/vdb/loadbbitmaps # pin block bitmaps in memory
            echo 0 > /sys/fs/ldiskfs/vdb/loadbbitmaps #unpin block bitmaps in memory

            Thanks,
            Shilong

            wangshilong Wang Shilong (Inactive) added a comment - Hi Nathan Dauchy, Sorry for late patch, I just pushed a simple version, could you help test if it help your performance case? echo 1 > /sys/fs/ldiskfs/vdb/loadbbitmaps # this is just load not pin. echo 2 > /sys/fs/ldiskfs/vdb/loadbbitmaps # pin block bitmaps in memory echo 0 > /sys/fs/ldiskfs/vdb/loadbbitmaps #unpin block bitmaps in memory Thanks, Shilong
            gerrit Gerrit Updater added a comment -

            Wang Shilong (wshilong@ddn.com) uploaded a new patch: https://review.whamcloud.com/32347
            Subject: LU-10946 ldiskfs: add an interface to load ldiskfs block bitmaps
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: f2989ee1ac1b7ca5666fc1cf42f9e95f3da20200

            gerrit Gerrit Updater added a comment - Wang Shilong (wshilong@ddn.com) uploaded a new patch: https://review.whamcloud.com/32347 Subject: LU-10946 ldiskfs: add an interface to load ldiskfs block bitmaps Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: f2989ee1ac1b7ca5666fc1cf42f9e95f3da20200

            People

              wshilong Wang Shilong (Inactive)
              wangshilong Wang Shilong (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: