Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11050

mdd: modifying changelog_deniednext does not yield immediate result

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      From what I could read in mdd_object.c the procfile changelog_deniednext is the number of seconds to wait before logging another NOPEN changelog record.

      The implementation computes a deadline once (when an NOPEN is logged) instead of comparing the current time + the timeout. This means that if somebody sets the timeout to 3600s, produces an NOPEN changelog and then sets back the timeout to 60s, one will still need to wait an hour to see the next NOPEN changelog.

      Attachments

        Issue Links

          Activity

            [LU-11050] mdd: modifying changelog_deniednext does not yield immediate result

            How about re-computing the deadline everytime the proc file is written to?

            bougetq Quentin Bouget (Inactive) added a comment - How about re-computing the deadline everytime the proc file is written to?

            Hi,

            What you describe is how the changelog_deniednext tunable was designed. As the name tends to suggest, it defines when the next NOPEN Changelog entry will be recorded, counting from the last recorded entry.
            This implementation was suggested by Andreas. It is slightly more efficient to add changelog_deniednext delay when saving denied time, and then just compare against that, instead of adding changelog_deniednext delay to denied time for each check.

            Thanks,
            Sebastien.

            sbuisson Sebastien Buisson (Inactive) added a comment - Hi, What you describe is how the changelog_deniednext tunable was designed. As the name tends to suggest, it defines when the next NOPEN Changelog entry will be recorded, counting from the last recorded entry. This implementation was suggested by Andreas. It is slightly more efficient to add changelog_deniednext delay when saving denied time, and then just compare against that, instead of adding changelog_deniednext delay to denied time for each check. Thanks, Sebastien.
            pjones Peter Jones added a comment -

            Sebastien

            Could you please comment?

            Thanks

            Peter

            pjones Peter Jones added a comment - Sebastien Could you please comment? Thanks Peter

            I was hoping someone else could do it...

            bougetq Quentin Bouget (Inactive) added a comment - I was hoping someone else could do it...
            pjones Peter Jones added a comment -

            Quentin

            Is this something that you are planning to work on?

            Peter

            pjones Peter Jones added a comment - Quentin Is this something that you are planning to work on? Peter

            People

              sebastien Sebastien Buisson
              cealustre CEA
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: