[LU-11114] Track creates in MDC and llite stats

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0, Lustre 2.12.5
• Affects Version/s: Lustre 2.10.4
• Labels: llnl
• Environment: RHEL 7.5
• Severity: 3
• Assignee: Emoly Liu
• Reporter: Olaf Faaland

Description

File creates are not tracked in llite stats. Andreas mentioned this in LU-8150. I can submit a patch to change it, but wasn't sure whether it was just overlooked or if there was a reason it wasn't done.

bash-4.2$ cat /proc/fs/lustre/llite/lquake-ffff883a74d0a000/stats
snapshot_time 1530651162.784915742 secs.nsecs
bash-4.2$ touch /p/lquake/faaland1/touched
bash-4.2$ echo $?
0
bash-4.2$ cat /proc/fs/lustre/llite/lquake-ffff883a74d0a000/stats
snapshot_time 1530651198.529596878 secs.nsecs
open 1 samples [regs]
close 1 samples [regs]
readdir 2 samples [regs]
setattr 1 samples [regs]
getattr 3 samples [regs]
alloc_inode 1 samples [regs]
getxattr 7 samples [regs]
getxattr_hits 6 samples [regs]
removexattr 1 samples [regs]
inode_permission 6 samples [regs]
bash-4.2$ grep -e creat -e mknod /proc/fs/lustre/llite/lquake-ffff883a74d0a000/stats

Comments

[Gerrit Updater]

Olaf Faaland-LLNL ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38158
Subject: LU-11114 llite: Update mdc and lite stats on open|creat
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 1da087645f0127a5e6e911991dbb5aa84e3b8d2e

[Olaf Faaland]

Hi Peter, yes, I think it is worth considering.  Thanks.

 

[Peter Jones]

Landed for 2.14. ofaaland should we consider this for a future 2.12.x release too?

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36948/
Subject: LU-11114 llite: Update mdc and lite stats on open|creat
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4b8518ee4fa542f45fcdaeaec580d858dfcaf137

[Gerrit Updater]

Olaf Faaland-LLNL ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36948
Subject: LU-11114 llite: Update mdc and lite stats on open|creat
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0fa270dbe557bd80e374514b3073163bcdaa2d87

[Olaf Faaland]

Hi, checking on this again. I'm not asking for a patch, I'm asking whether there's a technical reason this is problematic to do.

[Peter Jones]

Emoly

Could you please look into this request?

Thanks

Peter

[Olaf Faaland]

Also, not tracked in MDC and it seems to me like they should be, so you can see which MDTs your creates are occurring on. But maybe there's a reason not to.