Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-1139

Put FID into the wire directly by OBD_CONNECT_FID

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Minor
    • None
    • None
    • None
    • 3
    • 7882

    Description

      Description from Andreas
      " this makes me wonder if we can also use OBD_CONNECT_FID to change ost_id in lov_mds_md, obdo, etc to be a fid? this would clean up a bunch of code
      [2:50:19 PM PDT] wangdi: this probably makes more sense.
      [2:51:22 PM PDT] Andreas Dilger: i.e. it could use:

      struct ost_fid {
      union

      { struct lu_fid oi_fid; struct ost_id oi_id; }

      ;
      };
      [2:52:37 PM PDT] Andreas Dilger: it would make all the code conditional to check if oi_id.oi_seq != 0 and treat it as an lu_fid
      [2:53:01 PM PDT] wangdi: ok
      [2:53:59 PM PDT] Andreas Dilger: the first step (which Johann has already started on in one patch on orion, but needs more) is to convert all of the code to using struct ost_id instead of separate o_id and o_gr/o_seq
      [2:55:01 PM PDT] Andreas Dilger: this will simplify a bunch of code already to allow struct copying instead of separate fields, and I also saw several places where e.g. o_seq was not being used properly
      [2:55:43 PM PDT] wangdi: I wonder wheather we should bring res_id in as well? probably not
      [2:55:50 PM PDT] Andreas Dilger: this should be done in small patches (e.g. one patch per struct) and targetted at master
      [2:55:59 PM PDT] wangdi: ok
      "

      Attachments

        Issue Links

          Activity

            People

              di.wang Di Wang
              di.wang Di Wang
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: