[LU-11432] enum constants like lnet_msg_type in LNet should have specific values

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.17.0
• Labels: easy patch
• Severity: 3
• Assignee: Aryan Gupta
• Reporter: Sonia Sharma (Inactive)

Description

In LNet (lnet-types.h), the enum constants are started from 0 and so the values are given per the position in the struct. It looks like this.

enum lnet_msg_type {
    LNET_MSG_ACK = 0,                          
    LNET_MSG_PUT,
    LNET_MSG_GET,
    LNET_MSG_REPLY,
    LNET_MSG_HELLO,                                                                                    
};

This should be fixed and be given specific values.

As Andreas pointed out - "This avoids bugs in the future if one of these constants is deleted, or if someone accidentally tries to add a value in the middle of the list, which would bump up all of the following values by one and break the network protocol compatibility."

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/33251/
Subject: LU-11432 lnet: Assign specific values to enum constants
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 843ec60f396e78abc1fa340322dabf63a3daf6ef

[Gerrit Updater]

"Aryan Gupta <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/60168
Subject: LU-11432 lnet: Assign specific values to enum constants
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6adabba08849092245f542b9c3d53227a9ee03fa

[Gerrit Updater]

Sonia Sharma ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33251
Subject: LU-11432 lnet: Assign specific values to enum constt
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 49676250f1eaffb30d50afee71a990db749bc90d