Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
None
-
3
-
9223372036854775807
Description
Many LNet WIRE_ATTR structs are not checked for in lnet_assert_wire_constants(). Add checks for all those WIRE_ATTR structs.
To make this change of adding WIRE_ATTR structs in lnet_assert_wire_constants() easier, move lnet_assert_wire_constants() from lnet/lnet/api-ni.c to lnet/utils/wirecheck.c.
The reason for this as Andreas points - "In Lustre, the code to verify wire constants can be generated by running wirecheck, but is not automatically generated to avoid automatically clobbering the current checks. Moving lnet_assert_wire_constants() into a separate wiretest.c file from api-ni.c would make this update process easier."