[LU-11441] obd_get_mod_rpc_slot: run FIFO wait queue

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.12.0
• Severity: 3
• Assignee: Vladimir Saveliev
• Reporter: Vladimir Saveliev

Description

Under relatively big load a process may spin in obd_get_mod_rpc_slot() for a long time
without successful grabbing a free mod rpc slot. It has been observed
a process spinning more than 100 seconds. See excerpt from lustre logs below. That test ran 72 mdtest-s and 8 IOR-s.

00000020:00100000:12.0:1534800918.648481:0:5506:0:(genops.c:2572:obd_get_mod_rpc_slot()) fs1-MDT0000-mdc-ffff88105b2f9000: sleeping for a modify RPC slot opc 101, max 7
...
00000020:00100000:28.0:1534800934.002775:0:5506:0:(genops.c:2572:obd_get_mod_rpc_slot()) fs1-MDT0000-mdc-ffff88105b2f9000: sleeping for a modify RPC slot opc 101, max 7
...
00000020:00100000:12.0:1534800972.382794:0:5506:0:(genops.c:2572:obd_get_mod_rpc_slot()) fs1-MDT0000-mdc-ffff88105b2f9000: sleeping for a modify RPC slot opc 101, max 7
...
00000020:00100000:31.0:1534801033.373093:0:5506:0:(genops.c:2572:obd_get_mod_rpc_slot()) fs1-MDT0000-mdc-ffff88105b2f9000: sleeping for a modify RPC slot opc 101, max 7

It might make sense for obd_get_mod_rpc_slot () to run FIFO wait queue.

Comments

[Peter Jones]

Landed for 2.12

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33282/
Subject: LU-11441 obdclass: make mod rpc slot wait queue FIFO
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7fa0fd41577001629f7ecc418cfe814a46207148

[Gerrit Updater]

Alexander Zarochentsev ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33282
Subject: LU-11441 obdclass: make mod rpc slot wait queue FIFO
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 15bc6978fbbaee0ca003e1eea57e5fc45ec1950d

[Vladimir Saveliev]

Attached the patch here because for unknown reasons git push started to fail for me with:

 ! [remote rejected]       HEAD -> refs/for/master (not Signed-off-by author/committer/uploader in commit message footer)
error: failed to push some refs to 'ssh://[e-mail]:29418/fs/lustre-release'