[LU-11501] use the dcache properly with .lustre/fid

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Fix Version/s: Upstream
• Severity: 3
• Assignee: James A Simmons
• Reporter: James A Simmons

Description

While addressing several bugs for how Lustre handles the dcache a bug was exposed with sanity test 233. In the testing with newer kernels the following was seen:

VFS: Lookup of '[0x200000002:0x1:0x0]' in lustre lustre would have caused loop

In older kernels it is an outright crash of the node. After some debugging it was discovered why. If a name in .lustre/fid refers to a directory, then that directory will (could) have 2 names in the dcache - the name in .lustre/fid, and the "real" name. The dcache does not permit this. You cannot have two dentries pointing the the same directory inode. Multiple hard links to directories are forbidden. Currently lustre attempts to break this rule by spinning its own dcache routines but that does not guarantee in the future that some core dcache functionality will change that breaks lustre. Due to the having multiple hard links you can form loops like reported above or if some core dcache functionality does an assert of dancestor() that will crash the node.  It could even be possible that in the future the dcache core code might even prune its cache of broken dentries.

Issue Links

• is related to: LU-5008 bad negative dentry caching in .lustre/fid
• is related to: LU-8585 All Lustre test suites should pass with subdirectory mount
• is related to: LU-9629 lfs migrate does not work as a non-root user
• is related to: LU-11970 Using changelog reader causes fid2path process to lockup in kernel space
• is related to: LU-9868 dcache/namei fixes for lustre