[LU-11520] separate tests and bugfixes

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Assignee: Elena Gryaznova
• Reporter: Vitaly Fertman

Description

I already made this proposal several times that landing bugfixes in series of 2 patches of a test and a fix on top on the test is a good idea because:

 

• it explicitly shows you the test actually reproduces a problem, not because we trust a developer;
• you can revert only a fix at some later point and confirm the test still able to reproduce some problem;
   
  however there were several objections:
• it will not work with git bisect;
• malloo does not (and not supposed to) set +1 if test failure occurs;
   
  The proposal which seems to resolve these objections is to add a tag/label “mustfail” to the commit message of the test patch and the malloo is supposed to consider this particular failure as a success (as well as the successful test as a failure) and to set +1 (-1). at the same time the fix sitting on top already does not have this tag/label and therefore the test already must pass.
   
  the proposal was discussed with Andreas o the last LAD and we agreed that it would work, thus filing the ticket for it.

Issue Links

• is related to: LU-11642 Data lost after migrate striped dir