[LU-11561] Change syncjournal back to sync_journal

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.12.0
• Affects Version/s: Lustre 2.12.0
• Labels: tests
• Severity: 3
• Assignee: James Nunez (Inactive)
• Reporter: James Nunez (Inactive)

Description

When we moved the ofd module from using proc to sysfs, the sync journal attribute changed from sync_journal to syncjournal; LU-8066 patch commit 7059644e9ad3eaf.

obdfilter-survey and replay-single still use sync_journal:

lustre/tests/obdfilter-survey.sh:		$LCTL get_param obdfilter.${FSNAME}-*.sync_journal
lustre/tests/obdfilter-survey.sh:		"obdfilter.${FSNAME}-*.sync_journal" > $param_file
lustre/tests/obdfilter-survey.sh:		$LCTL set_param obdfilter.${FSNAME}-*.sync_journal=0
lustre/tests/obdfilter-survey.sh:		$LCTL get_param obdfilter.${FSNAME}-*.sync_journal
lustre/tests/obdfilter-survey.sh:		"obdfilter.${FSNAME}-*.sync_journal" > $param_file
lustre/tests/obdfilter-survey.sh:		$LCTL set_param obdfilter.${FSNAME}-*.sync_journal=0
lustre/tests/replay-single.sh:	do_facet ost1 "lctl set_param -n obdfilter.${ost1_svc}.sync_journal 0"
lustre/tests/replay-single.sh:	do_facet ost1 "lctl set_param -n obdfilter.${ost1_svc}.sync_journal 0"

Note: This change needs to be made to the Lustre manual also:

By default, sync_journal is enabled (sync_journal=1), so that journal entries are committed synchronously. To enable asynchronous journal commit, set the sync_journal parameter to 0 by entering:

$ lctl set_param obdfilter.*.sync_journal=0 
obdfilter.lol-OST0001.sync_journal=0

EDIT: Based on Andreas' comment below, let's move syncjournal back to sync_journal.

Issue Links

• is related to: LU-11562 replay-single test 87a fails with 'New checksum d41d8cd98f00b204e9800998ecf8427e does not match original X'
• is related to: LU-8066 Move lustre procfs handling to sysfs and debugfs.

Comments

[Peter Jones]

Landed for 2.12

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33582/
Subject: LU-11561 ofd: return attr syncjournal to sync_journal
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8701b62863eb71a67b80da873726903920d1bada

[Gerrit Updater]

James Nunez ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33582
Subject: LU-11561 ofd: return syncjournal to sync_journal
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9f9e9a1ec3de4da35d4292391e92cfa49eba0564

[Andreas Dilger]

This will also cause test and user interop issues. Instead of fixing the test, you should rename the /sys files to "sync_journal" again.