[LU-11739] Don't inherit default layout from root for new subdirectories

• Type: Improvement
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.13.0, Lustre 2.10.7, Lustre 2.12.4
• Affects Version/s: Lustre 2.12.0, Lustre 2.10.6
• Assignee: Jian Yu
• Reporter: Andreas Dilger

Description

There is no need to inherit the default directory layout from the root directory when subdirectories are created therein. This consumes xattr space on the subdirectories, and makes it more complex to change the filesystem default layout in the future.

Instead, it should be possible to check if the parent directory is the root directory and not copy the default layout xattr to the new subdirectory.

Issue Links

• is duplicated by: LU-12433 subdir under ROOT should honor ROOT default layout in creation
• is related to: LU-12643 PFL layout don't inherit correctly from default layout.
• is related to: LU-11656 "lfs getstripe" on directory does not show default root layout
• is related to: LU-11920 memory leak in lod_lds_buf_get()
• is related to: LU-11875 "lfs find" does not return directories when searching for default layouts
• is related to: LU-11995 sanity test_65n returned 127
• is related to: LU-9982 Clients striping from mapped FID in nodemap

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36370/
Subject: LU-11739 lod: subdir under ROOT should honor default layout
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: a53869aa31ceee700215520e5267b155a0f59d46

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36370
Subject: LU-11739 lod: subdir under ROOT should honor default layout
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: ba7427ac4dfbee42e34ba3b1b6a9a7b33e8c89dc

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35204/
Subject: LU-11739 lod: subdir under ROOT should honor default layout
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 693fb63ac777eab426f1b618316a5649534759ad

[Andreas Dilger]

There is a patch that has not been landed yet.

[Gerrit Updater]

Lai Siyao ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35204
Subject: LU-11739 lod: subdir under ROOT should honor default layout
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3a615a0fbd184015e2aea4e5a02015f054a4698b

[Lai Siyao]

Okay, I'll work on it after vacation.

[Andreas Dilger]

Lai, could you please put your comments in the form of a test case, to verify if this is working or broken. If it is broken, then we can use your patch to verify it is working when it is fixed.

[Lai Siyao]

This patch looks wrong to me: in lod_ah_init(), if parent directory is ROOT, it skips reading default layout, which means subdirs under ROOT don't follow default layout, while in my understanding it need to read default layout anyway, and then use it to decide child layout, but it doesn't inherit this default layout (by clearing it after use).

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34135/
Subject: LU-11739 lod: don't inherit default layout from root directory
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 6ceb90a2461e2724121a6c26434e11bcb31c9f43