[LU-11770] preserve kernel API when T10-PI patches are applied

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.4
• Affects Version/s: Lustre 2.12.0
• Severity: 3
• Assignee: Andreas Dilger
• Reporter: Andreas Dilger

Description

Preserve the existing kernel API when the T10-PI patches are applied, so that any other modules using this interface do not break.

In particular, keep the EXPORT_SYMBOL(bio_integrity_alloc) and EXPORT_SYMBOL(bio_integrity_prep) in place.

In struct bio_integrity_payload put *bip_generate_fn and *bip_verify_fn after *bip_vec since that field is directly accessed by callers. In struct blk_integrity_exchg the bi_idx field only needs to be an unsigned short since the bio->bi_idx and bio->bi_vcnt values used with it are also unsigned short, which saves 8 bytes of padding in the struct and puts the added fields at the end to preserve the structure field alignment.

Issue Links

• is related to: LU-11822 what does this mean nbp16-OST0004: unsupported T10PI type ''
• is related to: LU-11712 Lustre build fails when CONFIG_BLK_DEV_INTEGRITY is unset
• is related to: LU-10472 Data Integrity(T10PI) support for Lustre

Comments

[Gerrit Updater]

"Jian Yu <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/48701
Subject: LU-11770 osd-ldiskfs: clean up inline macro usage
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 4f300e04a662ffd057f253bd795ee14762d35dbe

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37167/
Subject: LU-11770 misc: fix bdev_integrity_enabled definition
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 6db0c4f08225f5907318aa27970f42896d1da94f

[Gerrit Updater]

Li Dongyang ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37167
Subject: LU-11770 misc: fix bdev_integrity_enabled definition
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: f96fcf1a8d77920e302da1c46409c03c250242cc

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34156/
Subject: LU-11770 osc: allow build without blk_integrity or crc-t10pi
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: b14e6617b9b7181b136a0500bb6aebc730802c3c

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33923/
Subject: LU-11770 osc: allow build without blk_integrity or crc-t10pi
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e0fb3133372e5bff434ac7a467304d9ba954bac6

[Gerrit Updater]

Li Dongyang ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34156
Subject: LU-11770 osc: allow build without blk_integrity or crc-t10pi
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 4fb605e4a654f74387758e9d32a03fe86f26522f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33841/
Subject: LU-11770 osd-ldiskfs: clean up inline macro usage
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fa30d1efff93c6e11b7cf40c966f804c4718fbe8

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33923
Subject: LU-11770 osc: allow build without blk_integrity or crc-t10pi
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9f873b42c36b95c7a87057fe52d667cc66e0baf9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33840/
Subject: LU-11770 osd-ldiskfs: preserve bio_integrity API
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e4a9ea67935e14cfcee84f15162ab9a9673b0adf