Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11770

preserve kernel API when T10-PI patches are applied

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.13.0, Lustre 2.12.4
    • Lustre 2.12.0
    • None
    • 3
    • 9223372036854775807

    Description

      Preserve the existing kernel API when the T10-PI patches are applied, so that any other modules using this interface do not break.

      In particular, keep the EXPORT_SYMBOL(bio_integrity_alloc) and EXPORT_SYMBOL(bio_integrity_prep) in place.

      In struct bio_integrity_payload put *bip_generate_fn and *bip_verify_fn after *bip_vec since that field is directly accessed by callers. In struct blk_integrity_exchg the bi_idx field only needs to be an unsigned short since the bio->bi_idx and bio->bi_vcnt values used with it are also unsigned short, which saves 8 bytes of padding in the struct and puts the added fields at the end to preserve the structure field alignment.

      Attachments

        Issue Links

          Activity

            [LU-11770] preserve kernel API when T10-PI patches are applied

            "Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/48701
            Subject: LU-11770 osd-ldiskfs: clean up inline macro usage
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: 4f300e04a662ffd057f253bd795ee14762d35dbe

            gerrit Gerrit Updater added a comment - "Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/48701 Subject: LU-11770 osd-ldiskfs: clean up inline macro usage Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 4f300e04a662ffd057f253bd795ee14762d35dbe
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.12.4 [ 14690 ]
            Fix Version/s Original: Lustre 2.12.1 [ 14406 ]

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37167/
            Subject: LU-11770 misc: fix bdev_integrity_enabled definition
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: 6db0c4f08225f5907318aa27970f42896d1da94f

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37167/ Subject: LU-11770 misc: fix bdev_integrity_enabled definition Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 6db0c4f08225f5907318aa27970f42896d1da94f
            dongyang Dongyang Li made changes -
            Link New: This issue is related to EX-361 [ EX-361 ]

            Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/37167
            Subject: LU-11770 misc: fix bdev_integrity_enabled definition
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: f96fcf1a8d77920e302da1c46409c03c250242cc

            gerrit Gerrit Updater added a comment - Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/37167 Subject: LU-11770 misc: fix bdev_integrity_enabled definition Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: f96fcf1a8d77920e302da1c46409c03c250242cc
            mdiep Minh Diep made changes -
            Fix Version/s New: Lustre 2.12.1 [ 14406 ]
            mdiep Minh Diep made changes -
            Labels Original: LTS12

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34156/
            Subject: LU-11770 osc: allow build without blk_integrity or crc-t10pi
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: b14e6617b9b7181b136a0500bb6aebc730802c3c

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34156/ Subject: LU-11770 osc: allow build without blk_integrity or crc-t10pi Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: b14e6617b9b7181b136a0500bb6aebc730802c3c
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.13.0 [ 14290 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Landed for 2.13

            pjones Peter Jones added a comment - Landed for 2.13

            People

              adilger Andreas Dilger
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: